- Fix bug where issue title was not being set

- Use compund drawable instead of an imageview
- Reset compound drawable every time so that viewholders being reused show the correct confidentiality status

app/src/main/java/com/commit451/gitlab/activity/IssueActivity.kt

@@ -251,6 +251,7 @@ class IssueActivity : BaseActivity() {
     fun bindIssue() {
         setOpenCloseMenuStatus()
+        textTitle.text = issue?.title
         toolbarTitle.text = getString(R.string.issue_number, issue?.iid)
         if (issue?.isConfidential!!) {
             toolbarTitle.setCompoundDrawablesWithIntrinsicBounds(0, 0, R.drawable.ic_confidential_24dp, 0)

app/src/main/java/com/commit451/gitlab/viewHolder/IssueViewHolder.kt

@@ -33,7 +33,6 @@ class IssueViewHolder(view: View) : RecyclerView.ViewHolder(view) {
     @BindView(R.id.issue_image) lateinit var image: ImageView
     @BindView(R.id.issue_message) lateinit var textMessage: TextView
     @BindView(R.id.issue_creator) lateinit var textCreator: TextView
-    @BindView(R.id.issue_confidential_image) lateinit var imageConfidential: ImageView
     init {
         ButterKnife.bind(this, view)
@@ -57,6 +56,10 @@ class IssueViewHolder(view: View) : RecyclerView.ViewHolder(view) {
         }
         textMessage.text = issue.title
+        textMessage.setCompoundDrawablesWithIntrinsicBounds(0, 0, 0, 0)
+        if (issue.isConfidential) {
+            textMessage.setCompoundDrawablesWithIntrinsicBounds(R.drawable.ic_confidential_24dp, 0, 0, 0)
+        }
         var time = ""
         if (issue.createdAt != null) {
@@ -74,10 +77,5 @@ class IssueViewHolder(view: View) : RecyclerView.ViewHolder(view) {
         id = "#" + issueId
         textCreator.text = String.format(itemView.context.getString(R.string.opened_time), id, time, author)
-
-        if (issue.isConfidential) {
-            imageConfidential.visibility = View.VISIBLE
-            imageConfidential.setImageResource(R.drawable.ic_confidential_24dp)
-        }
     }
 }

app/src/main/res/layout/item_issue.xml

@@ -9,31 +9,24 @@
     android:baselineAligned="false">
     <!--baselineAligned="false" is recommended for better performance by Android Studio-->
-    <RelativeLayout
+    <LinearLayout
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_marginBottom="8dp"
         android:layout_marginLeft="@dimen/activity_horizontal_margin"
         android:layout_marginRight="@dimen/activity_horizontal_margin"
         android:layout_marginTop="8dp"
+        android:orientation="vertical"
         android:layout_weight="1">
-        <ImageView
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:id="@+id/issue_confidential_image"
-            android:visibility="gone"
-            android:layout_marginRight="8dp"
-            tools:src="@drawable/ic_confidential_24dp"/>
-
         <TextView
             android:id="@+id/issue_message"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:ellipsize="end"
             android:maxLines="2"
+            android:drawablePadding="8dp"
             android:textSize="@dimen/text_size_small"
-            android:layout_toRightOf="@id/issue_confidential_image"
             tools:text="I commited all the code at once cause I am cool. So sorry" />
         <TextView
@@ -41,10 +34,9 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:textSize="@dimen/text_size_tiny"
-            android:layout_below="@+id/issue_message"
             tools:text="Created 45 days ago by Jawnnypoo" />
-    </RelativeLayout>
+    </LinearLayout>
     <LinearLayout
         android:orientation="vertical"