Fix some leaky context references

app/src/main/java/com/commit451/gitlab/activity/AboutActivity.java

@@ -144,8 +144,6 @@ public class AboutActivity extends BaseActivity {
     private void addContributors(List<Contributor> contributors) {
         PhysicsConfig config = PhysicsConfig.create();
         config.shapeType = PhysicsConfig.SHAPE_TYPE_CIRCLE;
-        config.fixtureDef.density = 1.0f;
-        config.fixtureDef.restitution = 1.0f;
         int x = 0;
         int y = 0;
         int imageSize = getResources().getDimensionPixelSize(R.dimen.circle_size);

app/src/main/java/com/commit451/gitlab/navigation/BrowserFallback.java

@@ -5,27 +5,34 @@ import android.content.Intent;
 import android.net.Uri;
 import android.widget.Toast;
-import com.commit451.gitlab.R;import com.novoda.simplechromecustomtabs.navigation.NavigationFallback;
+import com.commit451.gitlab.R;
+import com.novoda.simplechromecustomtabs.navigation.NavigationFallback;
+
+import java.lang.ref.WeakReference;
 /**
  * A fallback to open the url in the browser
  */
 public class BrowserFallback implements NavigationFallback {
-    private Context mContext;
+    private WeakReference<Context> mContext;
     public BrowserFallback(Context context) {
-        mContext = context;
+        mContext = new WeakReference<>(context);
     }
     @Override
     public void onFallbackNavigateTo(Uri url) {
         Intent i = new Intent(Intent.ACTION_VIEW);
         i.setData(url);
+        Context context = mContext.get();
+        if (context == null) {
+            return;
+        }
         try {
-            mContext.startActivity(i);
+            context.startActivity(i);
         } catch (Exception e) {
-            Toast.makeText(mContext, R.string.error_no_browser, Toast.LENGTH_SHORT)
+            Toast.makeText(context, R.string.error_no_browser, Toast.LENGTH_SHORT)
                     .show();
         }
     }

app/src/main/java/com/commit451/gitlab/navigation/LabCoatIntentCustomizer.java

@@ -6,24 +6,30 @@ import com.commit451.gitlab.R;
 import com.novoda.simplechromecustomtabs.navigation.IntentCustomizer;
 import com.novoda.simplechromecustomtabs.navigation.SimpleChromeCustomTabsIntentBuilder;
+import java.lang.ref.WeakReference;
+
 /**
  * Customize custom intents
  */
 public class LabCoatIntentCustomizer implements IntentCustomizer {
-    private Activity mActivity;
+    private WeakReference<Activity> mActivity;
     private int mToolbarColor;
     public LabCoatIntentCustomizer(Activity activity, int toolbarColor) {
-        mActivity = activity;
+        mActivity = new WeakReference<>(activity);
         mToolbarColor = toolbarColor;
     }
     @Override
     public SimpleChromeCustomTabsIntentBuilder onCustomiseIntent(SimpleChromeCustomTabsIntentBuilder simpleChromeCustomTabsIntentBuilder) {
+        Activity activity = mActivity.get();
+        if (activity == null) {
+            return simpleChromeCustomTabsIntentBuilder;
+        }
         return simpleChromeCustomTabsIntentBuilder
-                .withStartAnimations(mActivity, R.anim.fade_in, R.anim.do_nothing)
-                .withExitAnimations(mActivity, R.anim.do_nothing, R.anim.fade_out)
+                .withStartAnimations(activity, R.anim.fade_in, R.anim.do_nothing)
+                .withExitAnimations(activity, R.anim.do_nothing, R.anim.fade_out)
                 .withToolbarColor(mToolbarColor);
     }
 }