Fix bug in add user activity

app/src/main/java/com/commit451/gitlab/activity/AddUserActivity.java

@@ -111,7 +111,7 @@ public class AddUserActivity extends MorphActivity {
         return true;
     }
-    @OnTextChanged
+    @OnTextChanged(R.id.search)
     void onTextChanged(CharSequence s, int start, int before, int count) {
         if (TextUtils.isEmpty(s)) {
             buttonClear.animate()

app/src/main/java/com/commit451/gitlab/activity/BuildActivity.java

@@ -68,7 +68,7 @@ public class BuildActivity extends BaseActivity {
     Project project;
     Build build;
-    private final Toolbar.OnMenuItemClickListener mOnMenuItemClickListener = new Toolbar.OnMenuItemClickListener() {
+    private final Toolbar.OnMenuItemClickListener onMenuItemClickListener = new Toolbar.OnMenuItemClickListener() {
         @Override
         public boolean onMenuItemClick(MenuItem item) {
             switch (item.getItemId()) {
@@ -174,7 +174,7 @@ public class BuildActivity extends BaseActivity {
         });
         toolbar.setSubtitle(project.getNameWithNamespace());
         toolbar.inflateMenu(R.menu.menu_build);
-        toolbar.setOnMenuItemClickListener(mOnMenuItemClickListener);
+        toolbar.setOnMenuItemClickListener(onMenuItemClickListener);
         menuItemDownload = toolbar.getMenu().findItem(R.id.action_download);
         menuItemDownload.setVisible(build.getArtifactsFile() != null);
         setupTabs();

app/src/main/java/com/commit451/gitlab/navigation/Navigator.java

@@ -234,7 +234,7 @@ public class Navigator {
     public static void navigateToEditMilestone(Activity activity, View fab, Project project, Milestone milestone) {
         Intent intent = AddMilestoneActivity.newIntent(activity, project.getId(), milestone);
-        startMorphActivity(activity, fab, R.drawable.ic_edit_24dp, intent);
+        activity.startActivity(intent);
     }
     public static void navigateToBuild(Activity activity, Project project, com.commit451.gitlab.model.api.Build build) {

app/src/main/java/com/commit451/gitlab/widget/FeedRemoteViewsFactory.java

@@ -141,7 +141,6 @@ public class FeedRemoteViewsFactory implements RemoteViewsService.RemoteViewsFac
             if (feed.getEntries() != null) {
                 entries.addAll(feed.getEntries());
             }
-
         } catch (Exception e) {
             //maybe let the user know somehow?
             Timber.e(e);

app/src/main/res/layout/activity_about.xml

 <?xml version="1.0" encoding="utf-8"?>
-<FrameLayout
-    xmlns:android="http://schemas.android.com/apk/res/android"
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:id="@+id/root"
     android:layout_width="match_parent"
@@ -19,7 +18,7 @@
             <android.support.v7.widget.Toolbar
                 android:id="@+id/toolbar"
                 android:layout_width="match_parent"
-                android:layout_height="?attr/actionBarSize"/>
+                android:layout_height="?attr/actionBarSize" />
         </android.support.design.widget.AppBarLayout>
@@ -31,7 +30,7 @@
             android:gravity="center"
             android:padding="@dimen/padding_normal"
             android:text="@string/contributors"
-            android:textSize="22sp"/>
+            android:textSize="22sp" />
         <com.commit451.gitlab.view.PhysicsFlowLayout
             android:id="@+id/physics_layout"
@@ -40,36 +39,39 @@
             android:layout_weight="1"
             app:fling="true"
             app:gravityX="0"
-            app:gravityY="0"/>
+            app:gravityY="0" />
         <LinearLayout
             android:id="@+id/sauce"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="center_horizontal"
-            android:background="?attr/selectableItemBackgroundBorderless"
-            android:orientation="horizontal">
+            android:layout_marginBottom="8dp"
+            android:background="?attr/selectableItemBackground"
+            android:orientation="horizontal"
+            android:paddingLeft="@dimen/activity_horizontal_margin"
+            android:paddingRight="@dimen/activity_horizontal_margin">
             <ImageView
                 android:layout_width="48dp"
                 android:layout_height="48dp"
                 android:layout_gravity="center_vertical"
+                android:layout_marginRight="8dp"
                 android:contentDescription="@null"
-                android:src="@drawable/ic_logo"/>
+                android:src="@drawable/ic_logo" />
             <TextView
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_gravity="center_vertical"
                 android:gravity="center"
-                android:padding="@dimen/activity_horizontal_margin"
                 android:text="@string/sauce"
-                android:textSize="22sp"/>
+                android:textSize="22sp" />
         </LinearLayout>
     </LinearLayout>
-    <include layout="@layout/progress"/>
+    <include layout="@layout/progress" />
 </FrameLayout>
\ No newline at end of file

app/src/main/res/layout/activity_feed_widget_configure.xml

 <?xml version="1.0" encoding="utf-8"?>
-<LinearLayout
-    xmlns:android="http://schemas.android.com/apk/res/android"
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:id="@+id/root"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
@@ -25,18 +24,17 @@
         <android.support.v7.widget.RecyclerView
             android:id="@+id/list"
             android:layout_width="match_parent"
-            android:layout_height="match_parent"
-            />
+            android:layout_height="match_parent" />
         <TextView
             android:id="@+id/message_text"
             android:layout_width="match_parent"
             android:layout_height="match_parent"
+            android:layout_gravity="center"
             android:layout_margin="16dp"
-            android:text="@string/widget_config_no_accounts"
             android:gravity="center"
-            android:layout_gravity="center"
-            android:visibility="gone"/>
+            android:text="@string/widget_config_no_accounts"
+            android:visibility="gone" />
     </FrameLayout>

app/src/main/res/layout/activity_milestone.xml

@@ -21,6 +21,10 @@
             android:layout_width="match_parent"
             android:layout_height="?attr/actionBarSize" />
+        <!--Hack for the fact that if there is not a view here, then the fab will disappear-->
+        <View
+            android:layout_width="match_parent"
+            android:layout_height="0dp"/>
     </android.support.design.widget.AppBarLayout>
     <com.commit451.gitlab.view.LabCoatSwipeRefreshLayout

app/src/main/res/layout/activity_project_feed_widget_configure.xml

@@ -20,6 +20,7 @@
     <android.support.v4.view.ViewPager
         android:id="@+id/pager"
         android:layout_width="match_parent"
-        android:layout_height="match_parent" />
+        android:layout_height="match_parent"
+        app:layout_behavior="@string/appbar_scrolling_view_behavior" />
 </android.support.design.widget.CoordinatorLayout>

app/src/main/res/layout/fragment_build_log.xml

 <?xml version="1.0" encoding="utf-8"?>
-<FrameLayout
-    xmlns:android="http://schemas.android.com/apk/res/android"
+<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     android:layout_width="match_parent"
     android:layout_height="match_parent">
@@ -11,16 +10,17 @@
         <android.support.v4.widget.NestedScrollView
             android:layout_width="match_parent"
-            android:layout_height="match_parent">
+            android:layout_height="match_parent"
+            android:scrollbars="vertical">
             <TextView
                 android:id="@+id/log"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
-                android:layout_marginTop="@dimen/activity_vertical_margin"
                 android:layout_marginBottom="@dimen/activity_vertical_margin"
                 android:layout_marginLeft="@dimen/activity_horizontal_margin"
-                android:layout_marginRight="@dimen/activity_horizontal_margin"/>
+                android:layout_marginRight="@dimen/activity_horizontal_margin"
+                android:layout_marginTop="@dimen/activity_vertical_margin" />
         </android.support.v4.widget.NestedScrollView>
@@ -34,6 +34,6 @@
         android:layout_margin="16dp"
         android:gravity="center"
         android:text="@string/no_log_found"
-        android:visibility="gone"/>
+        android:visibility="gone" />
 </FrameLayout>
\ No newline at end of file