Skip to content
Snippets Groups Projects
Commit bdac2720 authored by John's avatar John
Browse files

RxLifecycle -> Autodispose

parent b11f542f
No related branches found
No related tags found
No related merge requests found
Loading
@@ -12,13 +12,12 @@ import com.commit451.addendum.parceler.getParcelerParcelable
Loading
@@ -12,13 +12,12 @@ import com.commit451.addendum.parceler.getParcelerParcelable
import com.commit451.gitlab.App import com.commit451.gitlab.App
import com.commit451.gitlab.R import com.commit451.gitlab.R
import com.commit451.gitlab.event.PipelineChangedEvent import com.commit451.gitlab.event.PipelineChangedEvent
import com.commit451.gitlab.extension.setup import com.commit451.gitlab.extension.with
import com.commit451.gitlab.model.api.CommitUser import com.commit451.gitlab.model.api.CommitUser
import com.commit451.gitlab.model.api.Pipeline import com.commit451.gitlab.model.api.Pipeline
import com.commit451.gitlab.model.api.Project import com.commit451.gitlab.model.api.Project
import com.commit451.gitlab.rx.CustomSingleObserver import com.commit451.gitlab.rx.CustomSingleObserver
import com.commit451.gitlab.util.DateUtil import com.commit451.gitlab.util.DateUtil
import com.trello.rxlifecycle2.android.FragmentEvent
import org.greenrobot.eventbus.Subscribe import org.greenrobot.eventbus.Subscribe
import org.parceler.Parcels import org.parceler.Parcels
import timber.log.Timber import timber.log.Timber
Loading
@@ -84,7 +83,7 @@ class PipelineJobsFragment : ButterKnifeFragment() {
Loading
@@ -84,7 +83,7 @@ class PipelineJobsFragment : ButterKnifeFragment() {
   
fun load() { fun load() {
App.get().gitLab.getPipeline(project.id, pipeline.id) App.get().gitLab.getPipeline(project.id, pipeline.id)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomSingleObserver<Pipeline>() { .subscribe(object : CustomSingleObserver<Pipeline>() {
   
override fun error(t: Throwable) { override fun error(t: Throwable) {
Loading
Loading
Loading
@@ -21,13 +21,12 @@ import com.commit451.gitlab.adapter.DividerItemDecoration
Loading
@@ -21,13 +21,12 @@ import com.commit451.gitlab.adapter.DividerItemDecoration
import com.commit451.gitlab.adapter.PipelineAdapter import com.commit451.gitlab.adapter.PipelineAdapter
import com.commit451.gitlab.event.PipelineChangedEvent import com.commit451.gitlab.event.PipelineChangedEvent
import com.commit451.gitlab.event.ProjectReloadEvent import com.commit451.gitlab.event.ProjectReloadEvent
import com.commit451.gitlab.extension.setup import com.commit451.gitlab.extension.with
import com.commit451.gitlab.model.api.Pipeline import com.commit451.gitlab.model.api.Pipeline
import com.commit451.gitlab.model.api.Project import com.commit451.gitlab.model.api.Project
import com.commit451.gitlab.navigation.Navigator import com.commit451.gitlab.navigation.Navigator
import com.commit451.gitlab.rx.CustomResponseSingleObserver import com.commit451.gitlab.rx.CustomResponseSingleObserver
import com.commit451.gitlab.util.LinkHeaderParser import com.commit451.gitlab.util.LinkHeaderParser
import com.trello.rxlifecycle2.android.FragmentEvent
import org.greenrobot.eventbus.Subscribe import org.greenrobot.eventbus.Subscribe
import timber.log.Timber import timber.log.Timber
   
Loading
@@ -134,7 +133,7 @@ class PipelinesFragment : ButterKnifeFragment() {
Loading
@@ -134,7 +133,7 @@ class PipelinesFragment : ButterKnifeFragment() {
nextPageUrl = null nextPageUrl = null
loading = true loading = true
App.get().gitLab.getPipelines(project!!.id, scope) App.get().gitLab.getPipelines(project!!.id, scope)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<Pipeline>>() { .subscribe(object : CustomResponseSingleObserver<List<Pipeline>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
@@ -172,7 +171,7 @@ class PipelinesFragment : ButterKnifeFragment() {
Loading
@@ -172,7 +171,7 @@ class PipelinesFragment : ButterKnifeFragment() {
   
Timber.d("loadMore called for %s", nextPageUrl) Timber.d("loadMore called for %s", nextPageUrl)
App.get().gitLab.getPipelines(nextPageUrl!!.toString(), scope) App.get().gitLab.getPipelines(nextPageUrl!!.toString(), scope)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<Pipeline>>() { .subscribe(object : CustomResponseSingleObserver<List<Pipeline>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
Loading
Loading
@@ -21,7 +21,6 @@ import com.commit451.gitlab.navigation.Navigator
Loading
@@ -21,7 +21,6 @@ import com.commit451.gitlab.navigation.Navigator
import com.commit451.gitlab.rx.CustomCompleteObserver import com.commit451.gitlab.rx.CustomCompleteObserver
import com.commit451.gitlab.rx.CustomSingleObserver import com.commit451.gitlab.rx.CustomSingleObserver
import com.commit451.gitlab.util.InternalLinkMovementMethod import com.commit451.gitlab.util.InternalLinkMovementMethod
import com.trello.rxlifecycle2.android.FragmentEvent
import io.reactivex.Single import io.reactivex.Single
import org.greenrobot.eventbus.Subscribe import org.greenrobot.eventbus.Subscribe
import retrofit2.Response import retrofit2.Response
Loading
@@ -76,7 +75,7 @@ class ProjectFragment : ButterKnifeFragment() {
Loading
@@ -76,7 +75,7 @@ class ProjectFragment : ButterKnifeFragment() {
.setNegativeButton(R.string.cancel, null) .setNegativeButton(R.string.cancel, null)
.setPositiveButton(R.string.ok) { _, _ -> .setPositiveButton(R.string.ok) { _, _ ->
App.get().gitLab.forkProject(it.id) App.get().gitLab.forkProject(it.id)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomCompleteObserver() { .subscribe(object : CustomCompleteObserver() {
   
override fun error(t: Throwable) { override fun error(t: Throwable) {
Loading
@@ -98,7 +97,7 @@ class ProjectFragment : ButterKnifeFragment() {
Loading
@@ -98,7 +97,7 @@ class ProjectFragment : ButterKnifeFragment() {
fun onStarClicked() { fun onStarClicked() {
if (project != null) { if (project != null) {
App.get().gitLab.starProject(project!!.id) App.get().gitLab.starProject(project!!.id)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomSingleObserver<Response<Project>>() { .subscribe(object : CustomSingleObserver<Response<Project>>() {
   
override fun error(t: Throwable) { override fun error(t: Throwable) {
Loading
@@ -172,7 +171,7 @@ class ProjectFragment : ButterKnifeFragment() {
Loading
@@ -172,7 +171,7 @@ class ProjectFragment : ButterKnifeFragment() {
} }
Single.just(readmeResult) Single.just(readmeResult)
} }
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomSingleObserver<ReadmeResult>() { .subscribe(object : CustomSingleObserver<ReadmeResult>() {
   
override fun error(t: Throwable) { override fun error(t: Throwable) {
Loading
@@ -230,7 +229,7 @@ class ProjectFragment : ButterKnifeFragment() {
Loading
@@ -230,7 +229,7 @@ class ProjectFragment : ButterKnifeFragment() {
   
fun unstarProject() { fun unstarProject() {
App.get().gitLab.unstarProject(project!!.id) App.get().gitLab.unstarProject(project!!.id)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomSingleObserver<Project>() { .subscribe(object : CustomSingleObserver<Project>() {
   
override fun error(t: Throwable) { override fun error(t: Throwable) {
Loading
Loading
Loading
@@ -21,7 +21,7 @@ import com.commit451.gitlab.dialog.AccessDialog
Loading
@@ -21,7 +21,7 @@ import com.commit451.gitlab.dialog.AccessDialog
import com.commit451.gitlab.event.MemberAddedEvent import com.commit451.gitlab.event.MemberAddedEvent
import com.commit451.gitlab.event.ProjectReloadEvent import com.commit451.gitlab.event.ProjectReloadEvent
import com.commit451.gitlab.extension.belongsToGroup import com.commit451.gitlab.extension.belongsToGroup
import com.commit451.gitlab.extension.setup import com.commit451.gitlab.extension.with
import com.commit451.gitlab.model.api.Project import com.commit451.gitlab.model.api.Project
import com.commit451.gitlab.model.api.User import com.commit451.gitlab.model.api.User
import com.commit451.gitlab.navigation.Navigator import com.commit451.gitlab.navigation.Navigator
Loading
@@ -29,7 +29,6 @@ import com.commit451.gitlab.rx.CustomCompleteObserver
Loading
@@ -29,7 +29,6 @@ import com.commit451.gitlab.rx.CustomCompleteObserver
import com.commit451.gitlab.rx.CustomResponseSingleObserver import com.commit451.gitlab.rx.CustomResponseSingleObserver
import com.commit451.gitlab.util.LinkHeaderParser import com.commit451.gitlab.util.LinkHeaderParser
import com.commit451.gitlab.viewHolder.ProjectMemberViewHolder import com.commit451.gitlab.viewHolder.ProjectMemberViewHolder
import com.trello.rxlifecycle2.android.FragmentEvent
import io.reactivex.Single import io.reactivex.Single
import org.greenrobot.eventbus.Subscribe import org.greenrobot.eventbus.Subscribe
import retrofit2.Response import retrofit2.Response
Loading
@@ -92,7 +91,7 @@ class ProjectMembersFragment : ButterKnifeFragment() {
Loading
@@ -92,7 +91,7 @@ class ProjectMembersFragment : ButterKnifeFragment() {
override fun onRemoveMember(member: User) { override fun onRemoveMember(member: User) {
this@ProjectMembersFragment.member = member this@ProjectMembersFragment.member = member
App.get().gitLab.removeProjectMember(project!!.id, member.id) App.get().gitLab.removeProjectMember(project!!.id, member.id)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this@ProjectMembersFragment)
.subscribe(object : CustomCompleteObserver() { .subscribe(object : CustomCompleteObserver() {
   
override fun error(t: Throwable) { override fun error(t: Throwable) {
Loading
@@ -180,7 +179,7 @@ class ProjectMembersFragment : ButterKnifeFragment() {
Loading
@@ -180,7 +179,7 @@ class ProjectMembersFragment : ButterKnifeFragment() {
   
fun load(observable: Single<Response<List<User>>>) { fun load(observable: Single<Response<List<User>>>) {
observable observable
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<User>>() { .subscribe(object : CustomResponseSingleObserver<List<User>>() {
   
override fun error(t: Throwable) { override fun error(t: Throwable) {
Loading
Loading
Loading
@@ -18,13 +18,12 @@ import com.commit451.gitlab.R
Loading
@@ -18,13 +18,12 @@ import com.commit451.gitlab.R
import com.commit451.gitlab.adapter.DividerItemDecoration import com.commit451.gitlab.adapter.DividerItemDecoration
import com.commit451.gitlab.adapter.ProjectAdapter import com.commit451.gitlab.adapter.ProjectAdapter
import com.commit451.gitlab.api.GitLabService import com.commit451.gitlab.api.GitLabService
import com.commit451.gitlab.extension.setup import com.commit451.gitlab.extension.with
import com.commit451.gitlab.model.api.Group import com.commit451.gitlab.model.api.Group
import com.commit451.gitlab.model.api.Project import com.commit451.gitlab.model.api.Project
import com.commit451.gitlab.navigation.Navigator import com.commit451.gitlab.navigation.Navigator
import com.commit451.gitlab.rx.CustomResponseSingleObserver import com.commit451.gitlab.rx.CustomResponseSingleObserver
import com.commit451.gitlab.util.LinkHeaderParser import com.commit451.gitlab.util.LinkHeaderParser
import com.trello.rxlifecycle2.android.FragmentEvent
import io.reactivex.Single import io.reactivex.Single
import retrofit2.Response import retrofit2.Response
import timber.log.Timber import timber.log.Timber
Loading
@@ -169,7 +168,7 @@ class ProjectsFragment : ButterKnifeFragment() {
Loading
@@ -169,7 +168,7 @@ class ProjectsFragment : ButterKnifeFragment() {
   
private fun actuallyLoadIt(observable: Single<Response<List<Project>>>) { private fun actuallyLoadIt(observable: Single<Response<List<Project>>>) {
observable observable
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<Project>>() { .subscribe(object : CustomResponseSingleObserver<List<Project>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
@@ -204,7 +203,7 @@ class ProjectsFragment : ButterKnifeFragment() {
Loading
@@ -204,7 +203,7 @@ class ProjectsFragment : ButterKnifeFragment() {
adapterProjects.setLoading(true) adapterProjects.setLoading(true)
Timber.d("loadMore called for %s", nextPageUrl) Timber.d("loadMore called for %s", nextPageUrl)
getGitLab().getProjects(nextPageUrl!!.toString()) getGitLab().getProjects(nextPageUrl!!.toString())
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<Project>>() { .subscribe(object : CustomResponseSingleObserver<List<Project>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
Loading
Loading
@@ -21,13 +21,12 @@ import com.commit451.gitlab.activity.ProjectActivity
Loading
@@ -21,13 +21,12 @@ import com.commit451.gitlab.activity.ProjectActivity
import com.commit451.gitlab.adapter.DividerItemDecoration import com.commit451.gitlab.adapter.DividerItemDecoration
import com.commit451.gitlab.adapter.SnippetAdapter import com.commit451.gitlab.adapter.SnippetAdapter
import com.commit451.gitlab.event.ProjectReloadEvent import com.commit451.gitlab.event.ProjectReloadEvent
import com.commit451.gitlab.extension.setup import com.commit451.gitlab.extension.with
import com.commit451.gitlab.model.api.Project import com.commit451.gitlab.model.api.Project
import com.commit451.gitlab.model.api.Snippet import com.commit451.gitlab.model.api.Snippet
import com.commit451.gitlab.navigation.Navigator import com.commit451.gitlab.navigation.Navigator
import com.commit451.gitlab.rx.CustomResponseSingleObserver import com.commit451.gitlab.rx.CustomResponseSingleObserver
import com.commit451.gitlab.util.LinkHeaderParser import com.commit451.gitlab.util.LinkHeaderParser
import com.trello.rxlifecycle2.android.FragmentEvent
import org.greenrobot.eventbus.Subscribe import org.greenrobot.eventbus.Subscribe
import timber.log.Timber import timber.log.Timber
   
Loading
@@ -141,7 +140,7 @@ class SnippetsFragment : ButterKnifeFragment() {
Loading
@@ -141,7 +140,7 @@ class SnippetsFragment : ButterKnifeFragment() {
nextPageUrl = null nextPageUrl = null
loading = true loading = true
App.get().gitLab.getSnippets(project!!.id) App.get().gitLab.getSnippets(project!!.id)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<Snippet>>() { .subscribe(object : CustomResponseSingleObserver<List<Snippet>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
@@ -182,7 +181,7 @@ class SnippetsFragment : ButterKnifeFragment() {
Loading
@@ -182,7 +181,7 @@ class SnippetsFragment : ButterKnifeFragment() {
   
Timber.d("loadMore called for %s", nextPageUrl) Timber.d("loadMore called for %s", nextPageUrl)
App.get().gitLab.getSnippets(nextPageUrl!!.toString()) App.get().gitLab.getSnippets(nextPageUrl!!.toString())
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<Snippet>>() { .subscribe(object : CustomResponseSingleObserver<List<Snippet>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
Loading
Loading
@@ -14,12 +14,11 @@ import butterknife.BindView
Loading
@@ -14,12 +14,11 @@ import butterknife.BindView
import com.commit451.gitlab.App import com.commit451.gitlab.App
import com.commit451.gitlab.R import com.commit451.gitlab.R
import com.commit451.gitlab.adapter.TodoAdapter import com.commit451.gitlab.adapter.TodoAdapter
import com.commit451.gitlab.extension.setup import com.commit451.gitlab.extension.with
import com.commit451.gitlab.model.api.Todo import com.commit451.gitlab.model.api.Todo
import com.commit451.gitlab.navigation.Navigator import com.commit451.gitlab.navigation.Navigator
import com.commit451.gitlab.rx.CustomResponseSingleObserver import com.commit451.gitlab.rx.CustomResponseSingleObserver
import com.commit451.gitlab.util.LinkHeaderParser import com.commit451.gitlab.util.LinkHeaderParser
import com.trello.rxlifecycle2.android.FragmentEvent
import io.reactivex.Single import io.reactivex.Single
import retrofit2.Response import retrofit2.Response
import timber.log.Timber import timber.log.Timber
Loading
@@ -121,7 +120,7 @@ class TodoFragment : ButterKnifeFragment() {
Loading
@@ -121,7 +120,7 @@ class TodoFragment : ButterKnifeFragment() {
   
fun getTodos(observable: Single<Response<List<Todo>>>) { fun getTodos(observable: Single<Response<List<Todo>>>) {
observable observable
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<Todo>>() { .subscribe(object : CustomResponseSingleObserver<List<Todo>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
@@ -161,7 +160,7 @@ class TodoFragment : ButterKnifeFragment() {
Loading
@@ -161,7 +160,7 @@ class TodoFragment : ButterKnifeFragment() {
adapterTodos.setLoading(true) adapterTodos.setLoading(true)
Timber.d("loadMore called for " + nextPageUrl!!) Timber.d("loadMore called for " + nextPageUrl!!)
App.get().gitLab.getTodosByUrl(nextPageUrl!!.toString()) App.get().gitLab.getTodosByUrl(nextPageUrl!!.toString())
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<Todo>>() { .subscribe(object : CustomResponseSingleObserver<List<Todo>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
Loading
Loading
@@ -13,13 +13,12 @@ import butterknife.BindView
Loading
@@ -13,13 +13,12 @@ import butterknife.BindView
import com.commit451.gitlab.App import com.commit451.gitlab.App
import com.commit451.gitlab.R import com.commit451.gitlab.R
import com.commit451.gitlab.adapter.UserAdapter import com.commit451.gitlab.adapter.UserAdapter
import com.commit451.gitlab.extension.setup import com.commit451.gitlab.extension.with
import com.commit451.gitlab.model.api.User import com.commit451.gitlab.model.api.User
import com.commit451.gitlab.navigation.Navigator import com.commit451.gitlab.navigation.Navigator
import com.commit451.gitlab.rx.CustomResponseSingleObserver import com.commit451.gitlab.rx.CustomResponseSingleObserver
import com.commit451.gitlab.util.LinkHeaderParser import com.commit451.gitlab.util.LinkHeaderParser
import com.commit451.gitlab.viewHolder.UserViewHolder import com.commit451.gitlab.viewHolder.UserViewHolder
import com.trello.rxlifecycle2.android.FragmentEvent
import timber.log.Timber import timber.log.Timber
   
class UsersFragment : ButterKnifeFragment() { class UsersFragment : ButterKnifeFragment() {
Loading
@@ -108,7 +107,7 @@ class UsersFragment : ButterKnifeFragment() {
Loading
@@ -108,7 +107,7 @@ class UsersFragment : ButterKnifeFragment() {
swipeRefreshLayout.isRefreshing = true swipeRefreshLayout.isRefreshing = true
   
App.get().gitLab.searchUsers(query!!) App.get().gitLab.searchUsers(query!!)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<User>>() { .subscribe(object : CustomResponseSingleObserver<List<User>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
@@ -138,7 +137,7 @@ class UsersFragment : ButterKnifeFragment() {
Loading
@@ -138,7 +137,7 @@ class UsersFragment : ButterKnifeFragment() {
adapterUser.setLoading(true) adapterUser.setLoading(true)
Timber.d("loadMore called for %s %s", nextPageUrl!!.toString(), query) Timber.d("loadMore called for %s %s", nextPageUrl!!.toString(), query)
App.get().gitLab.searchUsers(nextPageUrl!!.toString(), query!!) App.get().gitLab.searchUsers(nextPageUrl!!.toString(), query!!)
.setup(bindUntilEvent(FragmentEvent.DESTROY_VIEW)) .with(this)
.subscribe(object : CustomResponseSingleObserver<List<User>>() { .subscribe(object : CustomResponseSingleObserver<List<User>>() {
   
override fun error(e: Throwable) { override fun error(e: Throwable) {
Loading
Loading
apply plugin: 'com.github.ben-manes.versions' apply plugin: 'com.github.ben-manes.versions'
apply plugin: 'com.commit451.updatewrapper' apply plugin: 'com.commit451.updatewrapper'
buildscript { buildscript {
ext.kotlinVersion = '1.1.60' ext.kotlinVersion = '1.2.10'
repositories { repositories {
jcenter() jcenter()
maven { url "https://jitpack.io" } maven { url "https://jitpack.io" }
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment