Disconnected at project open

Hi,

I was using LabCoat without problems for several months, and changed phone 3 months ago. I just reinstalled it on my new phone, i u can login successfully ( with credentials, and with token ) When i'm logged, i'm viewing all my projects, but when i try to enter one, i'm redirected to the login page with error "Account credentials are no longer valid, please login again"

I tried on several projects ( public, and private ones ) and all give the same result.

I tried 2 other android apps for gitlab, and i don't have the problem, just on LabCoat.

I don't know what information i can give you to help, i'm using last version of gitlab-ce

Thanks in advance for your help, Julien

This means that you are getting a 401 error when visiting the project page. It may be some issue with permissions of the project, thanks for reporting.

Casually joining in on this issue as I am experiencing exactly the same as @juju951 described. I've been trying a few scenario's and thus far this is my outcome:

• The behaviour occurs regardless of what authentication method is used, whether it being private key, public key, authentication token or the default username/password authentication.
• The behaviour thus far only seems to occur on repositories that are not created by yourself (thus created by others or added/invited as member).
• The behaviour occurs regardless of the userrole assigned to the user in the Members view of GitLab.
• The behaviour occurs regardless of what type of repository (public, private or internal) is used (as stated by @juju951).

Note: The scenario's were tested on a default GitLab environment without any changes to permissions, project settings or any other modification other than the default naming and descriptions.

Hope that this is can be of any help to narrow down the scope of the issue.

Kind regards,
Glenn van Ewijk (Tashla)

added Bug label

Hey @Tashla. I appreciate you looking into this. Is this something you can reproduce every time on a certain GitLab account? Or @juju951 can you confirm that this is 100% reproducible on a certain account?

Hey there @Jawnnypoo,

I've attempted another run at exactly the same scenarios and the outcome was as following:

• The behaviour occurs regardless of what authentication method is used, whether it being private key, public key, authentication token or the default username/password authentication.
• The behaviour occurs regardless of the userrole assigned to the user in the Members view of GitLab.
• The behaviour occurs regardless of what type of repository (public, private or internal) is used (as stated by @juju951).

One change in outcome for the following item:

• The behaviour thus far only seems to occur on repositories that are not created by yourself (thus created by others or added/invited as member). Where the behaviour now also seems to occur on certain repositories created by myself.

Upon the above mentioned outcome I've created an empty repository, added one issue, one member and assigned several labels (spaced and non spaced) to the issue aswell as a milestone but this repository did not show said behaviour.

I've also prompted a colleague to install LabCoat and see whether he experiences the same issues and he appears to already find issues signing into the GitLab environment.

To answer your question directly, yes, I have been able to reproduce said behaviour on the same GitLab account.

mentioned in commit 949dcc87

Hey @Tashla,

we found one issue that is caused by the URL of the gitlab instance containing uppercase letters (Be it because the user entered part of it uppercase or because the server returned a URL with uppercase letters).

I don't know if this is also the cause of your problem but we would appreciate if you would test the attached APK

Thanks a lot for your help already.

You will have to uninstall any already installed version of LabCoat beforehand, because the attached APK is signed with a debug certificate. app-normal-debug.apk

Hey there @michi302,

I've given the supplied APK a spin, thus far I can't seem to find any differences in behaviour. However I've been testing some new scenarios with colleagues and we've been able to assume that it is due to the way the default avatars are loaded from third party environments (not hosted by GitLab).

We've been testing on a clean repository without any customization and by slowly adding more members with different characteristics.

LabCoat for GitLab was able to function properly within the following constraints:

• All users within the repository need to have a valid profile picture that is accessible by LabCoat
• The location where default avatars are retrieved from must be accessible by LabCoat (no auth-walls such as ADFS)

LabCoat for GitLab will start signing out the user with the "Account credentials are no longer valid, please login again" toast:

• A single user within the repository does not have a valid profile picture that is accessible by LabCoat
• The location where the default avatars are retrieved from is not accessible or is hidden behind an auth-wall (such as ADFS)

Hello @Tashla,

thanks a lot for looking into this! I think I know what exactly is causing this now. I'm going to try to reproduce this and will follow up with the result shortly.

mentioned in commit 754e477f

@Tashla

I managed to reproduce your issue when using external avatars that return a 401 error. We simply handled any 401 error as GitLab session got invalid even if the actual request went to a completly different external address. I added a check so that we only handle 401 errors of the GitLab instance itself. I have attached another APK which contains this fix. If you would be so kind and check if it solves your problem?

Thanks

app-normal-debug.apk

@michi302 It appears that the main issue has been resolved with the fix, however now I am experiencing crashes when trying to switch to certain tabs within a repository, thus far the Commits, Builds, Milestones and Issues tabs. The others seem to work without issues. I've tried reading the stacktrace with Android Studio but I can't find or see anything when it crashes.

@Tashla The APK I attached is a debug build so you should be able to select it in the Android Monitor. We log a lot so maybe you can find the exact point it crashes or the last log messages?

@michi302 Been able to catch a fish on the hook:

01-10 13:25:34.291 29764-29764/com.commit451.gitlab E/AndroidRuntime: FATAL EXCEPTION: main Process: com.commit451.gitlab, PID: 29764 kotlin.UninitializedPropertyAccessException: lateinit property scope has not been initialized at com.commit451.gitlab.fragment.BuildsFragment.loadData(BuildsFragment.kt:150) at com.commit451.gitlab.fragment.BuildsFragment.onViewCreated(BuildsFragment.kt:127) at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1315) at android.support.v4.app.FragmentManagerImpl.moveFragmentsToInvisible(FragmentManager.java:2323) at android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2136) at android.support.v4.app.FragmentManagerImpl.optimizeAndExecuteOps(FragmentManager.java:2092) at android.support.v4.app.FragmentManagerImpl.execSingleAction(FragmentManager.java:1969) at android.support.v4.app.BackStackRecord.commitNowAllowingStateLoss(BackStackRecord.java:620) at android.support.v4.app.FragmentPagerAdapter.finishUpdate(FragmentPagerAdapter.java:143) at android.support.v4.view.ViewPager.populate(ViewPager.java:1268) at android.support.v4.view.ViewPager.setCurrentItemInternal(ViewPager.java:668) at android.support.v4.view.ViewPager.setCurrentItemInternal(ViewPager.java:630) at android.support.v4.view.ViewPager.setCurrentItem(ViewPager.java:611) at android.support.design.widget.TabLayout$ViewPagerOnTabSelectedListener.onTabSelected(TabLayout.java:2178) at android.support.design.widget.TabLayout.dispatchTabSelected(TabLayout.java:1155) at android.support.design.widget.TabLayout.selectTab(TabLayout.java:1148) at android.support.design.widget.TabLayout.selectTab(TabLayout.java:1118) at android.support.design.widget.TabLayout$Tab.select(TabLayout.java:1413) at android.support.design.widget.TabLayout$TabView.performClick(TabLayout.java:1523) at android.view.View$PerformClick.run(View.java:22565) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:158) at android.app.ActivityThread.main(ActivityThread.java:7230) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

assigned to @michi302

Argh. Ehm. We are transitioning the project to kotlin atm and the last APK is of the latest dev source code so one can expect some bugs @Jawnnypoo will have to look at this stacktrace.

I'm going to close this bug because your initial problem should be fixed now and it seems like if we found the root cause. You can expect it to be in the next release. If it occurrs again feel free to reopen it. (Same goes to @juju951 - I don't whether you are still reading this, but if you are it would be nice if you could do a quick test to see if it is also fixed for you)

closed

Ah yes, that is most certainly an overlooked issue with transitioning to Kotlin. Thanks for all the help in investigating @Tashla and thanks for reporting @juju951 . Glad to have this one sorted out!