Skip to content
Snippets Groups Projects

Fix for issue #209 - Issue does not update when label is added

Merged Fix for issue #209 - Issue does not update when label is added
1 unresolved thread
Merged username-removed-739592 requested to merge adi.bk/LabCoat:develop into develop
1 unresolved thread
  • Trigger update for labels if necessary after updating issues
  • Trigger update for notes after issue is edited (Required if assignee is changed while editing the issue)
  • Use notifyItemRangeChanged instead of notfiyDatasetChanged for updating notes

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
111 111 }
112 112
113 113 public void updateIssue(Issue issue) {
114 List<String> oldLabels = mIssue.getLabels();
114 115 mIssue = issue;
115 116 notifyItemChanged(0);
  • The primary source of bug was that the index is always 0 for notifyItemChanged however labels is in position 1. We would ideally want to determine if index 0 changed but considering how index 0 displays a lot of information a lot of comparison checks would be required. This shouldn't be issue right now as there are only two indices in the header but as more headers are added, a diff utility might be required that determines what actually changed in the issue object.

  • Please register or sign in to reply
  • I wanted to follow up on this merge request. Would somebody be able to take a look at this?

  • username-removed-96744 Status changed to merged

    Status changed to merged

  • Mentioned in commit 0b8b387b

  • Please register or sign in to reply
    Loading