Resolve "API v4"
Closes #247 (closed)
Merge request reports
Activity
@Jawnnypoo I think I have almost everything finished with the API upgrade. There is just one problem with the
PipelineDescriptionFragment
that causes the app to crash. The error ispipeline.createdAt must not be null
. It doesn't even seem to be requesting the pipeline from the API before it crashes.Once I'm done, this should be well tested since it is a breaking change.
Edited by username-removed-400439The
createdAt
,startedAt
,finishedAt
, anduser
properties are allnull
for some reason. But all the other properties are filled. It seems to be getting basic data from the pipelines list, not pipeline details API.Edited by username-removed-400439It is loading the view before it even gets the data. Then crashes because it doesn't have the data it needs. I don't get why jobs description view is still working... It's nearly identical.
Edited by username-removed-400439added 9 commits
-
1d8a60b5...cd291cdf - 8 commits from branch
develop
- 6cd6f92f - Initial work on API v4. (Take 2)
-
1d8a60b5...cd291cdf - 8 commits from branch
@Jawnnypoo Here is the pipelines crash stack trace. https://gitlab.com/snippets/1664465
Edited by username-removed-400439added 1 commit
- 88a1d920 - Different app id and name for debug version.
- Resolved by username-removed-96744
@Jawnnypoo I think so! Some more testing would be good, though before release.
mentioned in commit 95b835b7