FR: Create preference key to use custom application icon(s)

Our organization would find it useful to customize the application icon for NoMAD to include our company logo.

An application with our logo increases user confidence in the legitimacy of any password prompts, whereas a generic icon may arouse suspicion. Being able to supply in .icns file would be sufficient.

(I love the default icon by the way – just need a different option.)

assigned to @Mactroll

changed milestone to %v. 1.0.3

added Feature Request UI labels

Should be easy enough to implement and something we had always had in mind.

added Ready for Testing label

pref keys:

IconOn IconOff IconOnDark IconOffDark

I get a runtime crash if these keys are set to an invalid location. If the location is valid but the image is not in the right format, NoMAD runs but shows no icon and there doesn't seem to be a way to access it.

This is the line that shows an error when the location is invalid.

If you don't mind me adding, it seems that this key only works with 16x16 icons because it doesn't scale the icons to fit the space. If you use a larger icon, it will take up a ton of space on the menu bar.

Additionally, our art department is having trouble producing an icon that looks good at 16x16.

It might be good to add a way to scale larger icons down. I'm not sure what the menu bar supports but it looks like the apple icons are nicely presented. Maybe they are larger icons scaled down and antialiased properly.

Having the custom icons is a big improvement so thank you for adding this! :)

Nathan

Just as a counter-point – and forgive me for being a contrarian – it shouldn't be the responsibility of the app to produce a suitable icon by scaling the custom art you provide. My original FR was more of a fringe case and was graciously filled; but, I'd rather Joel dedicate time to expanding core functionality than potentially complex manipulation of customized icons.

2¢

I think it's common for an app to scale images to fit the space properly. If it's complicated, feel free to ignore my suggestion.

It's a bit strange as the .icns files usually include several sizes of icons and NoMAD is picking the largest, rather than using the provided 16x16. I had to use a command line icns converter and delete every png in the .icns other than the 16x16 to get it to look fine. It's certainly workable but with a bit more preparation and experimentation than usual.

It'd also be worth catching the runtime error when the icon is not found.

Appreciate all your help Joel!

closed

mentioned in issue #128