Merge branch 'deprecate-non-site-profile-on-demand-dast-scans-238955' into 'master'

Mark RunDASTScan mutation as deprecated

See merge request gitlab-org/gitlab!42544

doc/api/graphql/reference/gitlab_schema.graphql

@@ -10847,7 +10847,7 @@ type Mutation {
   pipelineRetry(input: PipelineRetryInput!): PipelineRetryPayload
   removeAwardEmoji(input: RemoveAwardEmojiInput!): RemoveAwardEmojiPayload @deprecated(reason: "Use awardEmojiRemove. Deprecated in 13.2")
   removeProjectFromSecurityDashboard(input: RemoveProjectFromSecurityDashboardInput!): RemoveProjectFromSecurityDashboardPayload
-  runDastScan(input: RunDASTScanInput!): RunDASTScanPayload
+  runDastScan(input: RunDASTScanInput!): RunDASTScanPayload @deprecated(reason: "Use DastOnDemandScanCreate. Deprecated in 13.4")
   todoMarkDone(input: TodoMarkDoneInput!): TodoMarkDonePayload
   todoRestore(input: TodoRestoreInput!): TodoRestorePayload
   todoRestoreMany(input: TodoRestoreManyInput!): TodoRestoreManyPayload

doc/api/graphql/reference/gitlab_schema.json

@@ -31972,8 +31972,8 @@
                 "name": "RunDASTScanPayload",
                 "ofType": null
               },
-              "isDeprecated": false,
-              "deprecationReason": null
+              "isDeprecated": true,
+              "deprecationReason": "Use DastOnDemandScanCreate. Deprecated in 13.4"
             },
             {
               "name": "todoMarkDone",

ee/app/graphql/ee/types/deprecated_mutations.rb

+# frozen_string_literal: true
+
+module EE
+  module Types
+    module DeprecatedMutations
+      extend ActiveSupport::Concern
+
+      prepended do
+        mount_mutation ::Mutations::Pipelines::RunDastScan, deprecated: { reason: 'Use DastOnDemandScanCreate', milestone: '13.4' }
+      end
+    end
+  end
+end

ee/app/graphql/ee/types/mutation_type.rb

@@ -27,7 +27,6 @@ module EE
         mount_mutation ::Mutations::Boards::Lists::UpdateLimitMetrics
         mount_mutation ::Mutations::InstanceSecurityDashboard::AddProject
         mount_mutation ::Mutations::InstanceSecurityDashboard::RemoveProject
-        mount_mutation ::Mutations::Pipelines::RunDastScan
         mount_mutation ::Mutations::DastOnDemandScans::Create
         mount_mutation ::Mutations::DastSiteProfiles::Create
         mount_mutation ::Mutations::DastSiteProfiles::Update
@@ -38,6 +37,8 @@ module EE
         mount_mutation ::Mutations::Security::CiConfiguration::ConfigureSast
         mount_mutation ::Mutations::Namespaces::IncreaseStorageTemporarily
         mount_mutation ::Mutations::QualityManagement::TestCases::Create
+
+        prepend(Types::DeprecatedMutations)
       end
     end
   end

ee/changelogs/unreleased/deprecate-non-site-profile-on-demand-dast-scans-238955.yml

+---
+title: Mark RunDASTScan mutation as deprecated
+merge_request: 42544
+author:
+type: deprecated

ee/spec/graphql/types/mutation_type_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe GitlabSchema.types['Mutation'] do
+  describe 'deprecated mutations' do
+    using RSpec::Parameterized::TableSyntax
+
+    where(:field_name, :reason, :milestone) do
+      'RunDastScan' | 'Use DastOnDemandScanCreate' | '13.4'
+    end
+
+    with_them do
+      let(:field) { get_field(field_name) }
+      let(:deprecation_reason) { "#{reason}. Deprecated in #{milestone}" }
+
+      it { expect(field).to be_present }
+      it { expect(field.deprecation_reason).to eq(deprecation_reason) }
+    end
+  end
+
+  def get_field(name)
+    described_class.fields[GraphqlHelpers.fieldnamerize(name.camelize)]
+  end
+end