Merge branch '33646-eliminate-cycle-analytics-total-stage' into 'master'

Remove Value Stream Total stage

Closes #33646

See merge request gitlab-org/gitlab!42345

spec/lib/gitlab/cycle_analytics/events_spec.rb

@@ -306,48 +306,6 @@ RSpec.describe 'cycle analytics events' do
     end
   end
-  describe '#production_events', :sidekiq_might_not_need_inline do
-    let(:stage) { :production }
-    let!(:context) { create(:issue, project: project, created_at: 2.days.ago) }
-
-    before do
-      merge_merge_requests_closing_issue(user, project, context)
-      deploy_master(user, project)
-    end
-
-    it 'has the total time' do
-      expect(events.first[:total_time]).not_to be_empty
-    end
-
-    it 'has a title' do
-      expect(events.first[:title]).to eq(context.title)
-    end
-
-    it 'has the URL' do
-      expect(events.first[:url]).not_to be_nil
-    end
-
-    it 'has an iid' do
-      expect(events.first[:iid]).to eq(context.iid.to_s)
-    end
-
-    it 'has a created_at timestamp' do
-      expect(events.first[:created_at]).to end_with('ago')
-    end
-
-    it "has the author's URL" do
-      expect(events.first[:author][:web_url]).not_to be_nil
-    end
-
-    it "has the author's avatar URL" do
-      expect(events.first[:author][:avatar_url]).not_to be_nil
-    end
-
-    it "has the author's name" do
-      expect(events.first[:author][:name]).to eq(context.author.name)
-    end
-  end
-
   def setup(context)
     milestone = create(:milestone, project: project)
     context.update(milestone: milestone)

spec/lib/gitlab/cycle_analytics/permissions_spec.rb

@@ -21,10 +21,6 @@ RSpec.describe Gitlab::CycleAnalytics::Permissions do
       expect(subject[:staging]).to eq(false)
     end
-    it 'has no permissions to production stage' do
-      expect(subject[:production]).to eq(false)
-    end
-
     it 'has no permissions to code stage' do
       expect(subject[:code]).to eq(false)
     end
@@ -55,10 +51,6 @@ RSpec.describe Gitlab::CycleAnalytics::Permissions do
       expect(subject[:staging]).to eq(true)
     end
-    it 'has permissions to production stage' do
-      expect(subject[:production]).to eq(true)
-    end
-
     it 'has permissions to code stage' do
       expect(subject[:code]).to eq(true)
     end
@@ -121,9 +113,5 @@ RSpec.describe Gitlab::CycleAnalytics::Permissions do
     it 'has no permissions to issue stage' do
       expect(subject[:issue]).to eq(false)
     end
-
-    it 'has no permissions to production stage' do
-      expect(subject[:production]).to eq(false)
-    end
   end
 end

spec/lib/gitlab/cycle_analytics/production_stage_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe Gitlab::CycleAnalytics::ProductionStage do
-  let(:stage_name) { 'Total' }
-
-  it_behaves_like 'base stage'
-end

spec/models/cycle_analytics/production_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe 'CycleAnalytics#production' do
-  extend CycleAnalyticsHelpers::TestGeneration
-
-  let_it_be(:project) { create(:project, :repository) }
-  let_it_be(:from_date) { 10.days.ago }
-  let_it_be(:user) { project.owner }
-  let_it_be(:project_level) { CycleAnalytics::ProjectLevel.new(project, options: { from: from_date }) }
-
-  subject { project_level }
-
-  generate_cycle_analytics_spec(
-    phase: :production,
-    data_fn: -> (context) { { issue: context.build(:issue, project: context.project) } },
-    start_time_conditions: [["issue is created", -> (context, data) { data[:issue].save! }]],
-    before_end_fn: lambda do |context, data|
-      context.create_merge_request_closing_issue(context.user, context.project, data[:issue])
-      context.merge_merge_requests_closing_issue(context.user, context.project, data[:issue])
-    end,
-    end_time_conditions:
-      [["merge request that closes issue is deployed to production", -> (context, data) { context.deploy_master(context.user, context.project) }],
-       ["production deploy happens after merge request is merged (along with other changes)",
-        lambda do |context, data|
-          # Make other changes on master
-          context.project.repository.commit("sha_that_does_not_matter")
-
-          context.deploy_master(context.user, context.project)
-        end]])
-
-  context "when a regular merge request (that doesn't close the issue) is merged and deployed" do
-    it "returns nil" do
-      merge_request = create(:merge_request)
-      MergeRequests::MergeService.new(project, user).execute(merge_request)
-      deploy_master(user, project)
-
-      expect(subject[:production].project_median).to be_nil
-    end
-  end
-
-  context "when the deployment happens to a non-production environment" do
-    it "returns nil" do
-      issue = build(:issue, project: project)
-      merge_request = create_merge_request_closing_issue(user, project, issue)
-      MergeRequests::MergeService.new(project, user).execute(merge_request)
-      deploy_master(user, project, environment: 'staging')
-
-      expect(subject[:production].project_median).to be_nil
-    end
-  end
-end

spec/requests/projects/cycle_analytics_events_spec.rb

@@ -73,15 +73,6 @@ RSpec.describe 'value stream analytics events' do
       expect(json_response['events'].first['date']).not_to be_empty
     end
-    it 'lists the production events', :sidekiq_might_not_need_inline do
-      get project_cycle_analytics_production_path(project, format: :json)
-
-      first_issue_iid = project.issues.sort_by_attribute(:created_desc).pluck(:iid).first.to_s
-
-      expect(json_response['events']).not_to be_empty
-      expect(json_response['events'].first['iid']).to eq(first_issue_iid)
-    end
-
     context 'specific branch' do
       it 'lists the test events', :sidekiq_might_not_need_inline do
         branch = project.merge_requests.first.source_branch