Skip to content
Snippets Groups Projects
Commit d2ccb045 authored by Scott Stern's avatar Scott Stern
Browse files

Replace underscore with lodash

parent 94308390
No related branches found
No related tags found
No related merge requests found
<script>
import _ from 'underscore';
import { isNumber } from 'lodash';
 
export default {
// name: 'Cell' is a false positive: https://gitlab.com/gitlab-org/frontend/eslint-plugin-i18n/issues/25
Loading
Loading
@@ -24,7 +24,7 @@ export default {
},
computed: {
valueClass() {
return { number: _.isNumber(this.value) };
return { number: isNumber(this.value) };
},
flexClass() {
return { 'flex-grow-1': this.isFlexible };
Loading
Loading
<script>
import _ from 'underscore';
import { mapState, mapActions, mapGetters } from 'vuex';
import { redirectTo } from '~/lib/utils/url_utility';
import Tracking from '~/tracking';
Loading
Loading
@@ -111,7 +110,7 @@ export default {
const { selector, text, placement } = this.actionPopover;
 
// immediately show the action popover if there's not helpContent for this step
const showPopover = !this.helpContent && !_.isUndefined(selector);
const showPopover = !this.helpContent && selector !== undefined;
 
actionPopoverUtils.renderPopover(selector, text, placement, showPopover);
}
Loading
Loading
@@ -161,7 +160,7 @@ export default {
}
 
// dismiss popover if necessary
if (_.isUndefined(dismissPopover) || dismissPopover === true) {
if (dismissPopover === undefined || dismissPopover === true) {
this.dismissPopover = true;
}
 
Loading
Loading
@@ -172,7 +171,7 @@ export default {
}
 
// switch to the next tour part
if (!_.isUndefined(nextPart)) {
if (nextPart !== undefined) {
this.switchTourPart(nextPart);
this.initActionPopover();
return;
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment