Skip to content
Snippets Groups Projects
Commit dbfa39ca authored by Phil Hughes's avatar Phil Hughes
Browse files

Merge branch 'ee-32452-multiple-discussions' into 'master'

Resolve "Multiple discussions per line in merge request diffs"

See merge request gitlab-org/gitlab-ee!14490
parents ba40db50 22abdec4
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -171,8 +171,6 @@ describe 'Merge request > Batch comments', :js do
expect(page).to have_content('1/1 thread resolved')
expect(page).to have_selector('.line-resolve-btn.is-active')
end
expect_empty_local_draft
end
end
 
Loading
Loading
@@ -216,8 +214,6 @@ describe 'Merge request > Batch comments', :js do
expect(page).to have_content('0/1 thread resolved')
expect(page).to have_selector('.line-resolve-btn.is-disabled')
end
expect_empty_local_draft
end
end
end
Loading
Loading
@@ -253,7 +249,7 @@ describe 'Merge request > Batch comments', :js do
end
 
def write_reply_to_discussion(button_text: 'Start a review', text: 'Line is wrong', resolve: false, unresolve: false)
page.within('.discussion-reply-holder') do
page.within(first('.diff-files-holder .discussion-reply-holder')) do
click_button('Reply...')
 
fill_in('note_note', with: text)
Loading
Loading
@@ -271,10 +267,3 @@ def write_reply_to_discussion(button_text: 'Start a review', text: 'Line is wron
 
wait_for_requests
end
def expect_empty_local_draft
page.within('.discussion-reply-holder') do
click_button('Reply...')
expect(find('#note_note').value).to eq('')
end
end
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment