Skip to content
Snippets Groups Projects

Make class accessors (static or not) configurable, per spec.

Closed username-removed-281802 requested to merge trusktr/buble:master into master

This fixes #210.

But the tests don't pass because of some problem with a dependency not exporting a symbol, and I am also not able to run it to test it myself because the dependency problem.

@Rich-Harris It'd be great if you could take a look. Not sure what to do about the dependency issue.

Thanks!

  • Joe
Edited by username-removed-281802

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • The build error I'm getting is

    Module /home/trusktr/src/trusktr+buble/node_modules/vlq/dist/vlq.js does not export encode (imported by /home/trusktr/src/trusktr+buble/node_modules/magic-string/dist/magic-string.es6.js)
    Error: Module /home/trusktr/src/trusktr+buble/node_modules/vlq/dist/vlq.js does not export encode (imported by /home/trusktr/src/trusktr+buble/node_modules/magic-string/dist/magic-string.es6.js)
        at Module.trace (/home/trusktr/src/trusktr+buble/node_modules/rollup/src/Module.js:652:30)
        at /home/trusktr/src/trusktr+buble/node_modules/rollup/src/Module.js:261:30
        at Array.forEach (native)
        at /home/trusktr/src/trusktr+buble/node_modules/rollup/src/Module.js:259:25
        at Array.forEach (native)
        at Module.bindReferences (/home/trusktr/src/trusktr+buble/node_modules/rollup/src/Module.js:252:19)
        at /home/trusktr/src/trusktr+buble/node_modules/rollup/src/Bundle.js:96:44
        at Array.forEach (native)
        at /home/trusktr/src/trusktr+buble/node_modules/rollup/src/Bundle.js:96:18
        at tryCatch (/home/trusktr/src/trusktr+buble/node_modules/rollup/node_modules/es6-promise/lib/es6-promise/-internal.js:187:12)
  • mentioned in issue #210

  • I can confirm that if I make the changes inside node_modules, so that I can skip having to deal with the dependency issue, it works great!

  • username-removed-281802 changed the description

    changed the description

  • username-removed-281802 changed title from Make class accessors (static or not) configurable, like spec. to Make class accessors (static or not) configurable, per spec.

    changed title from Make class accessors (static or not) configurable, like spec. to Make class accessors (static or not) configurable, per spec.

  • The error is caused by a regression in vlq version 0.2.2 which snuck in via dependency version-range.

    If you base your PR on !120 (closed) it goes away.

    Edited by username-removed-1297041
Please register or sign in to reply
Loading