Andreas Brandl authored 4 years ago and Yannis Roussos committed 4 years ago

Relates to
https://gitlab.com/gitlab-org/database-team/team-tasks/-/issues/128

Update link to group-level VSA

See merge request gitlab-org/gitlab!52964

Expose cleanup policies limits and document them

See merge request gitlab-org/gitlab!50858

David Fernandez authored 4 years ago and Jarka Kadlecova committed 4 years ago

Document them properly so that interested self managed
users can try them

Merge branch '229679-migrate-data-toggle-modal-to-glmodal-for-revert-cherry-picking-commits-3' into 'master'

[MR Page] Migrate to GlModal for revert MR

See merge request gitlab-org/gitlab!52019

Fixes GraphQl merge request types commits count

See merge request gitlab-org/gitlab!52218

Geo: Remove wrong tier from a doc heading

See merge request gitlab-org/gitlab!52925

Remove wait_for_loading duplicate method

See merge request gitlab-org/gitlab!52986

Sort imports by groups in CE specs

See merge request gitlab-org/gitlab!52976

Sort JS imports in the EE specs

See merge request gitlab-org/gitlab!52978

Change color pickers set-color prop to value so it links better with Vue and input standards

See merge request gitlab-org/gitlab!53020

Packages to use composition, not inheritance [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!52131

Fix styleguide links

See merge request gitlab-org/gitlab!52928

Reference the add new component docs in more places

See merge request gitlab-org/gitlab!52934

DJ Mountney authored 4 years ago and Achilleas Pipinellis committed 4 years ago

In order to try and improve its exposure

Fix tier badge code

See merge request gitlab-org/gitlab!52963

Add 404 state to container registry details page

See merge request gitlab-org/gitlab!52466

Nicolò Mezzopera authored 4 years ago and Enrique Alcántara committed 4 years ago

- rename
- add image related messages
- tests

Merge branch '300557-follow-up-from-add-click-tracking-to-in-product-marketing-email-campaigns' into 'master'

Resolve "Follow-up from "Add click tracking to in product marketing email campaigns""

See merge request gitlab-org/gitlab!53029

- follow pajamas design setup.

Sort imports orders by groups

See merge request gitlab-org/gitlab!47612

Vitaly Slobodin authored 4 years ago and Natalia Tepluhina committed 4 years ago

Sort JavaScript imports in the CE code
to match our future ESLint configuration.

GraphQL does not have inheritance, so it is an anti-pattern to use
it to model polymorphism in our models.

The correct approach is to model polymorphism as implementation of
interfaces. Here there is a single `PackageType` interface, and
then different implementations of that.

Since the package types only differ in their metadata, we move the
polymorphism down to the metadata fields, which an empty interface,
implemented by metadata types.

One thing that had to change was the `Query.package` field,
which was previously `Query.package_composer_details`. This must change
since the implementation of the lookup does not perform any type
checking, and thus we cannot type the return value as a composer
package. This would be an illegal and ill-typed down-cast. A good
analogy for this is having a Java collection of

```java
// yes, Cucumbers are fruits - look it up
List<Fruit> bowl = List.of(new Apple(), new Banana(), new Cucumber())
```

And then expecting to get an apple without a cast:

```java
Apple fruit = bowl.get(0) // bad
```

This code would fail to compile in Java, and it is equally illegal
in GraphQL, without the appropriate casting.

We mark the composer metadata type as an orphan since it is only refered
to as an implementation of the broader metadata type.

We also split the type of packages into a top-level one, which is able
to refer to versions, and a leaf node which may not. This prevents
unbounded mutual cyclic recursion.

Return successfully for all packages

We can gradually add more specific package types, but it is important
to always succeed with the data we can return.

Fix border bottom color collapsed replies

See merge request gitlab-org/gitlab!51871

Merge branch '299462-create-issue-from-vulnerability-details-edited-text-is-discarded' into 'master'

Do not overwrite fields that are populated

See merge request gitlab-org/gitlab!52376

Add attributions for repository push flag definition

See merge request gitlab-org/gitlab!52399

Dan Jensen authored 4 years ago and Heinrich Lee Yu committed 4 years ago

This adds MR, issue, milestone and group details to the definition for
the repository_push_audit_event feature flag.

Update Gitaly version

See merge request gitlab-org/gitlab!53027

Add the Manage::Import total GMAU metric

See merge request gitlab-org/gitlab!51496

Introduce shared matcher for Snowplow tracking

Add click tracking to in product marketing email campaigns

See merge request gitlab-org/gitlab!52723

Use mock-apollo-provider in SAST UI tests

See merge request gitlab-org/gitlab!52897

Using mock-apollo-provider results in a more realistic test, since the
internals of the component(s) (i.e., `data`) aren't manipulated by the
test suite.

This change also removed an unnecessary use of `localVue` in a related
test suite, and moved the SAST spec helpers up a level in the tree.

Addresses https://gitlab.com/gitlab-org/gitlab/-/issues/249556.