Merge branch 'refactor/remove-pages-legacy-storage-tasks' into 'master'

Remove gitlab:pages:migrate_legacy_storage and gitlab:pages:clean_migrated_zip_storage rake tasks

See merge request gitlab-org/gitlab!87169

lib/tasks/gitlab/pages.rake

@@ -4,60 +4,6 @@ require 'logger'
 namespace :gitlab do
   namespace :pages do
-    desc "GitLab | Pages | Migrate legacy storage to zip format"
-    task migrate_legacy_storage: :gitlab_environment do
-      logger.info('Starting to migrate legacy pages storage to zip deployments')
-
-      result = ::Pages::MigrateFromLegacyStorageService.new(logger,
-                                                            ignore_invalid_entries: ignore_invalid_entries,
-                                                            mark_projects_as_not_deployed: mark_projects_as_not_deployed)
-                 .execute_with_threads(threads: migration_threads, batch_size: batch_size)
-
-      logger.info("A total of #{result[:migrated] + result[:errored]} projects were processed.")
-      logger.info("- The #{result[:migrated]} projects migrated successfully")
-      logger.info("- The #{result[:errored]} projects failed to be migrated")
-    end
-
-    desc "GitLab | Pages | DANGER: Removes data which was migrated from legacy storage on zip storage. Can be used if some bugs in migration are discovered and migration needs to be restarted from scratch."
-    task clean_migrated_zip_storage: :gitlab_environment do
-      destroyed_deployments = 0
-
-      logger.info("Starting to delete migrated pages deployments")
-
-      ::PagesDeployment.migrated_from_legacy_storage.each_batch(of: batch_size) do |batch|
-        destroyed_deployments += batch.count
-
-        # we need to destroy associated files, so can't use delete_all
-        batch.destroy_all # rubocop: disable Cop/DestroyAll
-
-        logger.info("#{destroyed_deployments} deployments were deleted")
-      end
-    end
-
-    def logger
-      @logger ||= Logger.new($stdout)
-    end
-
-    def migration_threads
-      ENV.fetch('PAGES_MIGRATION_THREADS', '3').to_i
-    end
-
-    def batch_size
-      ENV.fetch('PAGES_MIGRATION_BATCH_SIZE', '10').to_i
-    end
-
-    def ignore_invalid_entries
-      Gitlab::Utils.to_boolean(
-        ENV.fetch('PAGES_MIGRATION_IGNORE_INVALID_ENTRIES', 'false')
-      )
-    end
-
-    def mark_projects_as_not_deployed
-      Gitlab::Utils.to_boolean(
-        ENV.fetch('PAGES_MIGRATION_MARK_PROJECTS_AS_NOT_DEPLOYED', 'false')
-      )
-    end
-
     namespace :deployments do
       task migrate_to_object_storage: :gitlab_environment do
         logger = Logger.new($stdout)

spec/tasks/gitlab/pages_rake_spec.rb

@@ -7,86 +7,6 @@
     Rake.application.rake_require 'tasks/gitlab/pages'
   end
-  describe 'migrate_legacy_storage task' do
-    subject { run_rake_task('gitlab:pages:migrate_legacy_storage') }
-
-    it 'calls migration service' do
-      expect_next_instance_of(::Pages::MigrateFromLegacyStorageService, anything,
-                              ignore_invalid_entries: false,
-                              mark_projects_as_not_deployed: false) do |service|
-        expect(service).to receive(:execute_with_threads).with(threads: 3, batch_size: 10).and_call_original
-      end
-
-      subject
-    end
-
-    it 'uses PAGES_MIGRATION_THREADS environment variable' do
-      stub_env('PAGES_MIGRATION_THREADS', '5')
-
-      expect_next_instance_of(::Pages::MigrateFromLegacyStorageService, anything,
-                              ignore_invalid_entries: false,
-                              mark_projects_as_not_deployed: false) do |service|
-        expect(service).to receive(:execute_with_threads).with(threads: 5, batch_size: 10).and_call_original
-      end
-
-      subject
-    end
-
-    it 'uses PAGES_MIGRATION_BATCH_SIZE environment variable' do
-      stub_env('PAGES_MIGRATION_BATCH_SIZE', '100')
-
-      expect_next_instance_of(::Pages::MigrateFromLegacyStorageService, anything,
-                              ignore_invalid_entries: false,
-                              mark_projects_as_not_deployed: false) do |service|
-        expect(service).to receive(:execute_with_threads).with(threads: 3, batch_size: 100).and_call_original
-      end
-
-      subject
-    end
-
-    it 'uses PAGES_MIGRATION_IGNORE_INVALID_ENTRIES environment variable' do
-      stub_env('PAGES_MIGRATION_IGNORE_INVALID_ENTRIES', 'true')
-
-      expect_next_instance_of(::Pages::MigrateFromLegacyStorageService, anything,
-                              ignore_invalid_entries: true,
-                              mark_projects_as_not_deployed: false) do |service|
-        expect(service).to receive(:execute_with_threads).with(threads: 3, batch_size: 10).and_call_original
-      end
-
-      subject
-    end
-
-    it 'uses PAGES_MIGRATION_MARK_PROJECTS_AS_NOT_DEPLOYED environment variable' do
-      stub_env('PAGES_MIGRATION_MARK_PROJECTS_AS_NOT_DEPLOYED', 'true')
-
-      expect_next_instance_of(::Pages::MigrateFromLegacyStorageService, anything,
-                              ignore_invalid_entries: false,
-                              mark_projects_as_not_deployed: true) do |service|
-        expect(service).to receive(:execute_with_threads).with(threads: 3, batch_size: 10).and_call_original
-      end
-
-      subject
-    end
-  end
-
-  describe 'clean_migrated_zip_storage task' do
-    it 'removes only migrated deployments' do
-      regular_deployment = create(:pages_deployment)
-      migrated_deployment = create(:pages_deployment, :migrated)
-
-      regular_deployment.project.update_pages_deployment!(regular_deployment)
-      migrated_deployment.project.update_pages_deployment!(migrated_deployment)
-
-      expect(PagesDeployment.all).to contain_exactly(regular_deployment, migrated_deployment)
-
-      run_rake_task('gitlab:pages:clean_migrated_zip_storage')
-
-      expect(PagesDeployment.all).to contain_exactly(regular_deployment)
-      expect(PagesDeployment.find_by_id(regular_deployment.id)).not_to be_nil
-      expect(PagesDeployment.find_by_id(migrated_deployment.id)).to be_nil
-    end
-  end
-
   describe 'gitlab:pages:deployments:migrate_to_object_storage' do
     subject { run_rake_task('gitlab:pages:deployments:migrate_to_object_storage') }