Merge branch 'hmuralidhar-use-let-for-fabrication' into 'master'

Refactor to use let! in vulnerability_management_spec

See merge request gitlab-org/gitlab!87984

qa/qa/specs/features/ee/browser_ui/13_secure/vulnerability_management_spec.rb

@@ -9,53 +9,54 @@ module QA
       let(:vuln_name) { "Regular Expression Denial of Service in debug" }
       let(:remediable_vuln_name) { "Authentication bypass via incorrect DOM traversal and canonicalization in saml2-js" }
-      after(:all) do
-        @runner.remove_via_api!
-      end
-
-      before(:all) do
-        @executor = "qa-runner-#{Time.now.to_i}"
-
-        Flow::Login.sign_in
-
-        @project = Resource::Project.fabricate_via_api! do |p|
-          p.name = Runtime::Env.auto_devops_project_name || 'project-with-secure'
+      let!(:project) do
+        Resource::Project.fabricate_via_api! do |p|
+          p.name = 'project-with-secure'
           p.description = 'Project with Secure'
           p.auto_devops_enabled = false
           p.initialize_with_readme = true
         end
-        @runner = Resource::Runner.fabricate! do |runner|
-          runner.project = @project
-          runner.name = @executor
+      end
+      let!(:runner) do
+        Resource::Runner.fabricate! do |runner|
+          runner.project = project
+          runner.name = "runner-for-#{project.name}"
           runner.tags = ['secure_report']
         end
-        @source = Resource::Repository::ProjectPush.fabricate! do |push|
-          push.project = @project
+      end
+      let!(:source_repository) do
+        Resource::Repository::ProjectPush.fabricate! do |push|
+          push.project = project
           push.directory = Pathname
-                               .new(__dir__)
-                               .join('../../../../../ee/fixtures/secure_premade_reports')
+                             .new(__dir__)
+                             .join('../../../../../ee/fixtures/secure_premade_reports')
           push.commit_message = 'Create Secure compatible application to serve premade reports'
           push.branch_name = 'secure-mr'
         end
-        @merge_request = Resource::MergeRequest.fabricate_via_api! do |mr|
-          mr.project = @project
+      end
+      let!(:merge_request) do
+        Resource::MergeRequest.fabricate_via_api! do |mr|
+          mr.project = project
           mr.source_branch = 'secure-mr'
-          mr.target_branch = @project.default_branch
-          mr.source = @source
-          mr.target = @project.default_branch
+          mr.target_branch = project.default_branch
+          mr.source = source_repository
+          mr.target = project.default_branch
           mr.target_new_branch = false
         end
-
-        @project.visit!
-        Flow::Pipeline.wait_for_latest_pipeline(status: 'passed')
       end
       before do
         Flow::Login.sign_in_unless_signed_in
-        @merge_request.visit!
+        project.visit!
+        Flow::Pipeline.wait_for_latest_pipeline(status: 'passed')
+        merge_request.visit!
+      end
+
+      after do
+        runner.remove_via_api!
       end
       it 'can dismiss a vulnerability with a reason', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/348008' do