Remove superfluous tags in RSpec examples

Signed-off-by: Rémy Coutable <remy@rymai.me>

spec/controllers/sent_notifications_controller_spec.rb

 require 'rails_helper'
-describe SentNotificationsController, type: :controller do
+describe SentNotificationsController do
   let(:user) { create(:user) }
   let(:project) { create(:empty_project) }
   let(:sent_notification) { create(:sent_notification, project: project, noteable: issue, recipient: user) }

spec/db/production/settings_spec.rb

 require 'spec_helper'
 require 'rainbow/ext/string'
-describe 'seed production settings', lib: true do
+describe 'seed production settings' do
   include StubENV
   let(:settings_file) { Rails.root.join('db/fixtures/production/010_settings.rb') }
   let(:settings) { Gitlab::CurrentSettings.current_application_settings }

spec/features/abuse_report_spec.rb

 require 'spec_helper'
-feature 'Abuse reports', feature: true do
+feature 'Abuse reports' do
   let(:another_user) { create(:user) }
   before do

spec/features/admin/admin_abuse_reports_spec.rb

 require 'spec_helper'
-describe "Admin::AbuseReports", feature: true, js: true  do
+describe "Admin::AbuseReports", js: true  do
   let(:user) { create(:user) }
   context 'as an admin' do

spec/features/admin/admin_appearance_spec.rb

 require 'spec_helper'
-feature 'Admin Appearance', feature: true do
+feature 'Admin Appearance' do
   let!(:appearance) { create(:appearance) }
   scenario 'Create new appearance' do

spec/features/admin/admin_audit_logs_spec.rb

 require 'spec_helper'
-describe 'Admin::AuditLogs', feature: true, js: true do
+describe 'Admin::AuditLogs', :js do
   include Select2Helper
   let(:user) { create(:user) }

spec/features/admin/admin_broadcast_messages_spec.rb

 require 'spec_helper'
-feature 'Admin Broadcast Messages', feature: true do
+feature 'Admin Broadcast Messages' do
   before do
     sign_in(create(:admin))
     create(:broadcast_message, :expired, message: 'Migration to new server')

spec/features/admin/admin_cohorts_spec.rb

 require 'rails_helper'
-feature 'Admin cohorts page', feature: true do
+feature 'Admin cohorts page' do
   before do
     sign_in(create(:admin))
   end

spec/features/admin/admin_deploy_keys_spec.rb

 require 'spec_helper'
-RSpec.describe 'admin deploy keys', type: :feature do
+RSpec.describe 'admin deploy keys' do
   let!(:deploy_key) { create(:deploy_key, public: true) }
   let!(:another_deploy_key) { create(:another_deploy_key, public: true) }

spec/features/admin/admin_disables_git_access_protocol_spec.rb

 require 'rails_helper'
-feature 'Admin disables Git access protocol', feature: true do
+feature 'Admin disables Git access protocol' do
   include StubENV
   let(:project) { create(:empty_project, :empty_repo) }

spec/features/admin/admin_disables_two_factor_spec.rb

 require 'rails_helper'
-feature 'Admin disables 2FA for a user', feature: true do
+feature 'Admin disables 2FA for a user' do
   scenario 'successfully', js: true do
     sign_in(create(:admin))
     user = create(:user, :two_factor)

spec/features/admin/admin_emails_spec.rb

 require 'spec_helper'
-describe "Admin::Emails", feature: true, js: true do
+describe "Admin::Emails", :js do
   let!(:current_user) { create(:admin) }
   let!(:group) { create(:group) }
   let!(:project) { create(:project, namespace: group) }

spec/features/admin/admin_groups_spec.rb

 require 'spec_helper'
-feature 'Admin Groups', feature: true do
+feature 'Admin Groups' do
   include Select2Helper
   let(:internal) { Gitlab::VisibilityLevel::INTERNAL }

spec/features/admin/admin_health_check_spec.rb

 require 'spec_helper'
-feature "Admin Health Check", feature: true do
+feature "Admin Health Check" do
   include StubENV
   before do

spec/features/admin/admin_hook_logs_spec.rb

 require 'spec_helper'
-feature 'Admin::HookLogs', feature: true do
+feature 'Admin::HookLogs' do
   let(:project) { create(:project) }
   let(:system_hook) { create(:system_hook) }
   let(:hook_log) { create(:web_hook_log, web_hook: system_hook, internal_error_message: 'some error') }

spec/features/admin/admin_hooks_spec.rb

 require 'spec_helper'
-describe 'Admin::Hooks', feature: true do
+describe 'Admin::Hooks' do
   before do
     @project = create(:project)
     sign_in(create(:admin))

spec/features/admin/admin_license_spec.rb

 require 'spec_helper'
-feature "License Admin", feature: true do
+feature "License Admin" do
   before do
     sign_in(create(:admin))
   end

spec/features/admin/admin_manage_applications_spec.rb

 require 'spec_helper'
-RSpec.describe 'admin manage applications', feature: true do
+RSpec.describe 'admin manage applications' do
   before do
     sign_in(create(:admin))
   end

spec/features/admin/admin_projects_spec.rb

 require 'spec_helper'
-describe "Admin::Projects", feature: true  do
+describe "Admin::Projects"  do
   include Select2Helper
   let(:user) { create :user }

spec/features/admin/admin_requests_profiles_spec.rb

 require 'spec_helper'
-describe 'Admin::RequestsProfilesController', feature: true do
+describe 'Admin::RequestsProfilesController' do
   before do
     FileUtils.mkdir_p(Gitlab::RequestProfiler::PROFILES_DIR)
     sign_in(create(:admin))