Remove superfluous lib: true, type: redis, service: true, models: true,...

Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true

Signed-off-by: Rémy Coutable <remy@rymai.me>

spec/db/production/settings_spec.rb

 require 'spec_helper'
 require 'rainbow/ext/string'
-describe 'seed production settings', lib: true do
+describe 'seed production settings' do
   include StubENV
   let(:settings_file) { Rails.root.join('db/fixtures/production/010_settings.rb') }
   let(:settings) { Gitlab::CurrentSettings.current_application_settings }

spec/features/issuables/markdown_references_spec.rb

 require 'rails_helper'
-describe 'Markdown References', :feature, :js do
+describe 'Markdown References', :js do
   let(:user)    { create(:user) }
   let(:actual_project) { create(:project, :public) }
   let(:merge_request) { create(:merge_request, target_project: actual_project, source_project: actual_project)}

spec/finders/access_requests_finder_spec.rb

 require 'spec_helper'
-describe AccessRequestsFinder, services: true do
+describe AccessRequestsFinder do
   let(:user) { create(:user) }
   let(:access_requester) { create(:user) }

spec/initializers/6_validations_spec.rb

 require 'spec_helper'
 require_relative '../../config/initializers/6_validations.rb'
-describe '6_validations', lib: true do
+describe '6_validations' do
   before :all do
     FileUtils.mkdir_p('tmp/tests/paths/a/b/c/d')
     FileUtils.mkdir_p('tmp/tests/paths/a/b/c2')

spec/initializers/8_metrics_spec.rb

 require 'spec_helper'
-describe 'instrument_classes', lib: true do
+describe 'instrument_classes' do
   let(:config) { double(:config) }
   let(:unicorn_sampler) { double(:unicorn_sampler) }

spec/initializers/secret_token_spec.rb

 require 'spec_helper'
 require_relative '../../config/initializers/secret_token'
-describe 'create_tokens', lib: true do
+describe 'create_tokens' do
   include StubENV
   let(:secrets) { ActiveSupport::OrderedOptions.new }

spec/initializers/settings_spec.rb

 require 'spec_helper'
 require_relative '../../config/initializers/1_settings'
-describe Settings, lib: true do
+describe Settings do
   describe '#host_without_www' do
     context 'URL with protocol' do
       it 'returns the host' do

spec/initializers/trusted_proxies_spec.rb

 require 'spec_helper'
-describe 'trusted_proxies', lib: true do
+describe 'trusted_proxies' do
   context 'with default config' do
     before do
       set_trusted_proxies([])

spec/lib/banzai/cross_project_reference_spec.rb

 require 'spec_helper'
-describe Banzai::CrossProjectReference, lib: true do
+describe Banzai::CrossProjectReference do
   include described_class
   describe '#project_from_ref' do

spec/lib/banzai/filter/ascii_doc_post_processing_filter_spec.rb

 require 'spec_helper'
-describe Banzai::Filter::AsciiDocPostProcessingFilter, lib: true do
+describe Banzai::Filter::AsciiDocPostProcessingFilter do
   include FilterSpecHelper
   it "adds class for elements with data-math-style" do

spec/lib/banzai/filter/autolink_filter_spec.rb

 require 'spec_helper'
-describe Banzai::Filter::AutolinkFilter, lib: true do
+describe Banzai::Filter::AutolinkFilter do
   include FilterSpecHelper
   let(:link) { 'http://about.gitlab.com/' }

spec/lib/banzai/filter/blockquote_fence_filter_spec.rb

 require 'rails_helper'
-describe Banzai::Filter::BlockquoteFenceFilter, lib: true do
+describe Banzai::Filter::BlockquoteFenceFilter do
   include FilterSpecHelper
   it 'converts blockquote fences to blockquote lines' do

spec/lib/banzai/filter/commit_range_reference_filter_spec.rb

 require 'spec_helper'
-describe Banzai::Filter::CommitRangeReferenceFilter, lib: true do
+describe Banzai::Filter::CommitRangeReferenceFilter do
   include FilterSpecHelper
   let(:project) { create(:project, :public, :repository) }

spec/lib/banzai/filter/commit_reference_filter_spec.rb

 require 'spec_helper'
-describe Banzai::Filter::CommitReferenceFilter, lib: true do
+describe Banzai::Filter::CommitReferenceFilter do
   include FilterSpecHelper
   let(:project) { create(:project, :public, :repository) }

spec/lib/banzai/filter/emoji_filter_spec.rb

 require 'spec_helper'
-describe Banzai::Filter::EmojiFilter, lib: true do
+describe Banzai::Filter::EmojiFilter do
   include FilterSpecHelper
   before do

spec/lib/banzai/filter/external_issue_reference_filter_spec.rb

 require 'spec_helper'
-describe Banzai::Filter::ExternalIssueReferenceFilter, lib: true do
+describe Banzai::Filter::ExternalIssueReferenceFilter do
   include FilterSpecHelper
   def helper

spec/lib/banzai/filter/external_link_filter_spec.rb

@@ -17,7 +17,7 @@
   end
 end
-describe Banzai::Filter::ExternalLinkFilter, lib: true do
+describe Banzai::Filter::ExternalLinkFilter do
   include FilterSpecHelper
   it 'ignores elements without an href attribute' do

spec/lib/banzai/filter/gollum_tags_filter_spec.rb

 require 'spec_helper'
-describe Banzai::Filter::GollumTagsFilter, lib: true do
+describe Banzai::Filter::GollumTagsFilter do
   include FilterSpecHelper
   let(:project) { create(:empty_project) }

spec/lib/banzai/filter/html_entity_filter_spec.rb

 require 'spec_helper'
-describe Banzai::Filter::HtmlEntityFilter, lib: true do
+describe Banzai::Filter::HtmlEntityFilter do
   include FilterSpecHelper
   let(:unescaped) { 'foo <strike attr="foo">&&&</strike>' }

spec/lib/banzai/filter/image_link_filter_spec.rb

 require 'spec_helper'
-describe Banzai::Filter::ImageLinkFilter, lib: true do
+describe Banzai::Filter::ImageLinkFilter do
   include FilterSpecHelper
   def image(path)