Moving log output to rescue block. Add changelog entry

CHANGELOG.md

@@ -8,6 +8,9 @@ omnibus-gitlab repository.
 - Fix the issue that prevents registry from starting when user and group
 are not the same (O Schwede) 62b5cc
+8.17.3
+- Changing call to create tmp dir as the database user 7b54cd76
+
 8.17.0
 - Add support for setting PostgreSQL's synchronous_commit and

files/gitlab-ctl-commands/pg-upgrade.rb

@@ -155,14 +155,14 @@ add_command_under_category 'pg-upgrade', 'database',
         "mkdir -p #{@db_worker.tmp_data_dir}.#{upgrade_version}"
       )
     rescue GitlabCtl::Errors::ExecutionError => ee
+      log "Error creating new directory: #{@db_worker.tmp_data_dir}.#{upgrade_version}"
+      log "STDOUT: #{ee.stdout}"
+      log "STDERR: #{ee.stderr}"
       false
     else
       true
     end
   end
-    log "Error creating new directory: #{@db_worker.tmp_data_dir}.#{upgrade_version}"
-    log "STDOUT: #{ee.stdout}"
-    log "STDERR: #{ee.stderr}"
     die 'Please check the output'
   end