Add specs and changelog for exporter service default update

CHANGELOG.md

@@ -6,6 +6,8 @@ omnibus-gitlab repository.
 9.0.1
 - Allow configuration of prepared statement caching in Rails 169891c2
+- Default redis promethues exporter to off if redis is not managed locally
+- Default postgres promethues exporter to off if postgres is not managed locally
 9.0

spec/chef/recipes/postgres_exporter_spec.rb

@@ -2,11 +2,31 @@ require 'chef_helper'
 describe 'gitlab::postgres-exporter' do
   let(:chef_run) { ChefSpec::SoloRunner.converge('gitlab::default') }
+  let(:node) { chef_run.node }
   before do
     allow(Gitlab).to receive(:[]).and_call_original
   end
+  context 'when postgres is disabled locally' do
+    before do
+      stub_gitlab_rb(
+        postgresql: { enable: false }
+      )
+    end
+
+    it 'defaults the postgres-exporter to being disabled' do
+
+      expect(node['gitlab']['postgres-exporter']['enable']).to eq false
+    end
+
+    it 'allows postgres-exporter to be explicitly enabled' do
+      stub_gitlab_rb(postgres_exporter: { enable: true })
+
+      expect(node['gitlab']['postgres-exporter']['enable']).to eq true
+    end
+  end
+
   context 'when postgres-exporter is enabled' do
     let(:config_template) { chef_run.template('/var/log/gitlab/postgres-exporter/config') }

spec/chef/recipes/redis_exporter_spec.rb

@@ -2,11 +2,31 @@ require 'chef_helper'
 describe 'gitlab::redis-exporter' do
   let(:chef_run) { ChefSpec::SoloRunner.converge('gitlab::default') }
+  let(:node) { chef_run.node }
   before do
     allow(Gitlab).to receive(:[]).and_call_original
   end
+  context 'when redis is disabled locally' do
+    before do
+      stub_gitlab_rb(
+        redis: { enable: false }
+      )
+    end
+
+    it 'defaults the redis-exporter to being disabled' do
+
+      expect(node['gitlab']['redis-exporter']['enable']).to eq false
+    end
+
+    it 'allows redis-exporter to be explicitly enabled' do
+      stub_gitlab_rb(redis_exporter: { enable: true })
+
+      expect(node['gitlab']['redis-exporter']['enable']).to eq true
+    end
+  end
+
   context 'when redis-exporter is enabled' do
     let(:config_template) { chef_run.template('/var/log/gitlab/redis-exporter/config') }