Update `packagecloud_upload.sh` to account for checking the argument count.

*  also fixed white space on L30 for integer math vs string handling. `expr` is used here for older systems that might have an older `bash`.

Cover the case when platform is reported as opensuseleap for pushing packages to package repository.

Fix bash integer math failure on line 30 of `packagecloud_upload.sh`.
Should have caught this on the first go round. Didn't cause breakage
or any other problems but spurious errors during the packagecloud step
of builds.

Document the reason for the for loop around the find command.

We should never have more than one, but let us be prepared for the
possibility.

For verbosity, move the embedded `find` command into a `for` loop, allowing us to specifially outout what files are being pushed to packagecloud, as well as making it more directly legible in the future.

To the readability aspect, I have also renamed the variables in the for
loops from `x` to `distro`, and added `package` vs `y`.

This reverts commit e37eaae5, reversing
changes made to 373609cc.

This reverts commit 54b20bb4, reversing
changes made to 7878d996.

See https://gitlab.com/gitlab-org/gitlab-ce/issues/22838

 for more
information on the reasons why.

Signed-off-by: Rémy Coutable <remy@rymai.me>

We were attempting to match on the wrong data. Use a pattern match vs
`el/` to detect, and not a direct comparison to `el`

Had `sl` instead of `scientific`. Fix that.

Change the Makefile's `packagecloud:` step to call `support/packagecloud_upload.sh`

`packagecloud_upload.sh` then checks the value of `$PACKAGECLOUD_OS` and additionally uploads the packages to the `sl` and `ol` repositories if `"$PACKAGECLOUD_OS" == "el"`

Add output of start/end markers for the `license_check.sh` script, to make it more identifiable in the total output of the `make` calls.

Add `license_check:` to Makefile, and place into `do_release:`, `test:`, and `do_rpi2_release:` steps.
Slight modification to support/license_check.sh, to check the state of `$install_dir/LICENSE` since the `license_check:` step in the Makefile is not directly dependant on the `build:` step due to the omnibus call rebuilding entirely at every call.

Update license_check.sh to check good/bad/unknown for each license.
- Fix some comment language
- Report uknown licenses (not in good or bad lists)
- Add '^$' to badlist.

Add a script to support/ to be called by Makefile, to throw a message when there is a license "not compatible" with our package.

Drop timestamps for nightly builds, and use omnibus BuildVersion to parse the ReleaseVersion for the docker build