Work towards replacing recursive namespace queries with linear queries.
This commit tracks the path to each namespace, and future work will
replace recursive queries with queries that utilize this new column.

Quang-Minh Nguyen authored 4 years ago and Bob Van Landuyt :neckbeard: committed 4 years ago

Issue https://gitlab.com/gitlab-org/gitlab/-/issues/323164

Renamed variables, constants and traits in rspecs

This adds OR filtering of authors for issues, MRs, and epics

As per https://gitlab.com/gitlab-org/gitlab/-/issues/321511 we've seen
one of these tests fail. It seems likely the problem is caused by the
use of `X.days.ago` throughout and then filtering with date ranges. The
likely explanation is that when the test is running just before midnight
then `2.days.ago` actually ends up being "3 days ago" from a date
perspective by the time the assertion is made about it.

Even though it's not easy to replicate this exact failure mode and this
flakiness has never happened for this spec before (to my knowledge) in 3
years it still is not a good way to write these kinds of tests as this
is theoretically a problem.

Instead of making all the times relative to "now" (which changes) I've
just made everything relative to some arbitrary fixed time. This works
fine, without any need for freezing time, as none of the methods being
tested actually refer to the current time.

The test is still quite difficult to read due to many different dates
and times and the fact that the examples are separated from the test
setup but I don't think this change makes it less clear.

When epics are filtered by milestone, this is done through `join` issues
table. If an epic has multiple issues from the same milestone, then
there are duplicit Epic instances returned - we should use distinct list
in this case.

Based on deprecations/ files downloaded from
https://gitlab.com/gitlab-org/gitlab/-/pipelines/220179974

Remove feature flags from specs that no longer exist as
they are debt

On the MR list page, we like to display how many issues were found from
the filtered search query *in total*. However, especially when the
filter includes conditions on the MR title or description, this can be
very expensive to calculate, and involve reading gigabytes of text data
from the database.

As long as the data is already in the page cache, this usually finishes
within the 15-second timeout on GitLab.com, but if the database cache
is cold, a statement timeout is the usual occurrence.

More generally, it's not very clever to spend so much time calculating
a piece of information with marginal value.

This MR applies a shorter limit to the counting statements and provides
for graceful fallback to a '?' value, with a nice tooltip, if the query
times out. This means we're able to view the results in a reasonable
time, rather than the page taking a long time to load, or not loading
at all.

- use cte optimisation for searching by start_date and due_date

Optimized Issuable label search on group and project level.
This change introduces a new way of querying issuable records by label.

* added resolver spec
* minor fixes in the board list servicer and resolver
* added input arguments for issue filtering
* updated the query to get epics

Charlie Ablett authored 4 years ago and Jan Provaznik committed 4 years ago

Added a new epic field to the board type.

This MR fixes the Rails/SaveBang Cop
and removes the files from .rubocop_todo.yml

Add changelog for the cop fixes

Fix failing spec in MR finder spec

-  Use a new method by_milestone in
EpicsFinder to fetch milestone from params
and filter epics that contain issues with
given milestone
- Add milestone_title argument to EpicsResolver
- Add Finder and Resolver specs for filtering by
milestone cases

Update GraphQL schema

Allow filtering by project milestones

Update milestone_title argument description

- Update GraphQL schema

Use hierarchy params to determine milestones

- If include_ancestor_groups or
include_descendant_groups params are present these
groups and their projects will be included in
MilestoneFinder

Add specs for filter by milestones with hierarchy

We allow to add only confidential subepics and issues
to epics which are confidential itself, so this flag
will be used by frontend to get only confidential list
of items.

When showing epics count on group show page, we just
count all epics in the group and its subgroups no matter if
user can see them or not. This is consistent with showing
epic's child counts (where accessibility check is skipped too).

Filter out confidential epics which user has not access to.

When finding epics, first check if user is member of top-level
group, if so there is no need to check al subgroups - we just
assume the user inherits permissions.

The plan for RSpec 4.0 is to disable monkey patching:
https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode

This commit stops using RSpec monkey patching:
https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode

EpicsFinder takes into account epic's confidential attribute
when querying accessible epics.

Alex Ives authored 4 years ago and Mayra Cabrera committed 4 years ago

- Add my_reaction_emoji lookup to epics finder
- Add option to epics api and docs
- Migrated epics_finder_spec to use let_it_be

Relates to https://gitlab.com/gitlab-org/gitlab/issues/7783

This is part of the work to implement confidential epics.

Use EpicsFinder to fetch epics on autocomplete and check
for right permissions when exposing issues epics on API.

Fix epics search query when CTE is enabled

Also add specs and update GraphQL schema

Make EpicsFinder able to search for epics which
start with a partial iid

Constructs a combined where clause which includes all possible
combinations for the given iid start string which would take advantage
of the existing index on epics table.

Use LIKE query for iid search with specialized index

Add index for searching epics by iid and group_id

Remove obsolete scopes and specs

Change changelog entry

https://gitlab.com/gitlab-org/gitlab/issues/27703

Also adds an option to exclude descendant group epics

These are not required because MySQL is not
supported anymore

Brett Walker authored 5 years ago and Nick Thomas committed 5 years ago

and adding  has_issues? to an epic

Prevents access to group resources when user hasn't signed in with SAML
and SSO enforcement is turned on.

Uses the session to track which SAML group the user has signed in with.
This works using global GitLab::Session from the policy via SsoState.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Add controller + services for:
 - setting a parent
 - list epics
 - delete associarion

Epic state uses enum for saving state (other issuables use
string), because of this inconsistency we override `count_key`
which should return state as string converted to symbol
(.e.g. :closed). In rails 5 these integer states are automatically
converted to strings by Active Record.

But if subquery is used (to optimize searching), Active Record doesn't
convert state into string automatically (probably it can not deal with
the more complex query).

This means that epic state can be either integer (if subquery is used)
or string (if AR converted state to string automatically), so in
`count_key` we should convert state into string only if it's an integer.

- add by_state filter to the epics finder
- support count by states