Skip to content
Snippets Groups Projects
Commit a2c032ca authored by Kerri Miller's avatar Kerri Miller
Browse files

Extract #resolve_todos method

parent 94b2edff
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -33,9 +33,7 @@ def handle_changes(merge_request, options)
old_reviewers = old_associations.fetch(:reviewers, [])
changed_fields = merge_request.previous_changes.keys
 
if has_changes?(merge_request, old_labels: old_labels, old_assignees: old_assignees, old_reviewers: old_reviewers)
todo_service.resolve_todos_for_target(merge_request, current_user)
end
resolve_todos(merge_request, old_labels, old_assignees, old_reviewers)
 
if merge_request.previous_changes.include?('title') ||
merge_request.previous_changes.include?('description')
Loading
Loading
@@ -121,6 +119,12 @@ def notify_if_mentions_added(merge_request, old_mentioned_users)
)
end
 
def resolve_todos(merge_request, old_labels, old_assignees, old_reviewers)
return unless has_changes?(merge_request, old_labels: old_labels, old_assignees: old_assignees, old_reviewers: old_reviewers)
todo_service.resolve_todos_for_target(merge_request, current_user)
end
def handle_target_branch_change(merge_request)
return unless merge_request.previous_changes.include?('target_branch')
 
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment