Skip to content
Snippets Groups Projects
Commit c7afdd78 authored by Arturo Herrero's avatar Arturo Herrero
Browse files

RSpec zero monkey patching mode

The plan for RSpec 4.0 is to disable monkey patching:
https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode

This commit stops using RSpec monkey patching in some specs:
https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode
parent 211d5e63
No related branches found
No related tags found
No related merge requests found
Showing
with 20 additions and 20 deletions
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe "Admin Runners" do
RSpec.describe "Admin Runners" do
include StubENV
include FilteredSearchHelpers
include SortingHelper
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe "Admin > Admin sees project statistics" do
RSpec.describe "Admin > Admin sees project statistics" do
let(:current_user) { create(:admin) }
 
before do
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe "Admin > Admin sees projects statistics" do
RSpec.describe "Admin > Admin sees projects statistics" do
let(:current_user) { create(:admin) }
 
before do
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Admin Serverless Domains', :js do
RSpec.describe 'Admin Serverless Domains', :js do
let(:sample_domain) { build(:pages_domain) }
 
before do
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Admin updates settings', :clean_gitlab_redis_shared_state, :do_not_mock_admin_mode do
RSpec.describe 'Admin updates settings', :clean_gitlab_redis_shared_state, :do_not_mock_admin_mode do
include StubENV
include TermsHelper
include UsageDataHelpers
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Admin System Info' do
RSpec.describe 'Admin System Info' do
before do
sign_in(create(:admin))
end
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Admin > Users > Impersonation Tokens', :js do
RSpec.describe 'Admin > Users > Impersonation Tokens', :js do
let(:admin) { create(:admin) }
let!(:user) { create(:user) }
 
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe "Admin::Users" do
RSpec.describe "Admin::Users" do
include Spec::Support::Helpers::Features::ResponsiveTableHelpers
 
let!(:user) do
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Admin uses repository checks', :request_store, :clean_gitlab_redis_shared_state, :do_not_mock_admin_mode do
RSpec.describe 'Admin uses repository checks', :request_store, :clean_gitlab_redis_shared_state, :do_not_mock_admin_mode do
include StubENV
 
let(:admin) { create(:admin) }
Loading
Loading
Loading
Loading
@@ -3,7 +3,7 @@
require 'spec_helper'
require_relative '../../../../spec/features/clusters/installing_applications_shared_examples'
 
describe 'Instance-level Cluster Applications', :js do
RSpec.describe 'Instance-level Cluster Applications', :js do
include GoogleApi::CloudPlatformHelpers
 
let(:user) { create(:admin) }
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Instance-level AWS EKS Cluster', :js do
RSpec.describe 'Instance-level AWS EKS Cluster', :js do
let(:user) { create(:admin) }
 
before do
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'admin visits dashboard' do
RSpec.describe 'admin visits dashboard' do
include ProjectForksHelper
 
before do
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Admin activates Prometheus', :js do
RSpec.describe 'Admin activates Prometheus', :js do
let(:admin) { create(:user, :admin) }
 
before do
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe "Dashboard Issues Feed" do
RSpec.describe "Dashboard Issues Feed" do
describe "GET /issues" do
let!(:user) { create(:user, email: 'private1@example.com', public_email: 'public1@example.com') }
let!(:assignee) { create(:user, email: 'private2@example.com', public_email: 'public2@example.com') }
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe "Dashboard Feed" do
RSpec.describe "Dashboard Feed" do
describe "GET /" do
let!(:user) { create(:user, name: "Jonh") }
 
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Issues Feed' do
RSpec.describe 'Issues Feed' do
describe 'GET /issues' do
let!(:user) { create(:user, email: 'private1@example.com', public_email: 'public1@example.com') }
let!(:assignee) { create(:user, email: 'private2@example.com', public_email: 'public2@example.com') }
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe "User Feed" do
RSpec.describe "User Feed" do
describe "GET /" do
let!(:user) { create(:user) }
 
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Issue Boards add issue modal', :js do
RSpec.describe 'Issue Boards add issue modal', :js do
let(:project) { create(:project, :public) }
let(:board) { create(:board, project: project) }
let(:user) { create(:user) }
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Issue Boards', :js do
RSpec.describe 'Issue Boards', :js do
include DragTo
include MobileHelpers
 
Loading
Loading
Loading
Loading
@@ -2,7 +2,7 @@
 
require 'spec_helper'
 
describe 'Issue Boards focus mode', :js do
RSpec.describe 'Issue Boards focus mode', :js do
let(:project) { create(:project, :public) }
 
before do
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment