Merge branch '362089-remove-redundant-queries' into 'master'

Remove redundant issues list GraphQL queries

See merge request gitlab-org/gitlab!87265

app/assets/javascripts/issues/list/components/issues_list_app.vue

@@ -13,8 +13,6 @@ import fuzzaldrinPlus from 'fuzzaldrin-plus';
 import IssueCardTimeInfo from 'ee_else_ce/issues/list/components/issue_card_time_info.vue';
 import getIssuesQuery from 'ee_else_ce/issues/list/queries/get_issues.query.graphql';
 import getIssuesCountsQuery from 'ee_else_ce/issues/list/queries/get_issues_counts.query.graphql';
-import getIssuesWithoutCrmQuery from 'ee_else_ce/issues/list/queries/get_issues_without_crm.query.graphql';
-import getIssuesCountsWithoutCrmQuery from 'ee_else_ce/issues/list/queries/get_issues_counts_without_crm.query.graphql';
 import createFlash, { FLASH_TYPES } from '~/flash';
 import { TYPE_USER } from '~/graphql_shared/constants';
 import { convertToGraphQLId, getIdFromGraphQLId } from '~/graphql_shared/utils';
@@ -160,9 +158,7 @@ export default {
   },
   apollo: {
     issues: {
-      query() {
-        return this.hasCrmParameter ? getIssuesQuery : getIssuesWithoutCrmQuery;
-      },
+      query: getIssuesQuery,
       variables() {
         return this.queryVariables;
       },
@@ -186,9 +182,7 @@ export default {
       debounce: 200,
     },
     issuesCounts: {
-      query() {
-        return this.hasCrmParameter ? getIssuesCountsQuery : getIssuesCountsWithoutCrmQuery;
-      },
+      query: getIssuesCountsQuery,
       variables() {
         return this.queryVariables;
       },
@@ -403,12 +397,6 @@ export default {
         page_before: this.pageParams.beforeCursor,
       };
     },
-    hasCrmParameter() {
-      return (
-        window.location.search.includes('crm_contact_id=') ||
-        window.location.search.includes('crm_organization_id=')
-      );
-    },
   },
   watch: {
     $route(newValue, oldValue) {

app/assets/javascripts/issues/list/queries/get_issues_counts_without_crm.query.graphql

-query getIssuesCountWithoutCrm(
-  $isProject: Boolean = false
-  $fullPath: ID!
-  $iid: String
-  $search: String
-  $assigneeId: String
-  $assigneeUsernames: [String!]
-  $authorUsername: String
-  $confidential: Boolean
-  $labelName: [String]
-  $milestoneTitle: [String]
-  $milestoneWildcardId: MilestoneWildcardId
-  $myReactionEmoji: String
-  $releaseTag: [String!]
-  $releaseTagWildcardId: ReleaseTagWildcardId
-  $types: [IssueType!]
-  $not: NegatedIssueFilterInput
-) {
-  group(fullPath: $fullPath) @skip(if: $isProject) {
-    id
-    openedIssues: issues(
-      includeSubgroups: true
-      state: opened
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      types: $types
-      not: $not
-    ) {
-      count
-    }
-    closedIssues: issues(
-      includeSubgroups: true
-      state: closed
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      types: $types
-      not: $not
-    ) {
-      count
-    }
-    allIssues: issues(
-      includeSubgroups: true
-      state: all
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      types: $types
-      not: $not
-    ) {
-      count
-    }
-  }
-  project(fullPath: $fullPath) @include(if: $isProject) {
-    id
-    openedIssues: issues(
-      state: opened
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      releaseTag: $releaseTag
-      releaseTagWildcardId: $releaseTagWildcardId
-      types: $types
-      not: $not
-    ) {
-      count
-    }
-    closedIssues: issues(
-      state: closed
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      releaseTag: $releaseTag
-      releaseTagWildcardId: $releaseTagWildcardId
-      types: $types
-      not: $not
-    ) {
-      count
-    }
-    allIssues: issues(
-      state: all
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      releaseTag: $releaseTag
-      releaseTagWildcardId: $releaseTagWildcardId
-      types: $types
-      not: $not
-    ) {
-      count
-    }
-  }
-}

app/assets/javascripts/issues/list/queries/get_issues_without_crm.query.graphql

-#import "~/graphql_shared/fragments/page_info.fragment.graphql"
-#import "./issue.fragment.graphql"
-
-query getIssuesWithoutCrm(
-  $hideUsers: Boolean = false
-  $isProject: Boolean = false
-  $isSignedIn: Boolean = false
-  $fullPath: ID!
-  $iid: String
-  $search: String
-  $sort: IssueSort
-  $state: IssuableState
-  $assigneeId: String
-  $assigneeUsernames: [String!]
-  $authorUsername: String
-  $confidential: Boolean
-  $labelName: [String]
-  $milestoneTitle: [String]
-  $milestoneWildcardId: MilestoneWildcardId
-  $myReactionEmoji: String
-  $releaseTag: [String!]
-  $releaseTagWildcardId: ReleaseTagWildcardId
-  $types: [IssueType!]
-  $not: NegatedIssueFilterInput
-  $beforeCursor: String
-  $afterCursor: String
-  $firstPageSize: Int
-  $lastPageSize: Int
-) {
-  group(fullPath: $fullPath) @skip(if: $isProject) {
-    id
-    issues(
-      includeSubgroups: true
-      iid: $iid
-      search: $search
-      sort: $sort
-      state: $state
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      types: $types
-      not: $not
-      before: $beforeCursor
-      after: $afterCursor
-      first: $firstPageSize
-      last: $lastPageSize
-    ) {
-      pageInfo {
-        ...PageInfo
-      }
-      nodes {
-        ...IssueFragment
-        reference(full: true)
-      }
-    }
-  }
-  project(fullPath: $fullPath) @include(if: $isProject) {
-    id
-    issues(
-      iid: $iid
-      search: $search
-      sort: $sort
-      state: $state
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      releaseTag: $releaseTag
-      releaseTagWildcardId: $releaseTagWildcardId
-      types: $types
-      not: $not
-      before: $beforeCursor
-      after: $afterCursor
-      first: $firstPageSize
-      last: $lastPageSize
-    ) {
-      pageInfo {
-        ...PageInfo
-      }
-      nodes {
-        ...IssueFragment
-      }
-    }
-  }
-}

ee/app/assets/javascripts/issues/list/queries/get_issues_counts_without_crm.query.graphql

-query getIssuesCountWithoutCrmEE(
-  $isProject: Boolean = false
-  $fullPath: ID!
-  $iid: String
-  $search: String
-  $assigneeId: String
-  $assigneeUsernames: [String!]
-  $authorUsername: String
-  $confidential: Boolean
-  $labelName: [String]
-  $milestoneTitle: [String]
-  $milestoneWildcardId: MilestoneWildcardId
-  $myReactionEmoji: String
-  $releaseTag: [String!]
-  $releaseTagWildcardId: ReleaseTagWildcardId
-  $types: [IssueType!]
-  $epicId: String
-  $iterationId: [ID]
-  $iterationWildcardId: IterationWildcardId
-  $weight: String
-  $not: NegatedIssueFilterInput
-) {
-  group(fullPath: $fullPath) @skip(if: $isProject) {
-    id
-    openedIssues: issues(
-      includeSubepics: true
-      includeSubgroups: true
-      state: opened
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      types: $types
-      epicId: $epicId
-      iterationId: $iterationId
-      iterationWildcardId: $iterationWildcardId
-      weight: $weight
-      not: $not
-    ) {
-      count
-    }
-    closedIssues: issues(
-      includeSubepics: true
-      includeSubgroups: true
-      state: closed
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      types: $types
-      epicId: $epicId
-      iterationId: $iterationId
-      iterationWildcardId: $iterationWildcardId
-      weight: $weight
-      not: $not
-    ) {
-      count
-    }
-    allIssues: issues(
-      includeSubepics: true
-      includeSubgroups: true
-      state: all
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      types: $types
-      epicId: $epicId
-      iterationId: $iterationId
-      iterationWildcardId: $iterationWildcardId
-      weight: $weight
-      not: $not
-    ) {
-      count
-    }
-  }
-  project(fullPath: $fullPath) @include(if: $isProject) {
-    id
-    openedIssues: issues(
-      includeSubepics: true
-      state: opened
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      releaseTag: $releaseTag
-      releaseTagWildcardId: $releaseTagWildcardId
-      types: $types
-      epicId: $epicId
-      iterationId: $iterationId
-      iterationWildcardId: $iterationWildcardId
-      weight: $weight
-      not: $not
-    ) {
-      count
-    }
-    closedIssues: issues(
-      includeSubepics: true
-      state: closed
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      releaseTag: $releaseTag
-      releaseTagWildcardId: $releaseTagWildcardId
-      types: $types
-      epicId: $epicId
-      iterationId: $iterationId
-      iterationWildcardId: $iterationWildcardId
-      weight: $weight
-      not: $not
-    ) {
-      count
-    }
-    allIssues: issues(
-      includeSubepics: true
-      state: all
-      iid: $iid
-      search: $search
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      releaseTag: $releaseTag
-      releaseTagWildcardId: $releaseTagWildcardId
-      types: $types
-      epicId: $epicId
-      iterationId: $iterationId
-      iterationWildcardId: $iterationWildcardId
-      weight: $weight
-      not: $not
-    ) {
-      count
-    }
-  }
-}

ee/app/assets/javascripts/issues/list/queries/get_issues_without_crm.query.graphql

-#import "~/graphql_shared/fragments/page_info.fragment.graphql"
-#import "~/issues/list/queries/issue.fragment.graphql"
-
-query getIssuesWithoutCrmEE(
-  $hideUsers: Boolean = false
-  $isProject: Boolean = false
-  $isSignedIn: Boolean = false
-  $fullPath: ID!
-  $iid: String
-  $search: String
-  $sort: IssueSort
-  $state: IssuableState
-  $assigneeId: String
-  $assigneeUsernames: [String!]
-  $authorUsername: String
-  $confidential: Boolean
-  $labelName: [String]
-  $milestoneTitle: [String]
-  $milestoneWildcardId: MilestoneWildcardId
-  $myReactionEmoji: String
-  $releaseTag: [String!]
-  $releaseTagWildcardId: ReleaseTagWildcardId
-  $types: [IssueType!]
-  $epicId: String
-  $iterationId: [ID]
-  $iterationWildcardId: IterationWildcardId
-  $weight: String
-  $not: NegatedIssueFilterInput
-  $beforeCursor: String
-  $afterCursor: String
-  $firstPageSize: Int
-  $lastPageSize: Int
-) {
-  group(fullPath: $fullPath) @skip(if: $isProject) {
-    id
-    issues(
-      includeSubepics: true
-      includeSubgroups: true
-      iid: $iid
-      search: $search
-      sort: $sort
-      state: $state
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      types: $types
-      epicId: $epicId
-      iterationId: $iterationId
-      iterationWildcardId: $iterationWildcardId
-      weight: $weight
-      not: $not
-      before: $beforeCursor
-      after: $afterCursor
-      first: $firstPageSize
-      last: $lastPageSize
-    ) {
-      pageInfo {
-        ...PageInfo
-      }
-      nodes {
-        ...IssueFragment
-        reference(full: true)
-        blockingCount
-        healthStatus
-        weight
-      }
-    }
-  }
-  project(fullPath: $fullPath) @include(if: $isProject) {
-    id
-    issues(
-      includeSubepics: true
-      iid: $iid
-      search: $search
-      sort: $sort
-      state: $state
-      assigneeId: $assigneeId
-      assigneeUsernames: $assigneeUsernames
-      authorUsername: $authorUsername
-      confidential: $confidential
-      labelName: $labelName
-      milestoneTitle: $milestoneTitle
-      milestoneWildcardId: $milestoneWildcardId
-      myReactionEmoji: $myReactionEmoji
-      releaseTag: $releaseTag
-      releaseTagWildcardId: $releaseTagWildcardId
-      types: $types
-      epicId: $epicId
-      iterationId: $iterationId
-      iterationWildcardId: $iterationWildcardId
-      weight: $weight
-      not: $not
-      before: $beforeCursor
-      after: $afterCursor
-      first: $firstPageSize
-      last: $lastPageSize
-    ) {
-      pageInfo {
-        ...PageInfo
-      }
-      nodes {
-        ...IssueFragment
-        blockingCount
-        healthStatus
-        weight
-      }
-    }
-  }
-}

ee/spec/frontend/issues/list/components/issues_list_app_spec.js

@@ -4,8 +4,6 @@ import Vue from 'vue';
 import VueApollo from 'vue-apollo';
 import getIssuesQuery from 'ee_else_ce/issues/list/queries/get_issues.query.graphql';
 import getIssuesCountsQuery from 'ee_else_ce/issues/list/queries/get_issues_counts.query.graphql';
-import getIssuesWithoutCrmQuery from 'ee_else_ce/issues/list/queries/get_issues_without_crm.query.graphql';
-import getIssuesCountsWithoutCrmQuery from 'ee_else_ce/issues/list/queries/get_issues_counts_without_crm.query.graphql';
 import createMockApollo from 'helpers/mock_apollo_helper';
 import waitForPromises from 'helpers/wait_for_promises';
 import { getIssuesCountsQueryResponse, getIssuesQueryResponse } from 'jest/issues/list/mock_data';
@@ -78,8 +76,6 @@ describe('EE IssuesListApp component', () => {
     const requestHandlers = [
       [getIssuesQuery, issuesQueryResponse],
       [getIssuesCountsQuery, issuesCountsQueryResponse],
-      [getIssuesWithoutCrmQuery, issuesQueryResponse],
-      [getIssuesCountsWithoutCrmQuery, issuesCountsQueryResponse],
     ];
     const apolloProvider = createMockApollo(requestHandlers);

spec/frontend/issues/list/components/issues_list_app_spec.js

@@ -8,8 +8,6 @@ import VueApollo from 'vue-apollo';
 import VueRouter from 'vue-router';
 import getIssuesQuery from 'ee_else_ce/issues/list/queries/get_issues.query.graphql';
 import getIssuesCountsQuery from 'ee_else_ce/issues/list/queries/get_issues_counts.query.graphql';
-import getIssuesWithoutCrmQuery from 'ee_else_ce/issues/list/queries/get_issues_without_crm.query.graphql';
-import getIssuesCountsWithoutCrmQuery from 'ee_else_ce/issues/list/queries/get_issues_counts_without_crm.query.graphql';
 import createMockApollo from 'helpers/mock_apollo_helper';
 import setWindowLocation from 'helpers/set_window_location_helper';
 import { TEST_HOST } from 'helpers/test_constants';
@@ -121,8 +119,6 @@ describe('CE IssuesListApp component', () => {
     const requestHandlers = [
       [getIssuesQuery, issuesQueryResponse],
       [getIssuesCountsQuery, issuesCountsQueryResponse],
-      [getIssuesWithoutCrmQuery, issuesQueryResponse],
-      [getIssuesCountsWithoutCrmQuery, issuesCountsQueryResponse],
       [setSortPreferenceMutation, sortPreferenceMutationResponse],
     ];