Revert "Enable Style/DotPosition"

This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.

# Conflicts:
#	.rubocop.yml
#	.rubocop_todo.yml
#	lib/gitlab/ci/config/entry/global.rb
#	lib/gitlab/ci/config/entry/jobs.rb
#	spec/lib/gitlab/ci/config/entry/factory_spec.rb
#	spec/lib/gitlab/ci/config/entry/global_spec.rb
#	spec/lib/gitlab/ci/config/entry/job_spec.rb
#	spec/lib/gitlab/ci/status/build/factory_spec.rb
#	spec/lib/gitlab/incoming_email_spec.rb

.rubocop.yml

@@ -163,11 +163,6 @@ Style/DefWithParentheses:
 Style/Documentation:
   Enabled: false
-# This cop checks the . position in multi-line method calls.
-Style/DotPosition:
-  Enabled: true
-  EnforcedStyle: trailing
-
 # This cop checks for uses of double negation (!!) to convert something
 # to a boolean value. As this is both cryptic and usually redundant, it
 # should be avoided.

.rubocop_todo.yml

@@ -63,7 +63,7 @@ Rails/SkipsModelValidations:
 # Cop supports --auto-correct.
 Security/YAMLLoad:
   Enabled: false
-  
+
 # Offense count: 55
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -71,6 +71,13 @@ Security/YAMLLoad:
 Style/BarePercentLiterals:
   Enabled: false
+# Offense count: 1304
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: leading, trailing
+Style/DotPosition:
+  Enabled: false
+
 # Offense count: 9
 # Cop supports --auto-correct.
 Style/EachWithObject:

app/controllers/admin/application_settings_controller.rb

@@ -5,9 +5,9 @@ def show
   end
   def update
-    successful = ApplicationSettings::UpdateService.
-      new(@application_setting, current_user, application_setting_params).
-      execute
+    successful = ApplicationSettings::UpdateService
+      .new(@application_setting, current_user, application_setting_params)
+      .execute
     if successful
       redirect_to admin_application_settings_path,

app/controllers/concerns/issues_action.rb

@@ -5,9 +5,9 @@ module IssuesAction
   def issues
     @label = issues_finder.labels.first
-    @issues = issues_collection.
-              non_archived.
-              page(params[:page])
+    @issues = issues_collection
+              .non_archived
+              .page(params[:page])
     @collection_type    = "Issue"
     @issuable_meta_data = issuable_meta_data(@issues)

app/controllers/concerns/merge_requests_action.rb

@@ -5,8 +5,8 @@ module MergeRequestsAction
   def merge_requests
     @label = merge_requests_finder.labels.first
-    @merge_requests = merge_requests_collection.
-                      page(params[:page])
+    @merge_requests = merge_requests_collection
+                      .page(params[:page])
     @collection_type    = "MergeRequest"
     @issuable_meta_data = issuable_meta_data(@merge_requests)

app/controllers/import/bitbucket_controller.rb

@@ -29,9 +29,9 @@ def status
   end
   def jobs
-    render json: current_user.created_projects.
-                             where(import_type: 'bitbucket').
-                             to_json(only: [:id, :import_status])
+    render json: current_user.created_projects
+                             .where(import_type: 'bitbucket')
+                             .to_json(only: [:id, :import_status])
   end
   def create

app/controllers/projects/badges_controller.rb

@@ -4,15 +4,15 @@ class Projects::BadgesController < Projects::ApplicationController
   before_action :no_cache_headers, except: [:index]
   def build
-    build_status = Gitlab::Badge::Build::Status.
-      new(project, params[:ref])
+    build_status = Gitlab::Badge::Build::Status
+      .new(project, params[:ref])
     render_badge build_status
   end
   def coverage
-    coverage_report = Gitlab::Badge::Coverage::Report.
-      new(project, params[:ref], params[:job])
+    coverage_report = Gitlab::Badge::Coverage::Report
+      .new(project, params[:ref], params[:job])
     render_badge coverage_report
   end

app/controllers/projects/boards/issues_controller.rb

@@ -40,10 +40,10 @@ def update
       def issue
         @issue ||=
-          IssuesFinder.new(current_user, project_id: project.id).
-                      execute.
-                      where(iid: params[:id]).
-                      first!
+          IssuesFinder.new(current_user, project_id: project.id)
+                      .execute
+                      .where(iid: params[:id])
+                      .first!
       end
       def authorize_read_issue!

app/controllers/projects/commit_controller.rb

@@ -35,9 +35,9 @@ def pipelines
     respond_to do |format|
       format.html
       format.json do
-        render json: PipelineSerializer.
-          new(project: @project, user: @current_user).
-          represent(@pipelines)
+        render json: PipelineSerializer
+          .new(project: @project, user: @current_user)
+          .represent(@pipelines)
       end
     end
   end

app/controllers/projects/compare_controller.rb

@@ -46,8 +46,8 @@ def define_ref_vars
   end
   def define_diff_vars
-    @compare = CompareService.new(@project, @head_ref).
-      execute(@project, @start_ref)
+    @compare = CompareService.new(@project, @head_ref)
+      .execute(@project, @start_ref)
     if @compare
       @commits = @compare.commits

app/controllers/projects/environments_controller.rb

@@ -9,18 +9,18 @@ class Projects::EnvironmentsController < Projects::ApplicationController
   before_action :verify_api_request!, only: :terminal_websocket_authorize
   def index
-    @environments = project.environments.
-      with_state(params[:scope] || :available)
+    @environments = project.environments
+      .with_state(params[:scope] || :available)
     respond_to do |format|
       format.html
       format.json do
         render json: {
-          environments: EnvironmentSerializer.
-            new(project: @project, user: @current_user).
-            with_pagination(request, response).
-            within_folders.
-            represent(@environments),
+          environments: EnvironmentSerializer
+            .new(project: @project, user: @current_user)
+            .with_pagination(request, response)
+            .within_folders
+            .represent(@environments),
           available_count: project.environments.available.count,
           stopped_count: project.environments.stopped.count
         }
@@ -36,10 +36,10 @@ def folder
       format.html
       format.json do
         render json: {
-          environments: EnvironmentSerializer.
-            new(project: @project, user: @current_user).
-            with_pagination(request, response).
-            represent(@environments),
+          environments: EnvironmentSerializer
+            .new(project: @project, user: @current_user)
+            .with_pagination(request, response)
+            .represent(@environments),
           available_count: folder_environments.available.count,
           stopped_count: folder_environments.stopped.count
         }

app/controllers/projects/merge_requests_controller.rb

@@ -235,9 +235,9 @@ def pipelines
       end
       format.json do
-        render json: PipelineSerializer.
-          new(project: @project, user: @current_user).
-          represent(@pipelines)
+        render json: PipelineSerializer
+          .new(project: @project, user: @current_user)
+          .represent(@pipelines)
       end
     end
   end
@@ -248,9 +248,9 @@ def new
       format.json do
         define_pipelines_vars
-        render json: PipelineSerializer.
-          new(project: @project, user: @current_user).
-          represent(@pipelines)
+        render json: PipelineSerializer
+          .new(project: @project, user: @current_user)
+          .represent(@pipelines)
       end
     end
   end
@@ -343,9 +343,9 @@ def cancel_merge_when_build_succeeds
       return access_denied!
     end
-    MergeRequests::MergeWhenPipelineSucceedsService.
-      new(@project, current_user).
-      cancel(@merge_request)
+    MergeRequests::MergeWhenPipelineSucceedsService
+      .new(@project, current_user)
+      .cancel(@merge_request)
   end
   def merge
@@ -380,9 +380,9 @@ def merge
       end
       if @merge_request.head_pipeline.active?
-        MergeRequests::MergeWhenPipelineSucceedsService.
-          new(@project, current_user, merge_params).
-          execute(@merge_request)
+        MergeRequests::MergeWhenPipelineSucceedsService
+          .new(@project, current_user, merge_params)
+          .execute(@merge_request)
         @status = :merge_when_build_succeeds
       elsif @merge_request.head_pipeline.success?
@@ -709,8 +709,8 @@ def set_suggested_approvers
   end
   def merge_request_params
-    params.require(:merge_request).
-      permit(merge_request_params_ce << merge_request_params_ee)
+    params.require(:merge_request)
+      .permit(merge_request_params_ce << merge_request_params_ee)
   end
   def merge_request_params_ce

app/controllers/projects/pipelines_controller.rb

@@ -7,26 +7,26 @@ class Projects::PipelinesController < Projects::ApplicationController
   def index
     @scope = params[:scope]
-    @pipelines = PipelinesFinder.
-      new(project).
-      execute(scope: @scope).
-      page(params[:page]).
-      per(30)
-    @running_or_pending_count = PipelinesFinder.
-      new(project).execute(scope: 'running').count
-    @pipelines_count = PipelinesFinder.
-      new(project).execute.count
+    @pipelines = PipelinesFinder
+      .new(project)
+      .execute(scope: @scope)
+      .page(params[:page])
+      .per(30)
+    @running_or_pending_count = PipelinesFinder
+      .new(project).execute(scope: 'running').count
+    @pipelines_count = PipelinesFinder
+      .new(project).execute.count
     respond_to do |format|
       format.html
       format.json do
         render json: {
-          pipelines: PipelineSerializer.
-            new(project: @project, user: @current_user).
-            with_pagination(request, response).
-            represent(@pipelines),
+          pipelines: PipelineSerializer
+            .new(project: @project, user: @current_user)
+            .with_pagination(request, response)
+            .represent(@pipelines),
           count: {
             all: @pipelines_count,
             running_or_pending: @running_or_pending_count
@@ -41,9 +41,9 @@ def new
   end
   def create
-    @pipeline = Ci::CreatePipelineService.
-      new(project, current_user, create_params).
-      execute(ignore_skip_ci: true, save_on_errors: false)
+    @pipeline = Ci::CreatePipelineService
+      .new(project, current_user, create_params)
+      .execute(ignore_skip_ci: true, save_on_errors: false)
     unless @pipeline.persisted?
       render 'new'
       return

app/controllers/projects_controller.rb

@@ -294,8 +294,8 @@ def load_events
   end
   def project_params
-    params.require(:project).
-      permit(project_params_ce << project_params_ee)
+    params.require(:project)
+      .permit(project_params_ce << project_params_ee)
   end
   def project_params_ce

app/controllers/users_controller.rb

@@ -118,8 +118,8 @@ def load_events
   def load_projects
     @projects =
-      PersonalProjectsFinder.new(user).execute(current_user).
-      page(params[:page])
+      PersonalProjectsFinder.new(user).execute(current_user)
+      .page(params[:page])
   end
   def load_contributed_projects

app/finders/environments_finder.rb

@@ -17,12 +17,12 @@ def execute
         deployments.none
       end
-    environment_ids = deployments.
-      group(:environment_id).
-      select(:environment_id)
-    environments = project.environments.available.
-      where(id: environment_ids).order_by_last_deployed_at.to_a
+    environment_ids = deployments
+      .group(:environment_id)
+      .select(:environment_id)
+    environments = project.environments.available
+      .where(id: environment_ids).order_by_last_deployed_at.to_a
     environments.select! do |environment|
       Ability.allowed?(current_user, :read_environment, environment)

app/models/ci/build.rb

@@ -66,9 +66,9 @@ def create_from(build)
       end
       def retry(build, current_user)
-        Ci::RetryBuildService.
-          new(build.project, current_user).
-          execute(build)
+        Ci::RetryBuildService
+          .new(build.project, current_user)
+          .execute(build)
       end
     end
@@ -99,9 +99,9 @@ def retry(build, current_user)
     end
     def detailed_status(current_user)
-      Gitlab::Ci::Status::Build::Factory.
-        new(self, current_user).
-        fabricate!
+      Gitlab::Ci::Status::Build::Factory
+        .new(self, current_user)
+        .fabricate!
     end
     def manual?
@@ -223,9 +223,9 @@ def variables
     end
     def merge_request
-      merge_requests = MergeRequest.includes(:merge_request_diff).
-                                   where(source_branch: ref, source_project_id: pipeline.gl_project_id).
-                                   reorder(iid: :asc)
+      merge_requests = MergeRequest.includes(:merge_request_diff)
+                                   .where(source_branch: ref, source_project_id: pipeline.gl_project_id)
+                                   .reorder(iid: :asc)
       merge_requests.find do |merge_request|
         merge_request.commits_sha.include?(pipeline.sha)

app/models/ci/pipeline.rb

@@ -91,9 +91,9 @@ class Pipeline < ActiveRecord::Base
     # ref can't be HEAD or SHA, can only be branch/tag name
     scope :latest, ->(ref = nil) do
-      max_id = unscope(:select).
-        select("max(#{quoted_table_name}.id)").
-        group(:ref, :sha)
+      max_id = unscope(:select)
+        .select("max(#{quoted_table_name}.id)")
+        .group(:ref, :sha)
       relation = ref ? where(ref: ref) : self
       relation.where(id: max_id)
@@ -132,16 +132,16 @@ def stages_name
     def stages
       # TODO, this needs refactoring, see gitlab-ce#26481.
-      stages_query = statuses.
-        group('stage').select(:stage).order('max(stage_idx)')
+      stages_query = statuses
+        .group('stage').select(:stage).order('max(stage_idx)')
       status_sql = statuses.latest.where('stage=sg.stage').status_sql
-      warnings_sql = statuses.latest.select('COUNT(*) > 0').
-        where('stage=sg.stage').failed_but_allowed.to_sql
-      stages_with_statuses = CommitStatus.from(stages_query, :sg).
-        pluck('sg.stage', status_sql, "(#{warnings_sql})")
+      warnings_sql = statuses.latest.select('COUNT(*) > 0')
+        .where('stage=sg.stage').failed_but_allowed.to_sql
+      stages_with_statuses = CommitStatus.from(stages_query, :sg)
+        .pluck('sg.stage', status_sql, "(#{warnings_sql})")
       stages_with_statuses.map do |stage|
         Ci::Stage.new(self, Hash[%i[name status warnings].zip(stage)])
@@ -217,8 +217,8 @@ def cancel_running
     end
     def retry_failed(current_user)
-      Ci::RetryPipelineService.new(project, current_user).
-        execute(self)
+      Ci::RetryPipelineService.new(project, current_user)
+        .execute(self)
     end
     def mark_as_processable_after_stage(stage_idx)
@@ -350,15 +350,15 @@ def execute_hooks
     # Merge requests for which the current pipeline is running against
     # the merge request's latest commit.
     def merge_requests
-      @merge_requests ||= project.merge_requests.
-        where(source_branch: self.ref).
-        select { |merge_request| merge_request.head_pipeline.try(:id) == self.id }
+      @merge_requests ||= project.merge_requests
+        .where(source_branch: self.ref)
+        .select { |merge_request| merge_request.head_pipeline.try(:id) == self.id }
     end
     def detailed_status(current_user)
-      Gitlab::Ci::Status::Pipeline::Factory.
-        new(self, current_user).
-        fabricate!
+      Gitlab::Ci::Status::Pipeline::Factory
+        .new(self, current_user)
+        .fabricate!
     end
     private

app/models/ci/runner.rb

@@ -23,8 +23,8 @@ class Runner < ActiveRecord::Base
     scope :ordered, ->() { order(id: :desc) }
     scope :owned_or_shared, ->(project_id) do
-      joins('LEFT JOIN ci_runner_projects ON ci_runner_projects.runner_id = ci_runners.id').
-        where("ci_runner_projects.gl_project_id = :project_id OR ci_runners.is_shared = true", project_id: project_id)
+      joins('LEFT JOIN ci_runner_projects ON ci_runner_projects.runner_id = ci_runners.id')
+        .where("ci_runner_projects.gl_project_id = :project_id OR ci_runners.is_shared = true", project_id: project_id)
     end
     scope :assignable_for, ->(project) do

app/models/ci/stage.rb

@@ -28,9 +28,9 @@ def status
     end
     def detailed_status(current_user)
-      Gitlab::Ci::Status::Stage::Factory.
-        new(self, current_user).
-        fabricate!
+      Gitlab::Ci::Status::Stage::Factory
+        .new(self, current_user)
+        .fabricate!
     end
     def statuses