Skip to content
Snippets Groups Projects
  1. May 24, 2022
  2. May 18, 2022
  3. May 11, 2022
  4. May 02, 2022
  5. Apr 29, 2022
  6. Apr 13, 2022
  7. Aug 26, 2021
  8. Jul 29, 2021
  9. Apr 22, 2021
  10. Apr 13, 2021
  11. Mar 11, 2021
  12. Oct 29, 2020
  13. Oct 14, 2020
  14. Jun 29, 2020
    • Stan Hu's avatar
      Upgrade to Grape v1.3.3 · 3a0c6dd9
      Stan Hu authored
      This brings back many of the changes in
      https://gitlab.com/gitlab-org/gitlab/-/merge_requests/27276. This was
      reverted due to some failures in the QA tests with nil parameters.
      
      Grape v1.3.3 brings in Ruby 2.7 support and a number of fixes:
      https://github.com/ruby-grape/grape/blob/master/CHANGELOG.md
      
      1. Move all inherited `Grape::API` -> `Grape::API::Instance`
      2. Remove use of Virtus since this has been removed from Grape.
      3. Extract `Rack::Response` from API error
      4. Grape v1.2.3 pulled in a fix used in `SafeFile`:
      https://github.com/ruby-grape/grape/pull/1844, so we no longer need
      to maintain our custom type.
      5. Adapt `WorkhorseFile` with the latest changes to make custom types
      work with Grape and dry-types.
      6. Ensure `Array[String]` is coerced properly.
      
      The change from Virtus to dry-types now requires all strings to be
      coerced to arrays. Before this was done within Virtus.
      
      7. Coerce `Array[Integer]` types to arrays of integers
      
      8. Use a new helper, `coerce_nil_params_to_array!`, that coerces nil
      Array inputs to empty arrays to preserve previous behavior.
      
      If you have a parameter of type `Array[String]`, for example, Grape used
      to coerce a provided `nil` value to `[]`. Grape no longer does this for
      us, so we need a helper method that will automatically do this if the
      parameter is present.
      
      This merge request also introduces two Rubocop rules for Grape v1.3:
      
      1. `Grape::API::Instance` instead of `Grape::API` is required, unless we
      solve https://gitlab.com/gitlab-org/gitlab/-/issues/215230.
      
      2. Grape parameters defined with `Array` types (e.g. `Array[String]`,
      `Array[Integer]`) must have a `coerce_with` block or they will fail to
      parse properly. See
      https://github.com/ruby-grape/grape/blob/master/UPGRADING.md for more
      details.
      3a0c6dd9
  15. Apr 27, 2020
    • Stan Hu's avatar
      Revert "Merge branch 'sh-update-grape-gem' into 'master'" · 106dbbfb
      Stan Hu authored
      This reverts merge request !27276
      106dbbfb
    • Stan Hu's avatar
      Upgrade Grape v1.1.0 to v1.3.2 · f31bac1d
      Stan Hu authored
      This brings in Ruby 2.7 suport and a number of fixes:
      https://github.com/ruby-grape/grape/blob/master/CHANGELOG.md
      
      1. Move all inherited Grape::API -> Grape::API::Instance
      2. Remove use of Virtus since this has been removed from Grape.
      3. Extract Rack::Response from API error
      4. Grape v1.2.3 pulled in a fix used in SafeFile:
      https://github.com/ruby-grape/grape/pull/1844, so we no longer need
      to maintain our custom type.
      5. Adapt WorkhorseFile with the latest changes to make custom types work
      with Grape and dry-types.
      6. Ensure Array[String] is coerced properly.
      
      The change from Virtus to dry-types now requires all strings to be
      coerced to arrays. Before this was done within Virtus.
      
      7. Coerce Array[Integer] types to arrays of integers
      
      The change from Virtus to dry-types now requires all strings to be
      coerced to arrays of integers. Before this was done within Virtus.
      f31bac1d
  16. Apr 02, 2020
  17. Mar 25, 2020
    • Jake Burden's avatar
      Adds environments delete button and modal · 6a093dcf
      Jake Burden authored and Shinya Maeda's avatar Shinya Maeda committed
      Adds delete functionality
      Adds a property the 'api' library to enable access for buildUrl
      Passes the project ID as a prop to the environments component
      Imports the Delete component for use within the environment items
      Adds canDeleteEnvironment as a computed method for environment items
      Defines project ID as a required prop for the environments component
      Imports the delete modal for the environments folder view
      Sets up the delete modal within the environments modal
      Creates a deleteAction helper method within the environments mixin
      Creates an update method for the delete modal
      Adds a method to facilitate API access to delete an environment
      Adds events for reactivity with the delete environment feature
      Adds an axios helper for DELETE calls in the environments service
      Exposes a data attribute with the project ID on the environments list
      Adds a test for the delete environment component
      Adds a project ID to the mock data for the environments app
      
      Adds translations and formatting
      
      Fixes commas, semicolons, and whitespace using prettier
      Adds generated environments-related translations
      
      Implements delete button for detail view
      
      Removes front-end buildable delete endpoint
      Updates deletion method to ensure endpoint access
      Removes previously-added project id property
      Accesses exposed deletion endpoint
      Adds helper function for model-based access to API endpoint
      Exposes update rule for front-end access
      Exposes helper-based delete endpoint
      Removes previously added project id property
      Adds modal and button for detail view
      Removes project ID from mock data
      
      Using const instead of let
      
      Removes now unused import
      
      Adds entry to changelog
      
      Adds reload on delete modal success
      
      Adds reload on delete for etag expiration
      Modifies method name
      Modifies delete path helper on entity
      Modifies delete action helper
      Adds request_url param
      
      Adding docs for delete feature
      
      Adds translations and lint fixes
      6a093dcf
  18. Jun 24, 2019
  19. Apr 09, 2019
  20. Feb 17, 2019
  21. Jan 24, 2019
  22. Nov 30, 2018
  23. Nov 28, 2018
  24. Sep 30, 2018
  25. Jul 10, 2018
  26. Aug 31, 2017
  27. Aug 29, 2017
  28. Aug 28, 2017
  29. Jul 20, 2017
  30. Mar 16, 2017
  31. Feb 28, 2017
  32. Dec 15, 2016
  33. Nov 22, 2016
  34. Nov 14, 2016
Loading