Line breaks are stripped from Fastlane descriptions

• Device OS and version: Android 7.1.2
• Device model/manufacturer: Google Nexus 6p
• F-Droid version (in the About screen): 1.0-alpha0
• F-Droid privileged extension version (if installed): Not installed

Privacy Browser is using the Fastlane folder structure to specify the description, changelogs, and graphics. full_description.txt contains several line breaks:

https://git.stoutner.com/?p=PrivacyBrowser.git;a=blob;f=fastlane/metadata/android/en/full_description.txt;

The text from full_description.txt is displayed in the F-Droid client. But the line breaks are removed.

For comparison purposes, the description for Tinfoil for Facebook is specified in the metadata file. It also has several line breaks:

https://gitlab.com/fdroid/fdroiddata/blob/master/metadata/com.danvelazco.fbwrapper.txt

These are rendered correctly in the F-Droid client.

The same issue for play descriptions (i.e https://github.com/kontalk/androidclient/blob/master/app/src/main/play/en-US/listing/fulldescription) observed in german and english translation with fdroid 1.0-alpha1: lost line breaks.

This issue does not happen with old style app descriptions. (i.e. https://gitlab.com/fdroid/fdroiddata/blob/master/metadata/de.k3b.android.androFotoFinder.txt) the linebreaks are displayed

This is a follow up/subtask to #1100

Hmm, this seems like a problem with the server as well, whereby descriptions are processed into basic HTML with non-localized metadata:

{
   "packageName" : "com.danvelazco.fbwrapper",
   "description" : "<p>Browse Facebook's mobile site with a simple web browser, which protects your privacy by avoiding the ability of the page and others to track your browsing history. It also includes other functionalities, like shortcuts to the notifications page or app settings to control whether your current location is to be provided to Facebook's website.</p><p>The COARSE_LOCATION permission is only used if you enable \"Allow Check-ins\" on the preferences section, which is disabled by default.</p><p>AntiFeatures:</p><ul><li> Tracking. You are required to log in to Facebook.</li></ul>",

Whereas localized metadata ends up as its original text:

{
   "packageName" : "com.stoutner.privacybrowser.standard",
   "localized" : {
      "de" : {
         "name" : "Privacy Browser\n",
         "description" : "Privacy Browser ist ein Web-Browser, der Ihre Privatsphäre durch einfache Einstellmöglichkeiten für JavaScript, DOM-Speicher und Cookies schützt. Viele Websites nutzen diese Technologien, um Besucher bei Besuchen ihrer oder anderer Websites zu verfolgen. Das Tippen auf den Privatsphäre-Schild schaltet zwischen Ein- und ausgeschaltetem JavaScript um und lädt WebView neu. Wenn JavaScript deaktiviert ist, werden nicht nur Privatsphäre und Sicherheit erhöht, sondern Websites laden auch noch schneller bei weniger Datenverbrauch.\n\nPrivacy Browser benutzt Androids eingebaute WebView, um Websites zu rendern. Infolgedessen funktioniert er am besten, wenn Sie auf die neuste WebView-Version aktualisiert haben. \n\nWarning: Privacy Browser is susceptible to\n[https://www.stoutner.com/kitkat-security-problems/ MITM (Man In The Middle)\nattacks] when browsing insecure websites from devices running Android KitKat\n(version 4.4.x, API 19).\n\nFunktionen:\n*Verknüpfungs-Icons zur Startseite hinzufügen.\n*Lesezeichen.\n*Unterstützung für TOR über Orbot.\n\nGeplante Funktionen für künftige Versionen:\n*Dateiupload auf Websites.\n*Detaillierte Cookie-Verwaltung.\n*Detaillierte DOM-Speicher-Verwaltung. \n*Mehrere Tabs öffnen.\n",
         "summary" : "Ein Webbrowser mit Fokus auf die Privatsphäre.\n"
      },
      "en" : {
         "description" : "Privacy Browser protects your privacy by disabling JavaScript, DOM storage, and cookies by default, but providing quick methods to enable them for websites where they are required. Many websites use these technologies to track users between visits and across sites.\n\nPrivacy Browser uses Android's built-in WebView to render web pages.  As such, it works best if you have updated to the latest version of WebView.\n\nWarning: Privacy Browser is susceptible to\n[https://www.stoutner.com/kitkat-security-problems/ MITM (Man In The Middle)\nattacks] when browsing insecure websites from devices running Android KitKat\n(version 4.4.x, API 19).\n\nFeatures:\n*Full screen browsing mode.\n*Integrated ad blocker.\n*Tor Orbot proxy support.\n\nPlanned features for future releases:\n*Upload of files to website.\n*Fine grained cookie management.\n*Fine grained DOM storage management.\n*Tabbed browsing.\n",
         "summary" : "A web browser that respects your privacy.\n",
         "name" : "Privacy Browser\n",
         "whatsNew" : "• Add a dark theme option.\n• Highlight the http:// in red if a domain is not encrypted.\n• Highlight the domain in the URL text box.\n• Add settings to control what happens on Clear and Exit.\n• Change the default homepage to https://start.duckduckgo.com.\n• Add an undo action to the snackbar when cookies, DOM storage, or form data are cleared from the options menu.\n• Fix a bug that caused pending changes to be lost on restart.\n• Fix a bug with the spinner layout on some Huawei devices.\n• Updated It"
      },

Some related issues seem to be fdroidserver#353 (closed) and #1000. @eighthave mentioned in fdroidserver#353 (closed) that the localized metadata stays in tact, so perhaps it is a known issue, or maybe intentional? Not quite sure. He is away for the next few weeks though, so may not get a response in August about this. Perhaps #1000 is the place to continue this discussion.

There is a related issue: text files are by definition ended with a line break (and git complains if they don't). If you add the line break, the title of the app gets multi-line. Just compare title.txt of those apps:

Oh, good find @ByteHamster. When we address this on fdroidserver, we should also sanitize one-line bits of text like that. Given how trivial it is on the client side, I will probably also trim trailing whitespace there too (for the summary at least).