F-Droid client not listed as installed after upgrade to 0.65
Upgrading from 0.63 to 0.65 removes the fdroid client from the installed apps list. Rebooting or force-closing the app fixes this.
Devices: Nexus 7 2013 LTE, Moto G Rom: CM11 IRC Log:
< krt> mvdan: after update the fdroid app itself is missing from the installed app list
<+mvdan> ha, what?
< krt> well it's just missing. if i search for the fdroid client it finds it but the info page does not list any version as installed
< krt> oh well, reboot fixed it oO
<+mvdan> Then it's got something to do with broadcastreceivers...
< krt> mvdan: seems like force closing fdroid after the update does work, too. should i still raise an issue?
<+mvdan> krt: yes
<+mvdan> krt: wiping it from memory (restarting the phone does that too) "fixes it" because it forces f-droid to query the installed apps again
<+mvdan> krt: what did you update from?
< krt> 0.63
Activity
Issue is reproducible by installing 0.63 and updating to 0.65:
04-29 17:13:23.941 D/FDroid (22872): Downloading apk from https://f-droid.org/repo/org.fdroid.fdroid_650.apk 04-29 17:13:24.991 D/FDroid (22872): Download finished: /storage/emulated/0/Android/data/org.fdroid.fdroid/cache/apks/org.fdroid.fdroid_650.apk 04-29 17:13:31.721 I/FDroid (23096): Upgrading database from v42 v44 04-29 17:13:31.741 D/FDroid (23096): Update scheduler alarm not set 04-29 17:13:32.321 D/FDroid (23096): PackageReceiver received [action = 'android.intent.action.PACKAGE_REMOVED', data = 'package:org.fdroid.fdroid'] 04-29 17:13:32.321 D/FDroid (23096): Removing installed app info for 'org.fdroid.fdroid'So F-Droid never gets its own broadcast message about 0.65 being installed... I suppose that is because in the brief moment between 0.63 being removed and 0.65 being installed, F-Droid is removed and thus not receiving anything. I'll try to work around this.
I have fixed it, I think:
04-29 17:57:40.291 D/FDroid (24808): PackageReceiver received [action = 'android.intent.action.PACKAGE_REMOVED', data = 'package:org.fdroid.fdroid'] 04-29 17:57:40.291 D/FDroid (24808): Discarding since this PACKAGE_REMOVED is just a PACKAGE_REPLACED 04-29 17:57:40.311 D/FDroid (24808): PackageReceiver received [action = 'android.intent.action.PACKAGE_REPLACED', data = 'package:org.fdroid.fdroid'] 04-29 17:57:40.321 D/FDroid (24808): Updating installed app info for 'org.fdroid.fdroid' to v651 (0.65)I simulated this by installing 650, bumping the vercode to 651, and upgrading. Worked as expected, F-Droid is still in the installed tab.
I'll do a MR in a moment.
mentioned in merge request !8 (merged)
Reassigned to @mvdan
