cannot manually add repo that was swapped before

If a repo has been used in a swap before, then it is not possible to later add that repo manually. There is an error in the Add Repo dialog that says that a repo with a different key cannot be added. But the key will be the same, it is just that the fingerprint is blank. Seems like when the fingerprint TextEdit is blank, the fingerprint comparison needs to happen later.

If this is a simple fix, it would be good to have in the upcoming stable, otherwise punt it to the swap work.

The fix for this will be relatively easy, but I'd like to clarify the current process so that I come up with the right solution. Right now, swap repos are added to the database with the isSwap column set to 1. Other, regular repos have a value of 0. Essentially everywhere in F-Droid that queries for repositories using the RepoProvider explicitly exclude repos that have an isSwap value of 1, except for if you ask for a specific repository based on the URL.

In the case you've shown above, it is indeed asking for a specific repository based on URL, so that means that the swap repo is returned in the query.

I still want to keep swap repositories out of the ManageRepos activity. The main reason is that we end up with repo updates pinging swap repos, even though it is most likely that at midnight when your device decides to update the repos while you are sleeping, you are probably not next to that person you swapped with earlier in the day or last week. By forcing people to use the swap process to download and install apps from a swap repo, it is quite clear that you need to be in physical proximity to that user in order to get apps from them.

Sooooo, after all that, the options are this:

• Leave the swap repo in the database, and add the same repo again without the isSwap flag.
• Update the isSwap repo so that it is "promoted" to a regular repo, by dropping the isSwap flag. All future swaps to that repo will not reinstate the isSwap flag, until the repo is explicitly deleted.

After writing all this down, I've come to the conclusion that option 2 is probably the best. You still get to swap with them, and you still get to explicitly add the repo in ManageRepos. I think I'll go ahead and do that, but let me know if you think otherwise.

mentioned in merge request !90 (merged)

Status changed to closed by commit 5065c37e13e6f3f34b9e8187d2b4f238a972d218