All big application icons are grey

Since I updated F-Droid to 0.93-test, all big application icons are grey. I expect these to come back once there are actual updates, but it's not quite professional to look all icons when updating:

Whoopsies, I completely forgot about this bug that @pserwylo pointed out. @pserwylo would there be a way to force a call on "update all iconUrl* columns" after a DB upgrade?

Milestone changed to next-stable

would there be a way to force a call on "update all iconUrl* columns" after a DB upgrade?

Sure. I believe it is enough to bump the DBVersion, then add a method call like:

if ( dbVersion < blah ) {
  // The "WHERE 1" is not necesary, but it makes it clear to everyone that you _actually meant to update everything_, rather than forgetting a where clause.
  database.exexSQL( "UPDATE fdroid_apk SET iconUrlLarge = iconUrl WHERE 1" );
}

Nono, I mean to populate them properly via updateIconUrls()

On a sidenote, are these icons supposed to be blurry? They appear to be blurry on my device, as if they're simply upscaled from the smaller icons.

Depends on the app. If we were able to fetch a large icon, the icon won't be blurry. If the apk only includes small icons, it will be blurry on most devices.

Reassigned to @mvdan

Added regression label

Reassigned to @pserwylo

mentioned in merge request !113 (merged)

@pserwylo remember that you have to say "closes #foo" or "fixes #foo" in your commit message for the issue to be closed automagically by gitlab. MR titles/descriptions don't count.

Status changed to closed