Orientation change during repo update causes error

The dialog isn't disposed of properly, so next time the UpdateService attempts to access it, it falls over. Additionally, even if it did work, the dialog is not recreated each time a progress event is received. The AppDetails deal with this, but it does so using quite a few deprecated functions, so it may be a good opportunity to clean up the code a little bit, and figure out the (new) "Right Way" to deal with orientation changes (each new Android version seems to have a new right way to do things though).

It looks like either:

• listen in onConfigurationChange and prevent activity being recreated (if we have a download in progress)
• Save download progress/dialog info to a bundle in onSavedInstanceState

https://developer.android.com/reference/android/app/Activity.html#ConfigurationChanges

Seeing as this isn't all that important, I'll be happy for it to go the next milestone, and stick with the bug-fix release for 0.65.

Milestone changed to 0.71

Reassigned to @pserwylo

Seems silly for me not to fix this before 0.71. I'll have a look some time this weekend. Other tha that, I couldn't find any other (confirmed) bugs which look like they are stopping people from using F-Droid which need to be assigned to 0.71. If some of those crashers come back with logcats, then maybe we'll be able to reconsider.

Sure.

Reassigned to @eighthave

Oops, this was closed in 5ff0ef.

Status changed to closed

mentioned in issue #23 (closed)