Shouldn't remove by clicking on installed version

Uninstall by clicking installed version is unexpected and not very convenient.

(issue rewritten by @mvdan)

Added privileged installer label

Good call @jk. I think that we should probably remove the whole concept of being able to remove apps by touching the installed version in the list, and only allow it from the menu. Having said that, I'm going to remove the "critical" tag, and replace with more specific ones, as it is not crashing or preventing people from using F-Droid to the point where we will be putting resources to this over other bugs. I do understand your point about deleting data, but we'd rather save the critical label for things such as not being able to download or install apps at all. Cheers.

Added help-wanted ui useability and removed critical labels

Wait, didn't my changes add a confirmation dialog for this?

It does indeed ask. "Do you want to uninstall this app?". So you can call this a UI/UX issue, but it's definitely not a security issue/bug since we are warning the user anyway.

Android is asking, not F-Droid. But when you use F-Droid with system permissions (for example when injected into /system partition), this system UI is bypassed and there is no question. Both clicking installed version in list and uninstall button in toolbar does the same.

@jk I just tried to re-produce. For me F-Droid is asking and it is installed as a privileged app.

Like @dschuermann, it works for me. What version are you guys using?

FWIW, these changes are not in stable yet. They appeared in 0.93-test. Renaming issue to "Shouldn't remove by clicking on installed version".

Removed bug help-wanted privileged installer labels

Title changed from Uninstall is too easy to Shouldn't remove by clicking on installed version

I'm using version 0.92. I tested version 0.94-test right now and it asks as expected. So the changed title is correct.

I would expect new download and reinstall when clicking already installed version.

Reported in old issue tracker: https://f-droid.org/repository/issues/?do=view_issue&issue=400

Maybe the installed version should be displayed in a different colour so that it's obvious that it's different to the other items in the list?

mentioned in issue #543 (closed)

Added ~16415 label

Milestone changed to %0.103 - UX Overhaul

I've made sure to bring this up in our meetings about the new design for App Details being worked on. Reference issue for that is #749 (closed).

mentioned in issue #749 (closed)

Given the other issue, I'm going to close this in favour of that.

Status changed to closed