Change variable names to match Android SDK
There are a number of variable names used throughout the FDroid code that reference common concepts in the Android SDK, but FDroid uses different names for them. I propose renaming these variables throughout fdroidclient to match the Android SDK names. This makes the code much easier to read since the same concepts will use the same names. Here are my current suggested renames:
-
suggestedVercode -> suggestedVersionCode (versionCode) -
upstreamVercode -> upstreamVersionCode (versionCode) -
upstreamVersion -> upstreamVersionName (versionName) -
UPSTREAM_VERSION -> UPSTREAM_VERSION_NAME (versionName) -
appId/APP_ID -> packageName/PACKAGE_NAME (package aka "package name") -
repo.pubkey -> repo.signingCertificate (it is indeed the whole cert, not just the pubkey)