Crash on Enable NFC Send on NFC-less device

Android 5.1.1 (CyanogenMod 12.1) F-Droid 0.96-alpha2

This device does NOT have NFC support.

How to reproduce:

1. Go to Repositories
2. Click a repository
3. Click Enable NFC Send

E/AndroidRuntime(12512): FATAL EXCEPTION: main
E/AndroidRuntime(12512): Process: org.fdroid.fdroid, PID: 12512
E/AndroidRuntime(12512): java.lang.RuntimeException: Unable to start activity ComponentInfo{org.fdroid.fdroid/org.fdroid.fdroid.NfcNotEnabledActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.nfc.NfcAdapter.isEnabled()' on a null object reference
E/AndroidRuntime(12512):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2356)
E/AndroidRuntime(12512):        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2418)
E/AndroidRuntime(12512):        at android.app.ActivityThread.access$900(ActivityThread.java:154)
E/AndroidRuntime(12512):        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1321)
E/AndroidRuntime(12512):        at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime(12512):        at android.os.Looper.loop(Looper.java:135)
E/AndroidRuntime(12512):        at android.app.ActivityThread.main(ActivityThread.java:5289)
E/AndroidRuntime(12512):        at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(12512):        at java.lang.reflect.Method.invoke(Method.java:372)
E/AndroidRuntime(12512):        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)
E/AndroidRuntime(12512):        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:699)
E/AndroidRuntime(12512): Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.nfc.NfcAdapter.isEnabled()' on a null object reference
E/AndroidRuntime(12512):        at org.fdroid.fdroid.NfcNotEnabledActivity.doOnJellybean(NfcNotEnabledActivity.java:24)
E/AndroidRuntime(12512):        at org.fdroid.fdroid.NfcNotEnabledActivity.onCreate(NfcNotEnabledActivity.java:44)
E/AndroidRuntime(12512):        at android.app.Activity.performCreate(Activity.java:5990)
E/AndroidRuntime(12512):        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1106)
E/AndroidRuntime(12512):        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2309)
E/AndroidRuntime(12512):        ... 10 more
W/ActivityManager( 2055):   Force finishing activity 1 org.fdroid.fdroid/.NfcNotEnabledActivity
W/ActivityManager( 2055):   Force finishing activity 2 org.fdroid.fdroid/.views.RepoDetailsActivity

Status changed to closed by commit fd7f942595bba319562a124e71326a2a27345baf

Thanks for reporting!

The last commit should hide the menu button on devices without NFC, which was the root of the cause.

Milestone changed to 0.96