proguard still stripping code needed for swap

This is rehashing an old issue here. proguard code removal was re-added in 7bff114602c3eab49259f078d10e20f2b5941573 and it again broke swapping.

This fixed it for me:

-            minifyEnabled true
-            shrinkResources true
+            minifyEnabled false
+            shrinkResources false

Here is the characteristic stacktrace:

tivity.UpdateAsyncTask  E  An error occured while setting up the local repo
                        E  java.lang.RuntimeException: generate [class kellinwood.security.zipsigner.KeySet, class [B]
                        E      at kellinwood.security.zipsigner.ZipSigner.writeSignatureBlock(ZipSigner.java:519)
                        E      at kellinwood.security.zipsigner.ZipSigner.signZip(ZipSigner.java:740)
                        E      at kellinwood.security.zipsigner.ZipSigner.signZip(ZipSigner.java:647)
                        E      at org.fdroid.fdroid.localrepo.LocalRepoKeyStore.signZip(LocalRepoKeyStore.java:210)
                        E      at org.fdroid.fdroid.localrepo.LocalRepoManager.writeIndexJar(LocalRepoManager.java:504)
                        E      at org.fdroid.fdroid.views.swap.SwapActivity$UpdateAsyncTask.doInBackground(SwapActivity.java:258)
                        E      at org.fdroid.fdroid.views.swap.SwapActivity$UpdateAsyncTask.doInBackground(SwapActivity.java:219)
                        E      at android.os.AsyncTask$2.call(AsyncTask.java:288)
                        E      at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                        E      at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
                        E      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
                        E      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
                        E      at java.lang.Thread.run(Thread.java:841)
                        E  Caused by: java.lang.NoSuchMethodException: generate [class kellinwood.security.zipsigner.KeySet, class [B]
                        E      at java.lang.Class.getConstructorOrMethod(Class.java:472)
                        E      at java.lang.Class.getMethod(Class.java:857)
                        E      at kellinwood.security.zipsigner.ZipSigner.writeSignatureBlock(ZipSigner.java:515)

Try this:

-keep class kellinwood.security.zipsigner.** { *; }

mentioned in issue #334 (closed)

Status changed to closed by commit e7c727f4462e1949078205af036f3105599bf03a

Status changed to reopened

This gives a new stacktrace, so you'll need a lot more than that. It strips lots of classes out that are needed. We've been here before: #88 (closed) #100 (closed) !31 (merged) !32 (merged) 785dd036d105fbda1c0704d2805c92d60b012dd8 and we disabled the stripping. proguard is only need for obfuscating for the Samsung bug, so it should be configured to only obfuscate those android support classes.

Here's the stacktrace:

tivity.UpdateAsyncTask  E  An error occured while setting up the local repo
                        E  java.lang.RuntimeException
                        E      at kellinwood.security.zipsigner.ZipSigner.writeSignatureBlock(ZipSigner.java:519)
                        E      at kellinwood.security.zipsigner.ZipSigner.signZip(ZipSigner.java:740)
                        E      at kellinwood.security.zipsigner.ZipSigner.signZip(ZipSigner.java:647)
                        E      at org.fdroid.fdroid.localrepo.LocalRepoKeyStore.signZip(LocalRepoKeyStore.java:213)
                        E      at org.fdroid.fdroid.localrepo.LocalRepoManager.writeIndexJar(LocalRepoManager.java:504)
                        E      at org.fdroid.fdroid.views.swap.SwapActivity$UpdateAsyncTask.doInBackground(SwapActivity.java:258)
                        E      at org.fdroid.fdroid.views.swap.SwapActivity$UpdateAsyncTask.doInBackground(SwapActivity.java:219)
                        E      at android.os.AsyncTask$2.call(AsyncTask.java:288)
                        E      at java.util.concurrent.FutureTask.run(FutureTask.java:237)
                        E      at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
                        E      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
                        E      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
                        E      at java.lang.Thread.run(Thread.java:841)
                        E  Caused by: java.lang.reflect.InvocationTargetException
                        E      at java.lang.reflect.Method.invokeNative(Native Method)
                        E      at java.lang.reflect.Method.invoke(Method.java:515)
                        E      at kellinwood.security.zipsigner.ZipSigner.writeSignatureBlock(ZipSigner.java:516)
                        E      ... 12 more
                        E  Caused by: java.lang.RuntimeException: cannot create signer: Signature SHA1WITHRSA implementation not found
                        E      at kellinwood.security.zipsigner.optional.SignatureBlockGenerator.generate(SignatureBlockGenerator.java:54)
                        E      ... 15 more
                        E  Caused by: org.spongycastle.operator.OperatorCreationException: cannot create signer: Signature SHA1WITHRSA implementation not found
                        E      at org.spongycastle.operator.jcajce.JcaContentSignerBuilder.build(JcaContentSignerBuilder.java:101)
                        E      at kellinwood.security.zipsigner.optional.SignatureBlockGenerator.generate(SignatureBlockGenerator.java:37)
                        E      ... 15 more
                        E  Caused by: java.security.NoSuchAlgorithmException: Signature SHA1WITHRSA implementation not found
                        E      at org.apache.harmony.security.fortress.Engine.notFound(Engine.java:177)
                        E      at org.apache.harmony.security.fortress.Engine.getInstance(Engine.java:170)
                        E      at java.security.Signature.getSignatureInstance(Signature.java:178)
                        E      at java.security.Signature.getInstance(Signature.java:146)
                        E      at org.spongycastle.jcajce.util.NamedJcaJceHelper.createSignature(NamedJcaJceHelper.java:98)
                        E      at org.spongycastle.operator.jcajce.OperatorHelper.createSignature(OperatorHelper.java:285)
                        E      at org.spongycastle.operator.jcajce.JcaContentSignerBuilder.build(JcaContentSignerBuilder.java:61)

How do you make it keep everything?

I don't really know, but I'm guessing something like this might work:

-keep class ** {*;}

Thought the same, but since I failed at proguard once already I don't dare.

Are you sure that this proguard config fixed that Samsung issue? It includes this in the config: -dontobfuscate and "obfuscation" is what proguard calls the class renaming.

The user confirmed that it was fixed. I don't know how proguard works, but I'm guessing that flags take precedence over previous ones. So perhaps we are obfuscating in only one place.

mentioned in merge request !127 (merged)

mentioned in merge request !128 (merged)

Status changed to closed by commit dc46bc2e84ae938c9bb0f78241c263f1fd5b5955