Label not shown on "Action"-Button (Install, Upgrade, Remove..) when multiple repos serve the same app

Reproduce on fdroid 0.100-alpha5:

• Add https://krt16s.github.io/repo/ as a repo
• Refresh
• Open Firefox info screen

Title changed from Label not shown on "Action"-Button (Install, Upgrade, Remove..) when using multiple repos to Label not shown on "Action"-Button (Install, Upgrade, Remove..) when multiple repos serve the same app

What do you mean by label? You mean the text on the button?

Yes, sorry for my wording :P

Thanks for the report @krt, can you please see if this is the case on the previous F-Droid stable? If so, we'll tag this as a regression and try to get it fixed before 0.100 stable. If not, I may still be able to have a sneaky look before the next stable :)

Yes, this indeed present in 0.99.2 as well.

This is odd. It can still be installed by clicking on the "Version 46.0" entry. For me, your repo is also reporting as "Unsigned". Does it for you?

Here's a screenshot of the issue:

Milestone changed to 0.100

Added bug label

oh, It was just the first update that your repo reported as unsigned, now its normal

My guess is that its related to the code that checks the app signing key. This does not happen if you enable the Guardian Project repo, which includes a few apps that are also in f-droid.org, but they all are signed by different keys.

I turned off all repos, then just enabled this repo, and it still had the issue. So the problem is more likely something with this particular repo.

Any clues what could be wrong? However, regardless if the repo is to blame, the button should never be missing its label/text.

Yeah, I think he meant that the repo alone was the trigger, and not multiple repos serving a single app.

yeah, I agree the repo should not be able to break the UI. I was pointing to the repo to narrow down what is causing the issue.

since this was in 0.98 and its not affecting a lot of users, I'm moving this to 0.101 so we can get 0.100 out sooner rather than later.

Milestone changed to 0.101

Milestone changed to %0.102

Added waiting-on-response label

I can no longer reproduce this in v0.102-alpha2 with some more commits. This is on a Moto G running 5.1. @krt can you try again, and close this if it is fixed for you?

Reassigned to @krt

reopen if this is still an issue

closed