Yet another InstallManagerService App.packageName NPE

Also, if we see this crash in 0.100/0.100.1, we might want to backport the fix for 0.100.2 too.

Seems like i need to read up a little bit on Service lifecycles. I think I missed something...

two user comments from the ACRA reports:

can't upgrade davdroid, gives an error permission of apk not equals with expected permissions
Tried to update Shattered Pixel Dungeon, got an error parsing the package followed by this crash

I looked at this, it seems to be the result of a failure elsewhere that ends up starting InstallManagerService without the proper data. There have been no reports of this for v0.101-alpha4, so either that build is terrible and no one is using it, or perhaps this was fixed elsewhere in the code. I'll revisit this before v0.101 final.

I say we can close this if we see no reports for neither alpha4 nor alpha5.

Arg there is one from alpha4:

APP_VERSION_NAME=0.101-alpha4
ANDROID_VERSION=4.4.4
BRAND=samsung
PHONE_MODEL=GT-I9305
STACK_TRACE=java.lang.NullPointerException
	at org.fdroid.fdroid.installer.InstallManagerService.getAppFromActive(InstallManagerService.java:404)
	at org.fdroid.fdroid.installer.InstallManagerService.access$600(InstallManagerService.java:62)
	at org.fdroid.fdroid.installer.InstallManagerService$3.onReceive(InstallManagerService.java:250)
	at android.support.v4.content.LocalBroadcastManager.executePendingBroadcasts(LocalBroadcastManager.java:297)
	at android.support.v4.content.LocalBroadcastManager.access$000(LocalBroadcastManager.java:46)
	at android.support.v4.content.LocalBroadcastManager$1.handleMessage(LocalBroadcastManager.java:116)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5146)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:732)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:566)
	at dalvik.system.NativeStart.main(Native Method)

Some more ACRA comments: 0.101-alpha1

tried to install wifi analyzer update via notification
I was updating AnySoftKeyboard
I tapped update faceslim
An app package was downloaded in background. Clicked on "install now" to install the update
tapped to upgrade after a download

0.101-alpha2

low memory
bij update

0.101-alpha4

Crashed while trying to update the Android app itself. I went back down the list and tried to find a non Alpha version and tapped it a few times because nothing happened. Then I had 4:05 screens acknowledging me to install. I said yes on all the screens Kama it crashed, and came back up with what you have now. I really want a stable version of this install because this is where I can get things that I cannot find on the Play Store and a lot of that that I particularly useful.

So somehow an Installer.ACTION_INSTALL_INTERRUPTED Intent with an error message is being sent to InstallManagerService regarding a downloadUrl that is not longer registered as active. If we just stuck a null guard to prevent the crash, then the install error would not be properly reported in the notification.

@dschuermann any ideas? It looks like you wrote this code.

I think we should punt this to 0.102 and make a 0.101 release. This crash is not happening often.

Milestone changed to %0.102

I suspect that somehow the download/install is started twice and the second one fails. But when it fails with ACTION_INSTALL_INTERRUPTED, downloadUrl is no longer registered as active because the first download/install succeeded and removed it. This would mean that we can safely disregard the ACTION_INSTALL_INTERRUPTED.

Sounds plausible. I think a better solution would be to prevent the second install session from ever starting. I guess that should happen inside InstallManagerService since its tracking which URLs/APKs are active.

Digging in a bit more, there are five cases where ACTION_INSTALL_INTERRUPTED will be sent when using the default installer:

user cancels install
system's package installer Activity not found
system's package installer Activity returns an error
APK sent to install fails to verify
ApkFileProvider.getSafeUri() fails with an IOException

I'm going to temporarily catch this NullPointerException and have it send an ACRA report that includes the error message. Hopefully that helps.

mentioned in merge request !385 (merged)

Ok, got the first report from 0.101-alpha6. It includes the error message "Failed to install due to an unknown error"

That seems to be from when DefaultInstaller gets a unspecified error from the system while installing.

To fix this, we need a way to get the packageName that produced the install error so that the name of the app in question can be fetched for the notification.

@commonsguy can you think of a way to retrieve the active notifications? That would help here a lot. I only found a method on android-23+ using NotificationManager.html#getActiveNotifications()

Um, well, besides that, you could implement a NotificationListenerService, but that requires the user to give you rights to monitor all notifications, which in turn requires a separate authorization step in Settings. It's not the sort of thing that I would think you want to be using. Besides, that only goes back to API Level 18.

I suppose you could implement an AccessibilityService, and spy on lots of UI operations, but that's scarier yet.

Otherwise, notifications are pretty much a write-only API.

Status changed to closed by merge request !392 (merged)

Yet another InstallManagerService App.packageName NPE

Designs

Child items 0

Activity

Admin message

Admin message

Yet another InstallManagerService App.packageName NPE

Activity