auto-download notification is "Tap to install Unknown", wrong tap target, and notification is not withdrawn
environment
CM 12.1, Nexus 5, fdroid 0.100.1.
reproduction recipe and description
Enable "automatically download updates" and "update notifications". Wait until an app is updated, and you will see a notifcation to install a downloaded app. That part works fine and seems reliable.
The notification says "Tap to install Unknown \n Download completed, tap to install".
Tapping on the notification takes me to F-Droid, but shows the Available tab.
I then go to the Updates tab (which shows 1), and see an app (this is entirely consistent with multiple apps). I then select the app, click upgrade, and then install. I then click back and see that the updates tab says 0. (The updated app is still listed, though.)
The notification is still present. I tap it again, and then it disappears.
desired behavior
The notification should say "Tap to install appname" in the first line, and just "Download completed" in the second (don't show tap to install twice).
When tapping, the user should be taken to either the updates page, or the update screen for the app (probably), or the permissions/install page.
The notification should be withdrawn when the above happens (probably), when the installation is attempted by clicking upgrade, or when install or cancel is pushed.
After an upgrade happens, the app page should no longer say "upgrade", even if the upgrade has not finished. Then, the app should be removed from the upgrade tab when it succeeds.
None of this is really troubling, but it will cause confusion for people.
Activity
I think @pserwylo ran into something similar.
@lexort what repo were you using?
Added installer label
Added bug label
Milestone changed to %0.101
mentioned in issue #758 (closed)
We've just finished redesigning the notifications, you can see that here: https://gitlab.com/fdroid/fdroidclient/issues/742#note_14689598
Milestone changed to %0.102
-
@rugk which part of this issue? "Tap to install Unknown"? Can you describe how to reproduce it?
Yes. Basically I just have "auto-download" of these updates enabled and this is what it showed me for every update. CM 13 here BTW.
However it showed me this thing in the past. Recently I thought it would work as it showed me the right name and also let me install it. Today I also got the correct notifications, but for some reason when I taped at them I got the Android error "Package could not be parsed" and FDroid changed the notification to "Some unknown error when trying to install the app happend." (or similar). This happened to all notifications/updates (had 3 or 4 today). However when I open FDroid as usual, go to updates and install the updates there, everything worked without any problem.
So it seems the auto-download option may be to blame here, somehow.
Mentioned in issue #786 (closed)
I am now using f-droid 0.101, and still have auto-download enabled. I just got three notifications, and each showed me the name of the app. After doing each update the notification was withdrawn. This is with CM 13. So I think this is fixed - thanks!
It seems others are still having issues with 0.101, so I won't close the ticket. But from my viewpoint, this is fixed.
rugk gitlab@mg.gitlab.com writes:
New comment for Issue 720
https://gitlab.com/fdroid/fdroidclient/issues/720#note_17440026
Author: rugk
Indeed I also can't reproduce this issue anymore.
Thanks - I have closed the issue then.
