0.101-alpha1 and later, dark/black themes have white text on white background popups

Device OS and version: Xperia 5.1.1, Samsung 5.0.2

Eg. Time to keep APKs popup

git bisect should be helpful here, to see what broke it.

Looks like 0.101-alpha1 has it too.

/LE: trying to pinpoint this, when was 0.100.1 launched, what commit? Changelog says June 21.

Also commit list says June 21 for 0.101-alpha1 too.

What commits are between 0.100.1 and 0.101-alpha1?

Changed title: 0.101-alpha5 dark/black themes have white text on white background popups → 0.101-alpha1 and later, dark/black themes have white text on white background popups

Only Settings dialogs have broken theme. I guess it's support library upgrade from 23.4.0 to 24.0.

We're on 24.1.1. Perhaps 24.2.x solves it?

Just here to confirm that 24.2.0 does not fix it.

24.2.1 doesn't seem to fix it either.

Yep. :(

Mentioned in issue #779 (closed)

Nexus 5X 7.0 NBD90K same issue http://i.imgur.com/5HigX0w.png

Still exists in 0.101 Changing theme back from dark/night is guesswork

"same issue" or "still exists" comments are redundant, as this issue is reproducible on all devices and hasn't been fixed yet.

mentioned in issue #820 (closed)

mentioned in issue #826 (closed)

So, can't we go any lower with the support lib? What was the feature we needed so badly to break the themes?

Did anyone determine if that change was at fault though?

Problem still exists with v0.102

So it turns out that the ListPreference type (i.e. the one used for the "Theme", "Language", "Automatic update interval", etc) is to blame. Found this SO post which pointed to this reddit post which pointed to this class which seems to solve the problem.

For those interested, the problem is:

• The ListPreference class is responsible for creating a Dialog to pop up.
• It uses the android.app.AlertDialog.Builder, not the android.support.v7.AlertDialog.Builder.
• As it doesn't use the support library builder, it doesn't get the support library styles.
• The solution is to use a custom subclass of ListPreference which uses the correct AlertDialog.Builder, and thus it respects out theme choice.

mentioned in merge request !431 (merged)

Thanks to all who participated in this. Should be fixed in a forthcoming 0.102.1 release once !431 (merged) gets merged.

closed via merge request !431 (merged)

changed milestone to %0.102.1

Confirmed - fixed in 0.102.1 - thank you very much

Thanks for confirming @JonnyTech. Glad it is now sorted.

mentioned in issue #865 (closed)

Still a thing in 0.103, but only in Local repo name dialogue, when using dark or black theme.