java.lang.IllegalArgumentException: Apk.packageName must not be empty: null

From ACRA reports:

java.lang.IllegalArgumentException: Apk.packageName must not be empty: null
	at org.fdroid.fdroid.installer.InstallerFactory.create(InstallerFactory.java:44)
	at org.fdroid.fdroid.AppDetails.uninstallApk(AppDetails.java:980)
	at org.fdroid.fdroid.AppDetails.onOptionsItemSelected(AppDetails.java:866)
	at android.app.Activity.onMenuItemSelected(Activity.java:3204)
	at android.support.v4.app.FragmentActivity.onMenuItemSelected(FragmentActivity.java:406)
	at android.support.v7.app.AppCompatActivity.onMenuItemSelected(AppCompatActivity.java:195)
	at android.support.v7.view.WindowCallbackWrapper.onMenuItemSelected(WindowCallbackWrapper.java:103)
	at android.support.v7.app.AppCompatDelegateImplV9.onMenuItemSelected(AppCompatDelegateImplV9.java:667)
	at android.support.v7.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:810)
	at android.support.v7.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:152)
	at android.support.v7.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:957)
	at android.support.v7.view.menu.MenuBuilder.performItemAction(MenuBuilder.java:947)
	at android.support.v7.widget.ActionMenuView.invokeItem(ActionMenuView.java:616)
	at android.support.v7.view.menu.ActionMenuItemView.onClick(ActionMenuItemView.java:153)
	at android.view.View.performClick(View.java:5609)
	at android.view.View$PerformClick.run(View.java:22263)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6077)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

Comments:

• Pressed the uninstall bitton trying remove a system app without root
• libreoffice uninstall from fdroid with different apk signature
• clicked uninstall on an installed app
• I can't unistall an app

Reassigned to @pserwylo

This may not just be for system apps, but also for apps which are such an old version they are no longer available in any repo. I'm going to make it so that we can pass through an apk to the installer that is populated with info from the Schema.InstalledAppTable and see how that goes, because we should always be able to find an entry in that table with enough data for the installer to know how to remove the apk.

Mentioned in merge request !413 (merged)

For uninstalling, the Apk instance is mostly about finding the notification to remove it, as far as I remember.

Status changed to closed by commit a7a52fbfba3f7c89a249ceb5c3c42d587e37d3f9

Status changed to closed by merge request !413 (merged)