Unclear why a user can't install the extension on >=5.1

In https://gitlab.com/fdroid/fdroidclient/issues/457 (via https://gitlab.com/fdroid/fdroidclient/commit/cf694b6d830debff4bc31a7c24f0759abb7c34e2) we disabled the installation of the extension on 5.1 and later. It seems like a message was added to explain why.

Right now, on master running on my 6.0 device, I get the greyed out button but no explanation why this is. Clicking the option does nothing either.

Did this break at some point? CC @dschuermann @pserwylo @eighthave

To clarify, someone hit this on 5.1 with 0.102 and sent an email to team@. I verified that it also happens on my 6.0 device with master.

I don't understand where this message and greyed out button is, screenshot?

I think the preference to install/update the extension has been made invisible in https://gitlab.com/fdroid/fdroidclient/commit/91cac9fed45e37fbee86f254cbaaab62e9bfa874 The other preference to enable the priv extension is still visible but disabled if the extension is not installed. Keep in mind that the extension could be available as pre-installed on Android >= 5.1

The fix is easy: Change https://gitlab.com/fdroid/fdroidclient/blob/master/app/src/main/java/org/fdroid/fdroid/views/fragments/PreferencesFragment.java#L217 to make it visible or invisible based on installed.

Whatever the reasoning is, it's confusing as it is now. Users see a greyed out "use privileged extension" button. I also got confused, because I understood that would also install it.

I explained the fix. Should be pretty easy. I just don't have time now to implement it.

changed milestone to %0.103 - UX Overhaul

added bazaar label

changed milestone to %0.102.1

assigned to @pserwylo

mentioned in merge request !430 (merged)

closed via commit 2101ec4bbc0877eccded311de50691d07679b458