f-droid repository overwrites guardian repository

• Device OS and version:Copperhead, Android 7.1.1
• Device model/manufacturer: Nexus 5X
• F-Droid version (in the About screen):0.102.2

What did you do? (clear steps if possible)

Installed orbot, without guardian-project repo enabled first. (not sure, wasn't paying attention at first try.) Afterwards, whenever I have guardian-project AND f-droid enabled, orbot will be installed from f-droid repository. (The orbot-version from f-droid is old and doesn't work because of a missing mp3-file)

What did you expect to see?

Since the guardian-project orbot-version is higher, I expected f-droid to install this version

What did you see instead?

although f-droid reports the version number from guardian-project (15.2.0-RC-8-multi), a different version of orbot is installed (15.0.1-rc-3-PIE, as reported by orbot itself) However, f-droid uses the icon of the old version in app-list!

workaround: disable f-droid repository and update to get version from guardian-repo

Don't you have multiple versions to choose from so you can manually choose the latest anyway? IIRC, this might get fixed soonish, multple repos handling I mean.

Yup, you are right on both counts @licaon-kter. There was a change merged late last year which made the multi-repo handling more deterministic. Previously, the last repository to update would be the one which got to save metadata for a particular app. Given that repositories update at different times, it was completely random as to which repo would decide what the "preferred" version of an app was on any given day.

Now, my solution was to make the order of the repos in "Manage Repositories" actually get respected when updating repos. The next step is to be able to reorder the repositories so that you could move the GP repo higher than the F-Droid repo (see !435).

@GammaSQ: Could I ask you to please:

• Remove (not just disable) the F-Droid repo.
• Re-add the repository (i.e. https://f-droid.org/repo)
• Update your repos, and see if the GP repo now takes priority (as it is higher on the list of repos?)

If so, then I'll close this issue, and we will have to wait until !435 makes its way through to master.

Cheers.

@pserwlyo sounds like the current logic is backwards. The priority should be based on when a repo was added to the database. The later the repo was added, the higher priority. f-droid.org is always added first, since its hardcoded as the first option, so it should always have the lower priority. This needs to be fixed since this breaks the way people have been using multiple repos. It turns out that most of the time, the update order follows the order in the database.

Yup, I think you are correct. It shouldn't be very difficult for me to change that around (just change MIN to a MAX here). I'll do that tomorrow. I think we have good test coverage of this stuff too, so should be alright to change for %0.102.3 for instance.

changed milestone to %0.102.3

This gets weirder by the minute ...

remove f-droid: I now only see "noise" in installed apps, though the title is "Installed (4)" (And I would expect orbot, orfox and orwall to be shown as well, since they exist in the guaridan-repo. Possibly I've installed them from the f-droid repository similar to orbot, though orbot currently is the correct, guardian-project version, so I would expect that to show up.)

reinstalled f-droid.org/repo
update
all installed apps visible again
search for orbot under "available" (the version from guardian-project still being installed)
tap orbot (again, wrong icon btw.)
f-droid crashes (not on install/remove/run, on tapping the orbot-slot in the list!)

assigned to @pserwylo

mentioned in merge request !462 (merged)

closed via merge request !462 (merged)

mentioned in issue #926