UnknownFormatConversionException in categories view.

This seems to be related to the Spanish translations:

Change language to Spanish.
Install an earlier version of an app.
Get notified of an update for that app.
Initiate a download of the update for that app.
View the Updates tab.

What will happen is it will try to render the following string: Context.getQuantityString(R.plurals.app_list__age__released_x_days_ago, ageInDays, ageInDays). In English we have the following translation for this:

<plurals name="app_list__age__released_x_days_ago">
    <item quantity="one">Released %1$d day ago</item>
    <item quantity="other">Released %1$d days ago</item>
</plurals>

But Spanish has the following translation:

<plurals name="app_list__age__released_x_days_ago">
    <item quantity="one">%1 publicada ayer</item>
    <item quantity="other">%1 publicada hace $d días</item>
</plurals>

Note the %1 at the beginning of each item. This breaks when the getQuantityString() eventually calls String.format(). The %1 in one seems like a typo. The %1 in other seems like it should be next to the $d. I'm going to update the translation and then pull the translations.

Going forward, the problem is how do we lint/test for this type of problem. That is where I'm a little stuck. Was it a Weblate bug? Just a typo from the translator? Either way, we don't want to have to spend time hunting down issues like this in the future.

@larjona: FYI this is the bug which you've stumbled across when pressing the "Updates" button. By any chance, are you using the Spanish translation of F-Droid?

@eighthave: I've updated the translation so it should fix this issue. When I do pull-trans.sh it fails to apply the diff from Weblate. To view the conflicts, I can run the command that pull-trans.sh does (git diff HEAD...weblate/master -- */values-*/strings.xml | git apply) but instead of git apply I run git apply -3. I'm concerned that the nature of the clonflicts seem to hint at several things getting removed. Take this conflict for example (from app/src/main/res/values-cs/strings.xml):

    <string name="update_auto_install_summary">Převzít a nainstalovat aktualizace aplikací na pozadí</string>
    <string name="versions">Verze</string>
    <string name="hide_anti_feature_apps">Vyšedit \"anti-feature\" aplikace</string>
    <string name="hide_anti_feature_apps_on">Vyšedit aplikace vyžadující \"anti-features\"</string>
    <string name="warning_no_internet">Nemožno aktualizovat, jste připojený k internetu?</string>
<<<<<<< ours
    <string name="app_details_donate_prompt_unknown_author">Koupit vývojářům kávu za %1$s!</string>
    <string name="app_details_donate_prompt">%1$s vytvořil %2$s. Kup mu kávu!</string>

    <string name="app_version_x_available">Je dostupná verze %1$s</string>
    <string name="app_version_x_installed">Verze %1$s</string>

    <plurals name="my_apps_header_number_of_updateable">
	<item quantity="one">%1$d aktualizace</item>
	<item quantity="few">%1$d aktualizace</item>
	<item quantity="many">%1$d aktualizací</item>
	<item quantity="other"/>
</plurals>

    <string name="clear_search">Vymazat hledání</string>

    <string name="repositories_summary">Přidat další zdroje aplikací</string>
    <string name="main_menu__latest_apps">Nejnovější</string>
    <string name="main_menu__categories">Kategorie</string>


    <string name="notification_title_single_update_available">Dostupná aktualizace</string>
    <string name="notification_title_single_ready_to_install">Připraveno k instalaci</string>
    <string name="notification_title_single_ready_to_install_update">Aktualizace připravena k instalaci</string>
    <string name="notification_title_single_install_error">Instalace selhala</string>
    <string name="notification_content_single_downloading">Stahování \"%1$s\"…</string>
    <string name="notification_content_single_downloading_update">Stahování aktualizace pro \"%1$s\"…</string>
    <string name="notification_content_single_installing">Instalování \"%1$s\"…</string>
    <string name="notification_content_single_installed">Úspěšně nainstalováno</string>
    <string name="notification_content_single_install_error">Instalace selhala</string>
    <string name="notification_summary_updates">%1$d aktualizací</string>
    <string name="notification_summary_installed">%1$d aplikací nainstalováno</string>
    <string name="notification_title_summary_update_available">Dostupná aktualizace</string>
    <string name="notification_title_summary_downloading">Stahování…</string>
    <string name="notification_title_summary_downloading_update">Stahování aktualizace…</string>
    <string name="notification_title_summary_ready_to_install">Připraveno k instalaci</string>
    <string name="notification_title_summary_ready_to_install_update">Aktualizace připravena k instalaci</string>
    <string name="notification_title_summary_installing">Instalování</string>
    <string name="notification_title_summary_installed">Úspěšně nainstalováno</string>
    <string name="notification_title_summary_install_error">Instalace selhala</string>
    <string name="notification_action_update">Aktualizovat</string>
    <string name="notification_action_cancel">Zrušit</string>
    <string name="notification_action_install">Instalovat</string>

<string name="app_recommended_version_installed">Verze %1$s (doporučeno)</string>
    <string name="app__newly_added">Novinka</string>

    <string name="installed_apps__activity_title">Nainstalované aplikace</string>
    <string name="installed_app__updates_ignored">Ignorované aktualizace</string>
    <string name="installed_app__updates_ignored_for_suggested_version">Ignorované aktualizace pro verzi %1$s</string>

    <string name="main_menu__swap_nearby">Poblíž</string>

    <string name="preference_category__my_apps">Moje aplikace</string>
    <string name="preference_manage_installed_apps">Spravovat nainstalované aplikace</string>


    <string name="tts_category_name">Kategorie %1$s</string>

    <string name="app__install_downloaded_update">Aktualizovat</string>

    <string name="app_list__name__downloaded_and_ready_to_update">Aktualizovat %1$s</string>
    <string name="app_list__name__downloaded_and_ready_to_install">Instalovat %1$s</string>
    <string name="app_list__name__downloading_in_progress">Stahování %1$s</string>
    <plurals name="app_list__age__released_x_days_ago">
	<item quantity="one">Vydáno před %1$d dnem</item>
	<item quantity="few">Vydáno před %1$d dny</item>
	<item quantity="many">‚Vydáno před %1$d dny</item>
	<item quantity="other"/>
</plurals>

    <string name="updates__tts__download_app">Stáhnout</string>
    <string name="updates__tts__download_updates_for_all_apps">Stáhnout všechny aktualizace</string>

=======
>>>>>>> theirs
    </resources>

Which seems to show Weblate losing out on heaps of translations compared to what is in master (from an earlier Weblate pull?). I'm by no stretch an expert on pulling from Weblate yet, but I plan on learning the ins-and-outs so as to be able to solve this properly. In the mean time, perhaps @mvdan: do you have a suggestion on what might be going on here?

As far as I can tell, weblate includes these strings, master includes them, so I'm a bit stumped.

Here is a rudimentary check which we could put in our tools/ directory which picks up the problem:

$ grep -P "%\d[^$]" app/src/main/res/values*/strings.xml

app/src/main/res/values-es/strings.xml:	<item quantity="one">%1 publicada ayer</item>
app/src/main/res/values-es/strings.xml:	<item quantity="other">%1 publicada hace $d días</item>

Yes, I'm using the Spanish translation. I can change "ayer" "yesterday" to "hace

d día" "

d day ago" in the Spanish translation, but "1 day ago" feels strange. A Spanish user suggested even to change the English one to "yesterday" too.

But of course a not so natural translation is better than a crash :)

Thanks

Laura Arjona Reina https://wiki.debian.org/LauraArjona

@pserwylo we already have checks like that for bad formats in a script. Feel free to add it there (if it isn't already). I used to run it after every weblate sync. Perhaps nobody is running it anymore.

Thanks @mvdan. It runs on CI, but I had to make an adjustment to support android plurals. They are in <plural><item /></plural> tags, rather than the usual <string/> tags that the script checks for. I've got it working and will submit a MR soon.

Do you have any idea about the merge conflicts I've outlined above? That is what I'm really struggling with now.

mentioned in merge request !472 (closed)

Do you have any idea about the merge conflicts I've outlined above? That is what I'm really struggling with now.

Have you talked to @eighthave? He was the last to pull from weblate. Are you certain you're pulling weblate on a branch that already has the latest weblate pull?

assigned to @eighthave

added localization label

I'm seeing this: https://gitlab.com/snippets/1657914 is it the same thing?

Almost done with a complete test suite for this issue. It'll detect the kind of format specified in the source string, then try that format on all translations.

closed via merge request !484 (merged)

mentioned in issue #1129 (closed)

UnknownFormatConversionException in categories view.

Designs

Child items ...

Activity

Admin message

Admin message

UnknownFormatConversionException in categories view.

Activity