make proper OTA update ZIP installer

• Device OS and version: cm-13.0-20160820-SNAPSHOT-ZNH5YAO0J3-jfltexx
• Device model/manufacturer: Samsung Galaxy S4 (International LTE)
• F-Droid version (in the About screen): 0.102.1

What did you do? (clear steps if possible)

Open F-Droid, select org.fdroid.fdroid.privileged.ota, click "install".

What did you expect to see?

Download of the "Over-The-Air" (OTA) update zip file.

What did you see instead?

After the download finished, I got this error message in logcat:

04-11 11:01:23.363  8980 23356 E Installer: Parsing apk file failed!Maybe minSdk of apk is lower than current Sdk?Look into logcat for more specific warnings of Android's PackageParser
04-11 11:01:23.363  8980 23356 E Installer: org.fdroid.fdroid.installer.ApkVerifier$ApkVerificationException: Parsing apk file failed!Maybe minSdk of apk is lower than current Sdk?Look into logcat for more specific warnings of Android's PackageParser
04-11 11:01:23.363  8980 23356 E Installer:     at org.fdroid.fdroid.installer.ApkVerifier.verifyApk(ApkVerifier.java:69)
04-11 11:01:23.363  8980 23356 E Installer:     at org.fdroid.fdroid.installer.Installer.installPackage(Installer.java:234)
04-11 11:01:23.363  8980 23356 E Installer:     at org.fdroid.fdroid.installer.InstallerService.onHandleIntent(InstallerService.java:77)
04-11 11:01:23.363  8980 23356 E Installer:     at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:66)
04-11 11:01:23.363  8980 23356 E Installer:     at android.os.Handler.dispatchMessage(Handler.java:102)
04-11 11:01:23.363  8980 23356 E Installer:     at android.os.Looper.loop(Looper.java:148)
04-11 11:01:23.363  8980 23356 E Installer:     at android.os.HandlerThread.run(HandlerThread.java:61)
04-11 11:01:23.381  8980  8980 E AppDetails: install aborted with errorMessage: Parsing apk file failed!Maybe minSdk of apk is lower than current Sdk?Look into logcat for more specific warnings of Android's PackageParser

I have this issue, too. (In the end, I installed the downloaded ota file from /data/data/org.fdroid.fdroid/cache/apk/... with TWRP, and it worked.)

added confirmed label

Thanks for the report and logcat @ilf. I can confirm this too.

@eighthave: Looks like we have a built in assumption that we are downloading Apk files. Not sure if this was introduced in the new UI or not, but whenever we download media other than .apk files, we need to rethink what happens:

• After the download is complete (e.g. we can't just pass it to the installer)
• When viewing the app details page after downloading (e.g. we shouldn't show "Install" any more. But also, do we even know where they get downloaded to? What does it mean to have a media file "Installed"? Obviously our InstalledAppProvider which queries PackageManager is no good here)

Thoughts?

assigned to @cde

@cde I recommend setting up your own test repo for this, perhaps pushing it to gitlab.com using the new servergitmirrors function. You can also try http://testy.at.or.at/fdroid/repo which sometimes has non APK files in it.

changed milestone to %1.0

added bazaar label

mentioned in issue privileged-extension#20 (closed)

Also reported at https://gitlab.com/fdroid/privileged-extension/issues/20

What I was planning was to modify InstallerFactory to have a new constructor which could take something other than Apk, to avoid hacks / assumptions, but that will need a good amount of code changes since lots of places assume that we're dealing with only APKs.

For now, for 0.103, to avoid this crash, I was thinking of checking Apk.apkName and going with another flow if it doesn't endsWith(".apk")

Could have a DummyInstaller for now, and then later on add different installers for different types as needed. Thoughts?

DummyInstaller sounds good, just to get %0.103 - UX Overhaul finalized.

we can leave this issue open then, for 0.104.

changed title from org.fdroid.fdroid.privileged.ota: Parsing apk file failed! Maybe minSdk of apk is lower than current Sdk? to make proper OTA update ZIP installer

a nice simple start to this would be to just treat all .zip files as OTA files, and write them to /data/data/org.fdroid.fdroid/OTA or something like that.

Yeah, and could show a toast / dialog with the path to install from recovery.

yeah @cde, a toast would be great. Not everybody knows the correct path to search for the ota.zip ...

mentioned in merge request !504 (merged)

Started with the DummyInstaller for %0.103 - UX Overhaul in !504 (merged)

related #1023 (closed)

https://gitlab.com/fdroid/fdroidclient/merge_requests/541 addresses this as well, and OTA files are downloaded to /data/data/org.fdroid.fdroid/ota

I think we could close this now, as the files are copied to a path and the user is told that by a toast.

While there is the possibility of auto install by writing recovery command files, that won't always work depending on the recovery installed, and would need root - not worth it.

closed