Crash when uninstalling app

During uninstall, we are getting a lot of crash reports like this one:

java.lang.IllegalArgumentException: Apk.packageName must not be empty: null
	at org.fdroid.fdroid.installer.InstallerFactory.create(InstallerFactory.java:44)
	at org.fdroid.fdroid.AppDetails2.uninstallApk(AppDetails2.java:682)
	at org.fdroid.fdroid.views.AppDetailsRecyclerViewAdapter$3.onClick(AppDetailsRecyclerViewAdapter.java:945)
	at android.view.View.performClick(View.java:5280)
	at android.view.View$PerformClick.run(View.java:21239)
	at android.os.Handler.handleCallback(Handler.java:739)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:234)
	at android.app.ActivityThread.main(ActivityThread.java:5526)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

The comments include:

• It crashed as soon as I tried to uninstall adblocker plus.
• Click uninstall because signing key difference!

Also, they are unique to the 0.103-alpha* releases.

I hit the exact same crash earlier, it is an oversight as this was a non issue in AppDetails

See https://gitlab.com/fdroid/fdroidclient/merge_requests/478 I'll do what Hans said (bring back getInstalledApk() and also move it to a separate commit.

mentioned in merge request !500 (merged)

assigned to @cde

See above MR, should fix this as well. Unable to test right now.

Edit: Just tested, MR fixes this.

closed via merge request !500 (merged)