Bump target SDK and support libs to 23

Android 6.0 brought some changes that affect F-Droid client:

1. Apache HTTP client removal
2. PackageInfo.REQUESTED_PERMISSION_REQUIRED removal

Closes #518 (closed).

This is great, thanks! But we're doing a stable this weekend, so if that's fine by you we'll wait until after that to merge.

Sure. Besides, CI currently does not have Support Library 23.2. I'd prefer to wait until tests pass.

Well, you should fix .gitlab-ci.yml too. For example, change android-22 for android-23.

Not sure what's up with the support repo - it should have them, as we install it from scratch at each job.

Oh, and what about the rest of the TODO items? Or is this just to get F-Droid building, and then the rest can be tweaked later?

If so, I'd say open issues about each of the remaining TODOs, so that we don't forget.

Added 2 commits:

• 6b79e46f - Bump target SDK to 23
• 310004a5 - Permit deprecated Apache HTTP Client

Oh, and what about the rest of the TODO items? Or is this just to get F-Droid building, and then the rest can be tweaked later?

This MR makes only those changes that are necessary to build and run F-Droid with target SDK 23. If everyone is OK with this, the MR will be merged and the original bug closed. After that I'll file separate bugs for the remaining TODO items.

Sounds good to me!

Oh, you have to switch everything to android-23 at once. Should be easy since there is practically no UI code in the other two projects.

Added 2 commits:

• e25aac6b - Bump target SDK to 23
• d5ccd6c1 - Permit deprecated Apache HTTP Client

Green, excellent! Thanks for fixing it.

I'll branch off stable on sunday, so as soon as I do I'll merge this.

I also like when it's green. :) Thanks for your hints!

Looks good to me, but I'll let @mvdan merge. I hope this doesn't break anything...

We don't have to hope, because we're not merging this three days before the stable.

@relan could you please rebase this MR? You can remove the .gitlab-ci.yml change, as we will no longer use the yaml file to install dependencies.

You can remove the .gitlab-ci.yml change, as we will no longer use the yaml file to install dependencies.

As far as I can see it's not quite true: https://gitlab.com/fdroid/fdroidclient/blob/master/.gitlab-ci.yml#L16

Is test -z "$ANDROID_HOME" condition always false?

Added 46 commits:

• d5ccd6c1...90e64bad - 43 commits from branch fdroid:master
• 77074f83 - Remove PackageInfo.REQUESTED_PERMISSION_REQUIRED
• 21a78054 - Bump target SDK to 23
• e2b81c6b - Permit deprecated Apache HTTP Client

Just found Support Library 23.2 regression: https://code.google.com/p/android/issues/detail?id=201918

Change that CI line if you want, it doesn't matter - the entirety of that will be removed as in fdroidserver.

Note that the issue is a duplicate, this is the one you should track: https://code.google.com/p/android/issues/detail?id=201851

Since this is a non-critical issue and was reported just a few days ago, I'll bet that it will be fixed before we do our next stable in a month or so. And if it hasn't, it's not a big deal.

Status changed to merged

Filed #586, #587 and #588 as discussed.

mentioned in issue #597 (closed)