Add option to hide anti feature apps

Added option under Setting to grey out apps requiring anti-features similar to ignoring rooted apps on a non-rooted device.

Reassigned to @pserwylo

Thanks for the contribution @nighthawk24. I'll drop a couple of comments inline against the diff, but they are all very minor. This will go a great way to addressing #564. In the future, we should have the option to ignore apps based on specific anti features, but this is a great first step. If you could take a look at my comments then we can get this merged. Cheers!

Thanks for the review @pserwylo I'll update the merge request with the said changes.

Added 1 commit:

• 027ace40 - Update naming convention as per review. Add antifeatures list length check to fi…

Out of curiosity, why grey out instead of hide completely? We grey out incompatible apps instead of hiding them entirely because otherwise people might think that these apps are not in F-Droid at all. But in this case, people actively choose not to see these apps.

And remember to squash once the MR is ready!

Yeah, I agree with @mvdan: for the use case of Replicant, I think non-free apps should be entirely hidden, not greyed out.

Also, in Android Studio, be sure to use Ctrl-Alt-O to organize imports and Ctrl-Alt-L to format the source code. That helps pass the checkstyle and pmd tests.

Why grey out instead of hide completely?

At this stage, it is a much easier implementation. It doesn't require changing any database queries at all.

In the future, #564 will take care of actually excluding apps with (specific) anti-features. Until then, this is a good first step.

Thanks for addressing those comments of min @nighthawk24. If I could ask one last thing (sorry I didn't mention earlier) but as @mvdan mentioned, could you please rebase this branch so that your final commit (addressing CR comments) is squashed into the previous commit? While you're there, if you could also add a // NOPMD comment above the failing line in AppFilter (check out the "builds" tab in this Merge Request, then click on the "pmd" build). You can test that this works locally by running gradle pmd before pushing and letting CI do its checks too.

Then I'll get this merged. Cheers.

Added 12 commits:

• 027ace40...fde227e8 - 9 commits from branch fdroid:master
• 1f354a1b - Add option to grey out apps requiring anti-features.
• 1e95f57e - Fix checkstyle issue.
• 632eeff6 - Update naming convention as per review. Add antifeatures list length check to fi…

Added 1 commit:

• 5d58fc01 - Fix PMD issue.

Thanks @nighthawk24, this is ready for me to merge now.

@mvdan: are we within striking distance of a stable, such that i should branch a stable-v0.101 branch, and merge this MR into master for 0.102?

@pserwylo yeah, branch off and merge.

I pushed the branch stable-v0.101, so this can be merged.

Milestone changed to %0.102

Status changed to merged

@eighthave @pserwylo In the future, we really want to make sure people are squashing. Otherwise we will end up with a third of our commits being "pmd fixes" and "make checkstyle happy".