fdroidserver/update.py requires a strictly matching version of aapt

$ fdroid update
CRITICAL: Unknown exception found!
Traceback (most recent call last):
  File "/usr/bin/fdroid", line 147, in <module>
    main()
  File "/usr/bin/fdroid", line 124, in main
    mod.main()
  File "/usr/lib/python3/dist-packages/fdroidserver/update.py", line 1397, in main
    apks, cachechanged = scan_apks(apps, apkcache, repodirs[0], knownapks, options.use_date_from_apk)
  File "/usr/lib/python3/dist-packages/fdroidserver/update.py", line 639, in scan_apks
    perm_match = re.match(permission_pat, line).groupdict()
AttributeError: 'NoneType' object has no attribute 'groupdict'

The line variable contains uses-permission:'android.permission.ACCESS_COARSE_LOCATION'.

fdroid tool does this for many APKs in the repository :(

Ping @eighthave who IIRC wanted to replace the use of the aapt executable.

This happens when using mismatched aapt and fdroidserver versions. For example, using fdroidserver 0.7 with aapt 20.0.0. As @mvdan says, we need to parse the APKs in Python so we don't have this very brittle setup. I'm hoping androguard provides what we need, but I'm also eager to hear suggestions.

Changed title: update.py, line 639: AttributeError: 'NoneType' object has no attribute 'groupdict' → fdroidserver/update.py requires a strictly matching version of aapt

Added bazaar label

Milestone changed to %0.8

mentioned in issue #258 (closed)

On the other hand we have regression aapt that newer versions do not android:label at all (or the correct language).

Ref: https://code.google.com/p/android/issues/detail?id=213397 (upstream)

Ref: https://gitlab.com/fdroid/fdroidserver/issues/258#note_24522740 (our issue, closed in favor of this one)

There is now an unofficial py2/py3 port of androguard, so we should able to use that soon. We just need to figure out how to get the author to accept the code:

https://github.com/androguard/androguard/pull/208

assigned to @TheZ3ro

@TheZ3ro could you look at replacing all calls to aapt using androguard? Since androguard is still only py2 modules, it would mean calling the androguard utilities via subprocess.

@eighthave by using androlyze.py and the interactive mode?

mentioned in issue #269 (closed)

mentioned in issue admin#24 (closed)

removed assignee

changed milestone to %1.0