Ensure that all needed dependencies are downloaded in setup.sh

When trying to get repomaker working on Debian Jessie yesterday, I encountered several dependencies that were not download by setup.sh. To get it working, I needed to install the following apt packages:

• python3-pip
• libffi-dev (I'm unsure if this was already installed)
• python3-cryptography
• python3-pyparsing
• python3-appdirs

Additionally, the version of npm is very old, so I had to install a newer version: npm install -g npm --user

Because in Debian Node.JS is available under the command nodejs but npm wants to use node, I had to create a symlink: sudo ln -s "$(which nodejs)" /usr/local/bin/node

I just did a fresh install on Debian 9 Stretch and the pip install part went through without any problem and without needing to install further packages manually.

However, due to the old npm version, I had to upgrade it as described above. Since npm modules are only required for compiling the styling, this can be worked around with by shipping compiled javascript and CSS files for releases.

In a5256aef53578f373bfaaeb4ffd66d5fcb9cd170 I now split out the development requirements from the requirements necessary to run RepoMaker.

added bazaar label

changed milestone to %1.0

added dev label

Now I also have a development machine based on Debian sid and installing Repomaker there was fine, I did not need to install any packages via apt beside the ones described in the readme to start Repomaker. Only later when I ran tests I figured out that rsync was missing. @grote Should I open a MR to add rsync to README.md and close this issue? Or should we test on Debian stable again?

Testing on stretch would be nice.

I'll add rsync and git to the system check and debian dependencies.

assigned to @grote

added Doing label

@grote Can this be closed? I suggest opening a separate issue for testing on Stretch, with other issues for popular distros, Windows and OSX too.

closed